Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eae90e1e-408b-4f9a-9211-649da28b0358@collabora.com>
Date:   Thu, 10 Nov 2022 16:03:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] soc: mediatek: Add deprecated compatible to mmsys
Content-Language: en-US
To:     matthias.bgg@kernel.org, matthias.bgg@gmail.com,
        nancy.lin@mediatek.com
Cc:     linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221110120222.32297-1-matthias.bgg@kernel.org>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20221110120222.32297-1-matthias.bgg@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Il 10/11/22 13:02, matthias.bgg@kernel.org ha scritto:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> For backward compatibility we add the deprecated compatible.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>

Hello Matthias,

You forgot to advertise that this commit depends on [1]... and I'm afraid
that you have to push a v2 anyway, because...

> ---
>   drivers/soc/mediatek/mtk-mmsys.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index ba2e79b26993b..47106f557c574 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -303,6 +303,10 @@ static const struct of_device_id of_match_mtk_mmsys[] = {
>   		.compatible = "mediatek,mt8192-mmsys",
>   		.data = &mt8192_mmsys_driver_data,
>   	},
> +	{	/* deprecated compatible */
> +		.compatible = "mediatek,mt8195-mmsys",
> +		.data = &mt8195_mmsys_match_data,

...mt8195_mmsys_match_data doesn't exist anymore after [1], so this should be

		.data = &mt8195_vdosys0_driver_data,

[1]: https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097

Cheers,
Angelo