Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <674efb84-c6f4-eb67-ce7f-2471384a8698@samsung.com>
Date:   Thu, 10 Nov 2022 16:07:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0)
        Gecko/20100101 Thunderbird/102.4.2
Subject: Re: [PATCH v2 1/2] gpiolib: of: Prepare of_gpiochip_add() /
 of_gpiochip_remove() for fwnode
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Thierry Reding <thierry.reding@gmail.com>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>
From:   Marek Szyprowski <m.szyprowski@samsung.com>
In-Reply-To: <Y20CZtHkaLmQj+IP@smile.fi.intel.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20221108133853.61884-1-andriy.shevchenko@linux.intel.com>
        <Y2z7IJv2IQy+Mlsh@orome> <Y20CZtHkaLmQj+IP@smile.fi.intel.com>
        <CGME20221110150726eucas1p11ed664a096b2169dd9e568c0f6113104@eucas1p1.samsung.com>
Precedence: bulk

Hi Andy,

On 10.11.2022 14:53, Andy Shevchenko wrote:
> On Thu, Nov 10, 2022 at 02:22:40PM +0100, Thierry Reding wrote:
>> On Tue, Nov 08, 2022 at 03:38:52PM +0200, Andy Shevchenko wrote:
> ...
>>> +	np = to_of_node(chip->fwnode);
>> This breaks a number of GPIO controllers on Tegra where chip->fwnode
>> ends up never getting set. I also see this break drivers like the MFD-
>> based gpio-max77620, so I don't think this is anything specific to the
>> Tegra drivers.
>>
>> Looking at how fwnode handling works, it seems like we're checking the
>> wrong value here, since chip->fwnode is only for explicit overrides of
>> the fwnode value.
>>
>> The below patch fixes the regression for me:
> Thank you! Can you submit it as a formal fix? (Also see below)
> Of if Bart prefers I can respin fixed verison. Bart?
>
> ...
>> -       np = to_of_node(chip->fwnode);
>> +       np = to_of_node(chip->gpiodev->dev.fwnode);
> dev_fwnode(&chip->gpiodev->dev)
>
> ...
>
>
> Your report makes me wonder if I can Cc you the patch that changes that logic,
> so you can help with a testing on OF platforms.

I've also found this issue with today's linux-next and bisected to this 
patch. I confirm that the above change fixes the boot issue on Raspberry 
Pi 4B and Odroid-M1 boards. Feel free to add:

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>


Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland