Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <613ca9c7-399b-08ac-8333-907128511e80@nvidia.com>
Date:   Thu, 10 Nov 2022 16:43:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101
 Thunderbird/107.0
Subject: Re: [PATCH v2] net/mlx5: DR, Fix uninitialized var warning
Content-Language: en-US
To:     YueHaibing <yuehaibing@huawei.com>, saeedm@nvidia.com,
        leon@kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, kliteyn@nvidia.com,
        mbloch@nvidia.com, erezsh@mellanox.com, valex@nvidia.com
Cc:     netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221110134707.43740-1-yuehaibing@huawei.com>
From:   Roi Dayan <roid@nvidia.com>
In-Reply-To: <20221110134707.43740-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTF6V2FVZ0ZTVklJOWE3NmtxdGE3QW1MNzVkNHgvb3RISFc5TG40SWp0WlNW?=
 =?utf-8?B?OVhKS21lL1l4OHBNM2lLcmtkK1d3L1FRRG8rMTM3d3BXNm9od3ZPVzBCajg0?=
 =?utf-8?B?RmZHbTd4K2tsUnhQRXdVZjQvVFNORExaU3RhZFFCT25CRW83dmw5U0kyUnhw?=
 =?utf-8?B?KzJBNkVGQWlCejR3bHhMVWVZOEQrYTNpWkdYSzVxN0VjZFRndVVtVFM2b0ox?=
 =?utf-8?B?SXpsYXRmL3BxakppRTRwKzkrZ3IvOHN6MTNnRGU2c2lRNWcrQTEwdDFkcnRS?=
 =?utf-8?B?bEd1eVlhY1pDMXVMNTM2enlWbjA2UEtZbHBySVBWVjB5LzBlTGFWR3p1QWRM?=
 =?utf-8?B?RkIrc1NQWnA1eXFIR0ZDbXNrN2ZPSmh4Qnp1cDkvSnROOGZxc000anMzSjFx?=
 =?utf-8?B?VmVEbG1DUGdGQmpUZkd2VWxsTTBjbDRhdDRGeVdOVmFwWUN4MmlpWWFmOU5w?=
 =?utf-8?B?eEdtTFpQdzNXT0wrQk8zNzdnY0NqRENCYTl1aFdGanZhSnQzZlpKalhWUXlP?=
 =?utf-8?B?bVhkWmNSb1Y1NE5zOFVjazJYUXloNHZtVGtkUDVyS2RGVXd6K0NnS29hU3Ji?=
 =?utf-8?B?SEFQWkxQSEJwc2dQajZ2YmxsVTZDb05VVVdoUnhQdlIzTUpqejZoRzJ1VUVW?=
 =?utf-8?B?T3dNTjlKZjVjVStxQlpqcWwwTVZWd1ZZdW9KamNFcFNGdXlCQnM3ay9XQzdF?=
 =?utf-8?B?MjJkOWY1bEs3NnFUbDZxb2FiT05rclRPNkpwdmlDa2phNmpGY3FjeGRIQnRy?=
 =?utf-8?B?cjV2V2llZGpTUWZvZFVUUzJjcHJTQTZJd0sybFkvVmxtTldubUp1SzRIWit4?=
 =?utf-8?B?L2FUWWFJUVNKcWg4aGlqZk1QMzYzRm9wdFJqaFN1bWVMNU9mZHJlaVNKZjc3?=
 =?utf-8?B?OGx2dXI4NWRlNXJod21LWG9lcVpseXRpazlqYmU5MFo0T0l6UGwyWEZ5MXZV?=
 =?utf-8?B?M3czc0pSeDlBYVFhTytvNnFPUldSNXluaFZrSWFjWlF0RUVSQzBWQjhQWGxq?=
 =?utf-8?B?dTk5RmtPSEpvaVBuQndlVkZBeHlHdGl0Sis0WlQ2SkwwdU14L3ZVWXVWaVA4?=
 =?utf-8?B?M2E2a3E3ZE14WXlyTk9NSytVbFRGaHpuTCt4K3lGR1d3UWk4LzR0ZGRZNDIy?=
 =?utf-8?B?NXErWDFVRFVUTGpwQ3ZnVjg3M1RUU201V1VlRVFaTFkwNU5wTWwxbmJPTk5M?=
 =?utf-8?B?bHRENGJ0VUdzR3pjbFczdWNoYjZNZ2F6YWZCcVhja3c5Q0hja3JyelZRTjZX?=
 =?utf-8?B?Uk42Y00zU2Y5QitZdzBWNGVvajcvMjlFSTBGdDNlbTQ0OE9BNC83Zm5lU3dT?=
 =?utf-8?B?Q29Rc0cyRGQ4djcyMkcvTHdUUWYzS2Qzbko5VCtKV3lPQmlrS2J0eGNodXFM?=
 =?utf-8?B?dWV2bjRBeWMvYjN0Y0NyS1kxdVpMa2tHRVRnSUZ5UHkzcm1LNng0Q3UvRWFY?=
 =?utf-8?B?T2NkcHpqQkhaL3ZZd0VvemV2NHZoaVdZVFEyeVVXemM1dWJPWEtzMTh4bXRU?=
 =?utf-8?B?dXF2amtHMHkreWZBblhKcnBNSVB6SkpEQnV4cTZzejRQYThodW5tUWF3Wmpz?=
 =?utf-8?B?WkNFUVF0L2lTTFA2MUpSQlYwZGpHZkVFemJWOGx5aVVDTE5qY0ZzMjVVYW11?=
 =?utf-8?B?SjYzbE1xVDNPWVU0cFJWQXBpR3JSeUVWdW1zVmFuRS9WajlJUzBxTXZvNWdl?=
 =?utf-8?B?UVlwZXh1eE4wU2xLVUZsNEtCSjdHZFptNUw5dkdDV3JHR041RGYwRGpqR3Nt?=
 =?utf-8?B?WGdCUlRPTjZPSmIyRTh2UzI5NHFtT0hYL05Oa3QyS2QzTFZTUGJaMUlkbkl0?=
 =?utf-8?B?VGoxNVNqR2lZeDhUa0dJZGZvTis0UTN4b0hlNGhRVHc4N0IxZWZUQ2tYOFY3?=
 =?utf-8?B?bVlpOEtwT1B0SnVBb3ljZ3ZWOWVjMjFET3o0YW9wSG1xbXdJTXlkMklCSzYw?=
 =?utf-8?B?Z2thS0NtQXl4UlZJSWdkZVhXbGNoSWtDVTBmcURLSTJwL09CSnE0aFRPMFAv?=
 =?utf-8?B?S3JNU3h6MDFFSG9uSlVoYnVna21wc3JQNTFwODVzcWtTTDJENHkweVVkbERs?=
 =?utf-8?B?MHNtT002STZoZGx4TzUvRlNtTFg3UTB1MEZ6Q3dodjJVSk5oOG93VlJaaFl0?=
 =?utf-8?Q?c6TvMayFpAtgu8A2LsRl2vXcu?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5853992d-920c-4433-e978-08dac32a00f4
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5330.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 14:44:00.3608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qNIss9Mksocc649ibwcZchqnkHMKBCsQPtvQM9vffPWdEiqouniYnRS5Rov+Fosz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5083
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/11/2022 15:47, YueHaibing wrote:
> Smatch warns this:
> 
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c:81
>  mlx5dr_table_set_miss_action() error: uninitialized symbol 'ret'.
> 
> Initializing ret with -EOPNOTSUPP and fix missing action case.
> 
> Fixes: 7838e1725394 ("net/mlx5: DR, Expose steering table functionality")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: init ret to -EOPNOTSUPP
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c
> index eb81759244d5..7cc4cb7fa392 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c
> @@ -46,7 +46,7 @@ static int dr_table_set_miss_action_nic(struct mlx5dr_domain *dmn,
>  int mlx5dr_table_set_miss_action(struct mlx5dr_table *tbl,
>  				 struct mlx5dr_action *action)
>  {
> -	int ret;
> +	int ret = -EOPNOTSUPP;
>  
>  	if (action && action->action_type != DR_ACTION_TYP_FT)
>  		return -EOPNOTSUPP;
> @@ -67,6 +67,9 @@ int mlx5dr_table_set_miss_action(struct mlx5dr_table *tbl,
>  			goto out;
>  	}
>  
> +	if (ret)
> +		goto out;
> +
>  	/* Release old action */
>  	if (tbl->miss_action)
>  		refcount_dec(&tbl->miss_action->refcount);

thanks

Reviewed-by: Roi Dayan <roid@nvidia.com>