Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp857928rwb; Thu, 10 Nov 2022 08:12:49 -0800 (PST) X-Google-Smtp-Source: AMsMyM4vjK+LAequrO7OE75k7kB4CdzmQoYRVoA381swaSom9qQcgW9zA3eC7Eq7WCfwd3eQHWZq X-Received: by 2002:a05:6402:c45:b0:442:c549:8e6b with SMTP id cs5-20020a0564020c4500b00442c5498e6bmr64267708edb.123.1668096769142; Thu, 10 Nov 2022 08:12:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668096769; cv=none; d=google.com; s=arc-20160816; b=bN9w6tZnUXHo48h4Wwk6J1sfaV2ddquslT6zCC4KFvnjD/lfLcGlnFMkBN+kegg9rD scHVIaQlBGqefZgI2ahmqgarW/W7bReOI/4Cx1yaUoz5MkCgQoG6bXW6z48afDA0lgzo i1QRNlzq2bh337+XvmzsDEcLfJp3SJMl/9KRmGQzEHg2e2Mq6B0UX7DQ0ra4TrOwGVh6 fNCKaxUqvH246xVQPO0E4kgyZP9YYvjaPKt7hxKGVaNr4i9Yf2ejgRpFo6UTAcMvjNLC aX4RGwd7VbZ8p1t/RPVmImbkeo0kfWUiG0WtxlEYL76Nefa29UWNfGlOfhedTagD9PxO E0bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature; bh=X3S9nujsB/WdRy7NOVKjhuel+EyxVHYqI69jxUlMDzA=; b=ViSZ+EfPwepklbLt/nGbF4CTqFbq2geiLllCFDUE3aA/luUgrVAK6EYW/sxzyftHVa HJLFuo33/pk86vGU1zEodnU/EewP5dBGXLPSmxIuLNz3fqh6ZK72pJyt1C+zce0NgWun zhgs17GQONsLO+z9a8dWDbjUaXCyG8wASeR9rFxg1P5K2L5RH2ZfaGZWAdg6oYMMobbj M7httnmVHUwodeH/+iWW2gkNjo3aECCfmwxxXzJWPhIchhhFGBzHkFnEqel89Tq3frVG YBnVZZQviMFVZNFr22Fp9VIa3hrbixyZMITNJuRCLnmFCv7PCYdYwlyk9O0Kr8OI+0ln 6ePA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Rdscuz84; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa12-20020a1709076d0c00b0078212b2e6e2si18933999ejc.75.2022.11.10.08.12.23; Thu, 10 Nov 2022 08:12:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Rdscuz84; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231631AbiKJPkp (ORCPT + 92 others); Thu, 10 Nov 2022 10:40:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231599AbiKJPki (ORCPT ); Thu, 10 Nov 2022 10:40:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E3ED2CC96; Thu, 10 Nov 2022 07:40:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 34B87B82224; Thu, 10 Nov 2022 15:40:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9399C433D6; Thu, 10 Nov 2022 15:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668094834; bh=IihG5F+175wM6zXZz+Enufph03JbHLOePA/iQlUtjrM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Rdscuz840FMK66mNyb4CIacgEFlwcs50WejbujTcMgQGEAVdeszRpPMd4H/oWugRZ 0Kn/lNpMJ5XIKDQwGcJAOIZsqM6crKrGWwyrwjvlJQzf2riY5xHu2apJY/HVeKIg4j zpTXMTx5abr85zspZ0ocZffwZrNQyztHgMtFHmFTfkkP9F8x6K6qCd+QAXm5KSrlg0 K0zgTH8+3wc0GTLFhpohrnoGkqpoIG1AfQ6FV320OHko9XQO1MiU3xqkWyZPm1zOWl Xu99/Rc5O/gpgc6TzkSQP7ZdLsg4Nsp6NarNtuf+eny0C3d9K24ZqR870V4ovPT4ix En3WOpKSipcnQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ot9fM-005Brn-Gt; Thu, 10 Nov 2022 15:40:32 +0000 Date: Thu, 10 Nov 2022 15:40:32 +0000 Message-ID: <86iljmq0lr.wl-maz@kernel.org> From: Marc Zyngier To: Richard Fitzgerald Cc: , , , , , , , , , , Subject: Re: [PATCH 09/12] irqchip: cirrus: Add driver for Cirrus Logic CS48L31/32/33 codecs In-Reply-To: <4d50faae-7eea-bc5a-9def-935c2063a7b3@opensource.cirrus.com> References: <20221109165331.29332-1-rf@opensource.cirrus.com> <20221109165331.29332-10-rf@opensource.cirrus.com> <87mt8zutib.wl-maz@kernel.org> <86pmdvow5y.wl-maz@kernel.org> <4d50faae-7eea-bc5a-9def-935c2063a7b3@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rf@opensource.cirrus.com, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org, broonie@kernel.org, tglx@linutronix.de, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Nov 2022 13:14:30 +0000, Richard Fitzgerald wrote: > > I note your accusation that we were too lazy (or too stupid?) > to think of this. Take it the way you want. But I criticise the code, not the author. And I'm merely pointed out that there was significant room for improvement. M. -- Without deviation from the norm, progress is not possible.