Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965527AbXHGWRu (ORCPT ); Tue, 7 Aug 2007 18:17:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965385AbXHGWQt (ORCPT ); Tue, 7 Aug 2007 18:16:49 -0400 Received: from livid.absolutedigital.net ([66.92.46.173]:54210 "EHLO mx2.absolutedigital.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965384AbXHGWQq (ORCPT ); Tue, 7 Aug 2007 18:16:46 -0400 Date: Tue, 7 Aug 2007 18:15:37 -0400 (EDT) From: Cal Peake To: Linus Torvalds cc: Chuck Ebbert , Gabriel C , Frank Hale , Kernel Mailing List , Kernel ACPI Mailing List , len.brown@intel.com, Thomas Gleixner , Ingo Molnar , Andrew Morton , Andi Kleen Subject: Re: ACPI on Averatec 2370 In-Reply-To: Message-ID: References: <5ebbd9b50707291105w316f98e5h3fa17204c9119a2f@mail.gmail.com> <46ACD8DB.2020108@googlemail.com> <46B22BDA.8090604@redhat.com> <46B23E08.4070106@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 37 On Fri, 3 Aug 2007, Linus Torvalds wrote: > > MSR_K8_ENABLE_C1E lo == 0x04c14015 > > MSR_K8_ENABLE_C1E hi == 0x00000000 > > lo & ENABLE_C1E_MASK == 0 > > And yeah, that claims that C1E is not on, but: > > > amd_apic_timer_broken: forcing return value of 1 So it seems my initial debugging report was, err, incomplete. I failed to notice that the amd_apic_timer_broken function was getting called twice, once for each core. The second call shows this: MSR_K8_ENABLE_C1E == 0x14c14015 which causes our ENABLE_C1E_MASK check to be true and thus properly return 1 from the function. So when we call the above function from init_amd we prolly need to do a set_bit(X86_FEATURE_LAPIC_TIMER_BROKEN, c->x86_capability); for each core if any of them happen to return true upon checking for a broken timer. Andi, does that seem right? -- Cal Peake - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/