Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp939515rwb; Thu, 10 Nov 2022 09:08:29 -0800 (PST) X-Google-Smtp-Source: AMsMyM6Iif6q+OcbqKLtqyeAY6UYAGuo6UV6UJITcyG25TH1mwayvr4JA9NGcqmO3lBzwYwu7xiE X-Received: by 2002:a65:5a4c:0:b0:460:ea43:93c6 with SMTP id z12-20020a655a4c000000b00460ea4393c6mr2833372pgs.173.1668100109107; Thu, 10 Nov 2022 09:08:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668100109; cv=none; d=google.com; s=arc-20160816; b=hsSGsHM0n6evFUwBOZIDTPWh4NL0Vc9SQYMb1pHGXw5fYqSqzkvWrmi0yqCWAgPNJp kq8VWicblTIbYlKTeLuUdTUWA/hraQa3Lf27KVhvsW0qQ49Xca4hVATVqRVX9C+WU1xr yqJnd+skQSc9sNoqiVlTFM4T3T0J9CBuZxAkk6KSPF4VHvYDLVt/0dUgex6zYdLMAGz0 KLojakfa+FpKOFQVMbXney/lN5SkgQue3+wIPyTl25nh8ihcFv9SoC0WiALDLG3TpPgP 2iql2BbeSOkyZuIt+B5tmbt7UlRzL/w+tFxwkeMjZ+6rdsAsNzOvWC4IMb9Qw8vbp/Af U6vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=A7TCdSMmg82PeIeaorLSU9VIwQdQJtP2QSDjAEX/hoE=; b=If9PJmaOKeJ1nMrWZJBfAL24uSxzWSQTaCMVB0FkpFRO+p2wZHhSlOiz+H5i3KJomf GOZPRDd8RjOYUpa/hLUvaofTCVdZ+OKziPV10cgkIxmxr7TwDjVnx2irnzPKIOqHMqS6 GMorjs0LP6iGvmXeoOyYPfEgb9Q5AjpJnuoAJNWbJzCsarCvOKPCfUgwZoZKK2X5zSzk tR5UETHc8I+jvSQGFd0vHjPJOZMGIhtlzyIjgoxZH9keYweajjPtYuXeJR9Gf5Q4Hbvx DOEr6B4gAS2JSlqpqG3l42jxE4vaPRfzplDLhExAncJ5gSEKGhLj3n9bOv74jFqqEQ/z NcOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m12-20020a656a0c000000b0044d72a10ab0si7037389pgu.342.2022.11.10.09.08.12; Thu, 10 Nov 2022 09:08:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229952AbiKJQMa (ORCPT + 92 others); Thu, 10 Nov 2022 11:12:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbiKJQM2 (ORCPT ); Thu, 10 Nov 2022 11:12:28 -0500 X-Greylist: delayed 478 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 10 Nov 2022 08:12:25 PST Received: from mail.enpas.org (zhong.enpas.org [IPv6:2a03:4000:2:537::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 828007642; Thu, 10 Nov 2022 08:12:25 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail.enpas.org (Postfix) with ESMTPSA id 9C730FFA84; Thu, 10 Nov 2022 16:04:22 +0000 (UTC) Date: Fri, 11 Nov 2022 01:04:12 +0900 From: Max Staudt To: Ziyang Xuan Cc: , , , , , , , , , Vincent Mailhol Subject: Re: [PATCH] can: can327: fix potential skb leak when netdev is down Message-ID: <20221111010412.6ca0ff1c.max@enpas.org> In-Reply-To: <20221110061437.411525-1-william.xuanziyang@huawei.com> References: <20221110061437.411525-1-william.xuanziyang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (CC Vincent, he may be interested) On Thu, 10 Nov 2022 14:14:37 +0800 Ziyang Xuan wrote: > Fix it by adding kfree_skb() in can327_feed_frame_to_netdev() when netdev > is down. Not tested, just compiled. Looks correct to me, so: Reviewed-by: Max Staudt Thank you very much for finding and fixing this! Max