Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 16:06:13 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Rong Tao <rtoax@foxmail.com>, Rong Tao <rongtao@cestc.cn>,
        wuchi <wuchi.zero@gmail.com>,
        open list <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: [PATCH] radix tree test suite: Fix uninitialized variable
 compilation warning
Message-ID: <Y20hded53owR/dPo@casper.infradead.org>
References: <tencent_DF74099967595DCEA93CBDC28D062026180A@qq.com>
 <20221109162348.3dbde3a7942c303af012276c@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221109162348.3dbde3a7942c303af012276c@linux-foundation.org>
Precedence: bulk

On Wed, Nov 09, 2022 at 04:23:48PM -0800, Andrew Morton wrote:
> On Wed,  9 Nov 2022 22:34:25 +0800 Rong Tao <rtoax@foxmail.com> wrote:
> 
> > [PATCH] radix tree test suite: Fix uninitialized variable compilation warning
> 
> This is not the test suite.
> 
> > We need to set an initial value for offset to eliminate compilation
> > warning.
> > 
> > How to reproduce warning:
> > 
> > $ make -C tools/testing/radix-tree
> > radix-tree.c: In function ‘radix_tree_tag_clear’:
> > radix-tree.c:1046:17: warning: ‘offset’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> >  1046 |                 node_tag_clear(root, parent, tag, offset);
> >       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > ...
> >
> > --- a/lib/radix-tree.c
> > +++ b/lib/radix-tree.c
> > @@ -1029,7 +1029,7 @@ void *radix_tree_tag_clear(struct radix_tree_root *root,
> >  {
> >  	struct radix_tree_node *node, *parent;
> >  	unsigned long maxindex;
> > -	int offset;
> > +	int offset = 0;
> >  
> >  	radix_tree_load_root(root, &node, &maxindex);
> >  	if (index > maxindex)
> 
> Are we sure this isn't actually a bug?  What happens if the tree is empty?

If the tree is empty, then node is NULL and we never use offset.
The compiler is too stupid to know this.  This warning is only observed
when building the test suite and not when building the kernel itself.
I'm not sure the patch is worth it, tbh.