Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alexander Lobakin <alexandr.lobakin@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Alexander Lobakin <alexandr.lobakin@intel.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
        linux@armlinux.org.uk, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v3 0/4] net: lan966x: Add xdp support
Date:   Thu, 10 Nov 2022 17:21:48 +0100
Message-Id: <20221110162148.3533816-1-alexandr.lobakin@intel.com>
In-Reply-To: <Y20DT2XTTIlU/wbx@lunn.ch>
References: <20221109204613.3669905-1-horatiu.vultur@microchip.com> <20221110111747.1176760-1-alexandr.lobakin@intel.com> <Y20DT2XTTIlU/wbx@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Precedence: bulk

From: Andrew Lunn <andrew@lunn.ch>
Date: Thu, 10 Nov 2022 14:57:35 +0100

> > Nice stuff! I hear time to time that XDP is for 10G+ NICs only, but
> > I'm not a fan of such, and this series proves once again XDP fits
> > any hardware ^.^
> 
> The Freescale FEC recently gained XDP support. Many variants of it are
> Fast Ethernet only.
> 
> What i found most interesting about that patchset was that the use of
> the page_ppol API made the driver significantly faster for the general
> case as well as XDP.

The driver didn't have any page recycling or page splitting logics,
while Page Pool recycles even pages from skbs if
skb_mark_for_recycle() is used, which is the case here. So it
significantly reduced the number of new page allocations for Rx, if
there still are any at all.
Plus, Page Pool allocates pages by bulks (of 16 IIRC), not one by
one, that reduces CPU overhead as well.

> 
>      Andrew

Thanks,
Olek