Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa8b6690-5560-7feb-7616-db636161e204@linuxfoundation.org>
Date:   Thu, 10 Nov 2022 09:56:21 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] media: vimc: Fix wrong function called when vimc_init()
 fails
Content-Language: en-US
To:     Chen Zhongjin <chenzhongjin@huawei.com>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Cc:     kieran.bingham@ideasonboard.com, mchehab@kernel.org,
        hans.verkuil@cisco.com, helen.koike@collabora.com,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20221110072633.210437-1-chenzhongjin@huawei.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20221110072633.210437-1-chenzhongjin@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/10/22 00:26, Chen Zhongjin wrote:
> In vimc_init(), when platform_driver_register(&vimc_pdrv) fails,
> platform_driver_unregister(&vimc_pdrv) is wrongly called rather than
> platform_device_unregister(&vimc_pdev), which causes kernel warning:
> 
>   Unexpected driver unregister!
>   WARNING: CPU: 1 PID: 14517 at drivers/base/driver.c:270 driver_unregister+0x8f/0xb0
>   RIP: 0010:driver_unregister+0x8f/0xb0
>   Call Trace:
>    <TASK>
>    vimc_init+0x7d/0x1000 [vimc]
>    do_one_initcall+0xd0/0x4e0
>    do_init_module+0x1cf/0x6b0
>    load_module+0x65c2/0x7820
> 
> Fixes: 4a29b7090749 ("[media] vimc: Subdevices as modules")
> Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
> ---
>   drivers/media/test-drivers/vimc/vimc-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c
> index 2ae7a0f11ebf..e82cfa5ffbf4 100644
> --- a/drivers/media/test-drivers/vimc/vimc-core.c
> +++ b/drivers/media/test-drivers/vimc/vimc-core.c
> @@ -433,7 +433,7 @@ static int __init vimc_init(void)
>   	if (ret) {
>   		dev_err(&vimc_pdev.dev,
>   			"platform driver registration failed (err=%d)\n", ret);
> -		platform_driver_unregister(&vimc_pdrv);
> +		platform_device_unregister(&vimc_pdev);
>   		return ret;
>   	}
>   

Good catch. Thanks for fixing it. Now applied for next rc.

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/?h=vimc

thanks,
-- Shuah