Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Wei Yang <richard.weiyang@gmail.com>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] maple_tree: should get pivots boundary by type
Thread-Topic: [PATCH RFC] maple_tree: should get pivots boundary by type
Thread-Index: AQHY9NWT1J4wfyUtEEayLl5nEGbTbK44VUmA
Date:   Thu, 10 Nov 2022 16:14:31 +0000
Message-ID: <20221110161239.crapogyt7owdqd7y@revolver>
References: <20221110072459.23656-1-richard.weiyang@gmail.com>
In-Reply-To: <20221110072459.23656-1-richard.weiyang@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Mnu3oW2hGEhegGJ4GRVtAa+XZknVVxYl50Wi3eMCi3vEmfkMRbSfb/cL84SC?=
 =?us-ascii?Q?gvzcPuH7fh6lXS73fvh0yKITZBMZ8ylHby+xRn34PS0j2zoRcOzYqJSNb8xz?=
 =?us-ascii?Q?9oJf1D7p2ePnY3JhY6s/Ro9hDm8QJy0Dh7qPrCGvBCayzIiSYvzy3s0Gi/F7?=
 =?us-ascii?Q?Kn1BIDxQ0b1f7VZkaKUVnX+njh+jWNjTYhZD2RKXZNAlyZQdrqxoluetv7Lk?=
 =?us-ascii?Q?jQnpnhavO2QeYWekWQwT6eMyIZjwTeHTDIoeWBfdzGPCOglrUJFcp5TvRyEo?=
 =?us-ascii?Q?pbvHN/hwdu+sMgQxhVhPsiU9Ljcu3X/OLQwerx7c3y/l4mxp8AuIGcPF68bL?=
 =?us-ascii?Q?eyHtAqLUsQipaQYIR9a+f2LodfYETkfvi65yywJ2dj8WIYDrdHIea2OTZXIc?=
 =?us-ascii?Q?sLiR0gmbKCcubDgaTSsaP89QNB/wZnUCSsJjVlHlF41Aq9tLNzkdp1RloM42?=
 =?us-ascii?Q?E3rVTp7/sxXc2QHdH5lGYaLymTtHGC4b5sl76auLWO9MbX8xnS6oxltI5fXf?=
 =?us-ascii?Q?R4D+nOIjnRUgM4C+suaKUCB1yQXnKQltk0gZZuISvhn3nNzMbv3ie92BPS/+?=
 =?us-ascii?Q?jj6mekSuV/FzSR0PxjeybfGEemIwbqD1WTNgW6BfuyYdJtnnn+nW1yZzRkRz?=
 =?us-ascii?Q?AdJ0Ra8fGmAZzv8koKe6Kn0jFoVSo9o9HwMmYJDBiyLo2ppE6M2B2JeG9tU3?=
 =?us-ascii?Q?r693dmTKp5jZzJZrqaMKiIebToZP7dONF+SABvvjv9tA8F1FHhUpZDQ8XWmd?=
 =?us-ascii?Q?a0sz3Ugr7lnZV+jiG24VztcoeZU3Kton5oaV4+d97TFUkKXGoSk+9QqO/uQV?=
 =?us-ascii?Q?b9UEl6rEv1Eihbasw9DL0WK5wUB8gcmhPyKY/DzLs4J/0Q0Wg/cwTIu5Uxk3?=
 =?us-ascii?Q?ZazBSK+SbW4zXUDIlHt0mQdSrfC07O+qXf14ZGQ1Y/L8zUz9iKwLLrTr4ZLy?=
 =?us-ascii?Q?Jb8/CxkCv70uETXPznA4d1h/4FIfvnXUDTNe1LJyZzlPFpkLKt4XGA4i/qsI?=
 =?us-ascii?Q?ttq09L/quMHezTSWFralM2yBERmt8m3WKBp+eSpHI6zlsd5WxmyodJfE/wmT?=
 =?us-ascii?Q?eWD89otxqI+yRDhYjCZKGW2c42TCaLHs7Gm0WuoUHwf/c/i6AV6X7IsSIgpp?=
 =?us-ascii?Q?gcUE+UiSInDlDD9TIrLxIsdS14Kz0uINX9RVNLkvxp9iEmf45Gcrnw+uWQCe?=
 =?us-ascii?Q?+x+zl5hX5u8Ilt6qCXeM6bxgWWr1YniyjZ5YHhkcwZHN8+MzfA26vJFawOOU?=
 =?us-ascii?Q?zxHPfcFQX12s7mvZLx5QzrUHf3Jw7axcSliY9icztGV0/NkGnjm4KtV1lYZe?=
 =?us-ascii?Q?hYuV56C2sSPE1p4QTaPEKDZ9VxaEQt92CTlVoQ8jWCkB/qPNuw1s1xYsND0k?=
 =?us-ascii?Q?XEby5srluMYUwM6XBTercgUzb1anvmAr/QGu2U8OEuiiG2TGYqKbxMypj33i?=
 =?us-ascii?Q?gAdEp+6uG8dad83OzsNl9L6qZuV1d1+uGB/Qa2FpSauIKSYtwxIHwxa6UE8B?=
 =?us-ascii?Q?09Haeime0Kfo+jKTzYgIo7hcAIc380HXa3rNpLYtgHxCy647XzpoB5CN+QNW?=
 =?us-ascii?Q?IjijJ7Fbhb9oix1PHVKTM8pkjMe25cX9CyN9RK+Qx6DV2IH7jlU0/LHoDzOv?=
 =?us-ascii?Q?LQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <64A62F2FC8624249A2101EED5FF728EF@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1f7b19e-75a2-43db-2777-08dac336a699
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 16:14:31.6114
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: r6xHFeFnfmMQnWRMKgMF1by2dILl5GuYM/5bvqlp3piy3Z6y9jLr4p78ukSEdrt38I8TMoEBFNuVziFYED3hKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4796
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-10_10,2022-11-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0
 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211100113
X-Proofpoint-GUID: uILxnsrGhej6TToVuRTconkDWWl2MLMe
X-Proofpoint-ORIG-GUID: uILxnsrGhej6TToVuRTconkDWWl2MLMe
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Wei Yang <richard.weiyang@gmail.com> [221110 02:25]:
> If my understanding is correct, we should get pivots boundary by type.
>=20

Thank you, yes - you are correct.  This is a bug, and should have:

Fixes: 54a611b60590 (Maple Tree: add new data structure)

Please fix your commit message and add the fixes line and resend.

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
>=20
> ---
> * kernel build looks good
> ---
>  lib/maple_tree.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 73e2e6434e2f..2123d1930a9b 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -669,12 +669,13 @@ static inline unsigned long mte_pivot(const struct =
maple_enode *mn,
>  				 unsigned char piv)
>  {
>  	struct maple_node *node =3D mte_to_node(mn);
> +	enum maple_type type =3D mte_node_type(mn);
> =20
> -	if (piv >=3D mt_pivots[piv]) {
> +	if (piv >=3D mt_pivots[type]) {
>  		WARN_ON(1);
>  		return 0;
>  	}
> -	switch (mte_node_type(mn)) {
> +	switch (type) {
>  	case maple_arange_64:
>  		return node->ma64.pivot[piv];
>  	case maple_range_64:
> --=20
> 2.33.1
> =