Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 16:39:51 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Ben Dooks <ben.dooks@sifive.com>
Cc:     linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Greentime Hu <greentime.hu@sifive.com>,
        jarkko.nikula@linux.intel.com,
        William Salmon <william.salmon@sifive.com>,
        Jude Onyenegecha <jude.onyenegecha@sifive.com>
Subject: Re: [PATCH v6 07/10] pwm: dwc: make timer clock configurable
Message-ID: <20221110153951.vcxatcfk5pl2vyz5@pengutronix.de>
References: <20221020151610.59443-1-ben.dooks@sifive.com>
 <20221020151610.59443-8-ben.dooks@sifive.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="r6c6hcjkhlfswnpj"
Content-Disposition: inline
In-Reply-To: <20221020151610.59443-8-ben.dooks@sifive.com>
Precedence: bulk


--r6c6hcjkhlfswnpj
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Thu, Oct 20, 2022 at 04:16:07PM +0100, Ben Dooks wrote:
> Add a configurable clock base rate for the pwm as when being built
> for non-PCI the block may be sourced from an internal clock.
>=20
> Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
> ---
> v6:
>  - removed DWC_CLK_PERIOD_NS as it is now not needed
> v4:
>  - moved earlier before the of changes to make the of changes one patch
> v2:
>   - removed the ifdef and merged the other clock patch in here
> ---
>  drivers/pwm/pwm-dwc-pci.c |  1 +
>  drivers/pwm/pwm-dwc.c     | 10 ++++++----
>  drivers/pwm/pwm-dwc.h     |  3 ++-
>  3 files changed, 9 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/pwm/pwm-dwc-pci.c b/drivers/pwm/pwm-dwc-pci.c
> index 2213d0e7f3c8..949423e368f9 100644
> --- a/drivers/pwm/pwm-dwc-pci.c
> +++ b/drivers/pwm/pwm-dwc-pci.c
> @@ -20,6 +20,7 @@
>  #include <linux/pci.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/pwm.h>
> +#include <linux/clk.h>
> =20
>  #include "pwm-dwc.h"
> =20

I assume this is only needed because pwm-dwc.h now uses struct clk.
Maybe just add

	struct clk;

to the pwm-dwc.h instead of this hunk?

> [...]
> diff --git a/drivers/pwm/pwm-dwc.h b/drivers/pwm/pwm-dwc.h
> index 68f98eb76152..dc451cb2eff5 100644
> --- a/drivers/pwm/pwm-dwc.h
> +++ b/drivers/pwm/pwm-dwc.h
> @@ -22,7 +22,6 @@
>  #define DWC_TIMERS_COMP_VERSION	0xac
> =20
>  #define DWC_TIMERS_TOTAL	8
> -#define DWC_CLK_PERIOD_NS	10
> =20
>  /* Timer Control Register */
>  #define DWC_TIM_CTRL_EN		BIT(0)
> @@ -41,6 +40,8 @@ struct dwc_pwm_ctx {
>  struct dwc_pwm {
>  	struct pwm_chip chip;
>  	void __iomem *base;
> +	struct clk *clk;

This is unsed, please add it in the patch that makes use of it.

> +	unsigned int clk_ns;
>  	struct dwc_pwm_ctx ctx[DWC_TIMERS_TOTAL];
>  };
>  #define to_dwc_pwm(p)	(container_of((p), struct dwc_pwm, chip))

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--r6c6hcjkhlfswnpj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmNtG0QACgkQwfwUeK3K
7AnSUQf9Hbf2+S7Vrf9NVbC3OqCWgomiwgcDc7O86nD6efoK7pnup5JbRmIpKdT5
VDbMjK57nsfn+p0zsn5MVu7X6MW1QKi5dU5aEYNVaTpnJT8lFiB/RGrQgaD11TPS
FZy/Hqgk13fAbeYYTy8q+vR5NRzRgFMmZ2W+qVbhY5Dc+jg+m7NolWGgoy9buWMq
ZOsiIo8VV+PkN3+EzjRfm0hhUFwZTBH7UKFrSs36pFReWmeHfM4eqZtsgA/eUDph
pt2H8Yd34PybIJJX+qRKan6g4XxZlSWd2xNwYFwUQ2eUBwMVWXlED1nZCjWgXR0R
zlNDdW3AU0puY7JVpPt7Gk8MqvvZKg==
=2U+q
-----END PGP SIGNATURE-----

--r6c6hcjkhlfswnpj--