Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kumaravel.Thiagarajan@microchip.com>
To:     <gregkh@linuxfoundation.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        <jirislaby@kernel.org>, <andriy.shevchenko@linux.intel.com>,
        <ilpo.jarvinen@linux.intel.com>, <macro@orcam.me.uk>,
        <jay.dolan@accesio.com>, <cang1@live.co.uk>,
        <u.kleine-koenig@pengutronix.de>, <wander@redhat.com>,
        <etremblay@distech-controls.com>, <jk@ozlabs.org>,
        <biju.das.jz@bp.renesas.com>, <geert+renesas@glider.be>,
        <phil.edworthy@renesas.com>, <lukas@wunner.de>,
        <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH v3 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for
 quad-uart support.
Thread-Topic: [PATCH v3 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver
 for quad-uart support.
Thread-Index: AQHY8qbOKjSYZX8pv0a09I/nHE/OKK42gJIAgAHWaXA=
Date:   Thu, 10 Nov 2022 17:18:46 +0000
Message-ID: <BN8PR11MB366816A34B16BE29A5FD7912E9019@BN8PR11MB3668.namprd11.prod.outlook.com>
References: <20221107124517.1364484-1-kumaravel.thiagarajan@microchip.com>
 <20221107124517.1364484-2-kumaravel.thiagarajan@microchip.com>
 <Y2uWftt5b2AWyTtX@kroah.com>
In-Reply-To: <Y2uWftt5b2AWyTtX@kroah.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J4mvkjwaulUrLhnyKu7PW/ep2RrsYXPNGV5UudQwpY28ldse8otgJ2YNHPU1?=
 =?us-ascii?Q?nfRKCyhkBsEAhouyMV4IxpnuAuTyCTCouOrspRZmCDKBaSffPstv9f+o3wOz?=
 =?us-ascii?Q?jguqwHbd0wH9uSUxAXhbhC0C+hjgPOHMDhiYc0ygdKTHJbshZX2PNzRu4qPd?=
 =?us-ascii?Q?hOI6BolH95sanHNxeEoi5F/3jYZbr6oS3Vsi7dfV6F3uGJt17VLMK8kB+U5S?=
 =?us-ascii?Q?Nkp5iJQZtdzpqBUYmoCsBOEKk+ssCgTFdZVCzdqDcukbsQ6t0ZESKkA86f6k?=
 =?us-ascii?Q?3oYqKkHCTwrfKT7YGGR3DW3o6DxzMBRtbcQGYQL0cCpXB0FS2zD8bQ2a/KkO?=
 =?us-ascii?Q?9+kECygrnODShBSfYQojHpwSUuUSv7GX17RtnZJ9ZP6digvigJtl5tM0/80C?=
 =?us-ascii?Q?XxPmOqha3Py2oBF/yJ+SHSliMxvMH7rgMi0S6GSw4IUKoZZgui737bMeMa3w?=
 =?us-ascii?Q?eII9M3lk+ldMjBy497ebwWvKTY3NFFAsXjUv5oRK3+lPqdAO5f3axFXFFGit?=
 =?us-ascii?Q?6ivmrbcPUe5b7VbOiQM8DWL5sDGp/QLWrV9Io3VcUy/Qefh54l7CaDB6dOAV?=
 =?us-ascii?Q?37jNpQEdSZ4i/E3tnzuKg70c07eA9oLJ27oUlpE3kg9jUPWzeSmheVMXoAIG?=
 =?us-ascii?Q?PaQXiy8jb9sHgTShBS61KuVPBMwZRdTs2Q62mv17iX+QJkp7WKVytylGrf2u?=
 =?us-ascii?Q?0XkOvJrnbyqvf0XkYz2tZXyq2+TXVohvZ9J7n7OLscALG/KbSN8cQkmcmA6N?=
 =?us-ascii?Q?rwlAvQHspUTPHTtiJG+w1yCaCSiycbExP454iUEe8tFPlXlW83sCH4pYppr+?=
 =?us-ascii?Q?nBBiWsGlOlVYywpCHaPURFBQNTI9PJm8mR4lMWm1z8EUT7kfYPLWDrd520Ef?=
 =?us-ascii?Q?RzYTKfX8RBk1+eSh8/vGAcLgK1Q03m2sCAMAlAJe2IJCg+aCZKFZBNeNWPdJ?=
 =?us-ascii?Q?AbcSr6WoGG6pqLTtLmddBZMzQXooT7GzTydQ+JE5rar411v+qcttYLFhJV3m?=
 =?us-ascii?Q?NINk4+4Km7reToXP020iarpoi3joMzsPx/CihbmH/fn8UPlyAPB2LOv9ipUx?=
 =?us-ascii?Q?alnKxgAKaajYHaAt6ya3A1ALK2S6ENpH29nP0qHF1hKMRYno4w60QbML98sq?=
 =?us-ascii?Q?gPrJFxG/u7qEQ+JRPNsnBzuMyUOFs7DhXdqcNH7u7Puk8cbM/HNhfWEL5Ny4?=
 =?us-ascii?Q?LV9E9oVR0A7F/Xo0kSDX23i3OGxTgv13DOD9PdmXUuyuO2Ib33IoG0NMrUeg?=
 =?us-ascii?Q?SqeBni70fFwDnC2uLIQ8OaJwRP70U9s6chtFwlTakTAmWcAozjNMQlNz9UCu?=
 =?us-ascii?Q?o0ZsC9gygCjvCgV1OFnquBkNKUeEA2i1WMAj+4fvwpobDtOltn2dhNG20+cA?=
 =?us-ascii?Q?i5e3XM2Tx40K+Qk/ncQxspG7TnNZ9YO7oG3ti7rA2DZI1o/XMR2ZXOGKZwdk?=
 =?us-ascii?Q?jdvCyj7yYnvXrp4r3cY+ozepFe5YbcG5db1AF0VvY0tL1sW7DRRppZqfnMUe?=
 =?us-ascii?Q?yE6V8RCbclvkS6xz+sRIAIdpMSxSfvW6AEP0lm4DPvmNOlLI2/dvMC54FNYv?=
 =?us-ascii?Q?uov1FtlvymelVZYoPSPHr7slzrQ9LyeuA+BVIaxoROVO6UyBcj7CWSKZgdOS?=
 =?us-ascii?Q?xBcmpe0CV8nSCzDnb/32PO4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3668.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9120063b-7269-4108-e4c5-08dac33fa03b
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 17:18:46.4825
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CfY1JaShmXDseUYMYnY7EaLFaxD8a3aOZ4wz3rMSNzc80CDn/fMlv5svJ9aWYwg89G48/HLKB7fv6dK9WgpNPQ9WJUIogSafc0Py4qTdgwlyMS1fPeRHCa/WsBZpHm8j
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5828
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Wednesday, November 9, 2022 5:31 PM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com>
> Subject: Re: [PATCH v3 tty-next 1/3] 8250: microchip: pci1xxxx: Add drive=
r for
> quad-uart support.
> =20
> On Mon, Nov 07, 2022 at 06:15:15PM +0530, Kumaravel Thiagarajan wrote:
> > +++ b/drivers/tty/serial/8250/8250_pcilib.c
> > @@ -0,0 +1,31 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* Microchip pci1xxxx 8250 library. */
>=20
> Better name and a copyright line?
Yes Greg. I think "8250 PCI library" would be the correct name. Is that fin=
e?
Regarding the copyright, we moved the "setup_port" function from 8250_pci.c=
 to this new file.
Can I use the same copyright statement from 8250_pci.c "Copyright (C) 2001 =
Russell King, All Rights Reserved."?

>=20
> > +
> > +#include <linux/pci.h>
> > +#include "8250.h"
> > +
> > +int pci_setup_port(struct pci_dev *dev, struct uart_8250_port *port,
> > +                u8 bar, unsigned int offset, int regshift) {
> > +     if (bar >=3D PCI_STD_NUM_BARS)
> > +             return -EINVAL;
> > +
> > +     if (pci_resource_flags(dev, bar) & IORESOURCE_MEM) {
> > +             if (!pcim_iomap(dev, bar, 0) && !pcim_iomap_table(dev))
> > +                     return -ENOMEM;
> > +
> > +             port->port.iotype =3D UPIO_MEM;
> > +             port->port.iobase =3D 0;
> > +             port->port.mapbase =3D pci_resource_start(dev, bar) + off=
set;
> > +             port->port.membase =3D pcim_iomap_table(dev)[bar] + offse=
t;
> > +             port->port.regshift =3D regshift;
> > +     } else {
> > +             port->port.iotype =3D UPIO_PORT;
> > +             port->port.iobase =3D pci_resource_start(dev, bar) + offs=
et;
> > +             port->port.mapbase =3D 0;
> > +             port->port.membase =3D NULL;
> > +             port->port.regshift =3D 0;
> > +     }
> > +     return 0;
> > +}
> > +EXPORT_SYMBOL_GPL(pci_setup_port);
>=20
> This needs a better name, 8250_pci_setup_port()?  This is not a pci core
> function.
Yes. I will rename as you mentioned.

Thank You.

Regards,
Kumar