Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1003480rwb; Thu, 10 Nov 2022 09:57:22 -0800 (PST) X-Google-Smtp-Source: AMsMyM6u6f7796AQR5kXkjO7sqvltpxYiGS6UKG9F+B0ErmnMc1N2vvCeOkj8gVOCoXGP8tdJ9no X-Received: by 2002:a17:90a:d990:b0:214:2404:19f3 with SMTP id d16-20020a17090ad99000b00214240419f3mr47414576pjv.125.1668103041895; Thu, 10 Nov 2022 09:57:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668103041; cv=none; d=google.com; s=arc-20160816; b=q1RSmpbdaE0dUYngoCXyFlMx/wxjrdX8APW06JeCpUP3DR5+ryB8bhVMEoiKlsakmJ VEVe3dVucknPIojL6FmnIaFtVKR2tF2wn/r640r8rrJE7XWudZplrbT8qxmp/vXjVp31 +YLcvdaiAFxBlzmjppjcr1+SnRn8lDTL39wVmIMVgL8EFL+UkmsTKM2p9NvQ15zeVDmO p2vU2Uy6dp38JyueCvAotzoFtau2+UscAnHvHx79Ut+1NoUzfFIVQK8aEfIvKjEq56Sp sBTuqK+EsvBN71QGXdIixhslyfgAYTAAmXr9SA/x+qGTffjtGDhMbLav+owF+CuEF3C6 jA/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6+p59de6PsfQhghSr17SHi1vccXQnsphuAQf+FEG0HQ=; b=lQa8VTFaQpY2uhUSBDlFf9LB2TnpbjMgac1scQSNMqptfoEPaleFUifyhM7LIHr3bb o6DTEKU7wsjTZMzNONkv3KaFTebgr0TPB6KOX+tBszDwkqQ2+54futhanHEChzXJ8GYR pzRqrEGXgBocvTPLrfTNUj1gWgIhQ2rCdwlkJPSSrl1RdCreCFK/h8v7Ff2nzqk3SU1s CRv3e3hE1/GN/Zvn4dNghFBj3wkg3OhyNXgVzYJ9bSF1O0Pw3RynF/gSw+n2rsZm96W/ BAHpg73uDl66AT1SAxoi6D6ve+3Ct8uPP+3655JO2TRfEml2/9kbiMvkRm+zY8PlPQye sI7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Je1AWEgl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c20-20020a6566d4000000b00473d2c2c082si3866496pgw.361.2022.11.10.09.57.08; Thu, 10 Nov 2022 09:57:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Je1AWEgl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231432AbiKJRSr (ORCPT + 92 others); Thu, 10 Nov 2022 12:18:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231195AbiKJRSi (ORCPT ); Thu, 10 Nov 2022 12:18:38 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B10DFA4 for ; Thu, 10 Nov 2022 09:18:33 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id gw22so2087717pjb.3 for ; Thu, 10 Nov 2022 09:18:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6+p59de6PsfQhghSr17SHi1vccXQnsphuAQf+FEG0HQ=; b=Je1AWEgls8fX5fRsqqjYq3EJyLyKV7MZf9N1T/aVClFk3POIrv7COzBf4FD4SvUbaP LgJaDOWNYXSDnktSJmsWkSVj6P7JqWVj7LF2N+1U14bXHgd3p+dvL13CNSdD893hgjKD KQ+2SoOBhw6bBhFDkRa0HfyH5zVpnvKnr4EztAJZlVvTCUM54LG/KK+sZVgaXBj2wDY7 hFU6/DI/xCNfQGkvqJXN6leNlFpiQFhrZCTkMjHP27GLQ/eNIBn/FlcFC0msGuxVAv2r 1+4J+/xM3iuc4acHtoFrpL+P+y3rKIRpP8/05PVHb79EJCpBdlkVnF7qNHg9yso/U3Ll DFFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6+p59de6PsfQhghSr17SHi1vccXQnsphuAQf+FEG0HQ=; b=RkqnNrGT84oF3rtLtYRd0k3woIOPiigqhVELcNFDzrsp+dJApNUkMBnmfMECoixixE GGN5/G08rWt16e6PfQIbSzsCqQyUCGjQtmDkUVQIYwgUtZqu67gvI0tjgLuaPZnOAD9x wJWNlu6H3G/GcApIDRtf1wxS1q3Mk8QtpVwjQ4uaJzo8XLOPRf2nBof+HckWHLvvtPdk WeNMam7QVMnjSwrM7Jrr0Qyo8BZaAEPUiU/9Kyj5EEIEFvp7zZSAQmvCtkuKJa0O5t8M qdB08nEAiOb70GjoF8tHCXXXdR5qMPd6I7VNoVEUInOp42/EpRuRlXH7D54vsFkFsi9s 3dfA== X-Gm-Message-State: ACrzQf2ciKy2M9zcbR0f8/w9EJhgW8ZomKwBjowH4eecFNv4oJcM4YEd 465hYNep+PbQ0g5y32tC51bCrLrAG9fvQA== X-Received: by 2002:a17:902:e74a:b0:187:2039:5754 with SMTP id p10-20020a170902e74a00b0018720395754mr57814067plf.103.1668100713125; Thu, 10 Nov 2022 09:18:33 -0800 (PST) Received: from localhost (fwdproxy-prn-021.fbsv.net. [2a03:2880:ff:15::face:b00c]) by smtp.gmail.com with ESMTPSA id z22-20020a630a56000000b0043c732e1536sm9427574pgk.45.2022.11.10.09.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 09:18:32 -0800 (PST) From: Nhat Pham To: minchan@kernel.org Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, akpm@linux-foundation.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v3 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Date: Thu, 10 Nov 2022 09:18:31 -0800 Message-Id: <20221110171831.19176-1-nphamcs@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Please put the LRU logic under config ZSMALLOC_LRU since we don't need the > additional logic to others. I think the existing CONFIG_ZPOOL would be a good option for this purpose. It should disable the LRU behavior for non-zswap use case (zram for e.g). The eviction logic is also currently defined under this. What do you think, Minchan?