Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1035497rwb; Thu, 10 Nov 2022 10:18:57 -0800 (PST) X-Google-Smtp-Source: AMsMyM7+7ygu+XIOWvuNxgSZchLWKsIpAKeEBsR0UEtzbC0jniOAY4vKpkJFVyHxF2UhX17D/4aC X-Received: by 2002:a05:6402:22d5:b0:461:f94:913 with SMTP id dm21-20020a05640222d500b004610f940913mr2886981edb.102.1668104337621; Thu, 10 Nov 2022 10:18:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668104337; cv=none; d=google.com; s=arc-20160816; b=0gjnYF5TYkSapH0Qw6lPMNx1XzcGTg71iEfSuuRtmfUAjoZbpuErkZMpkwnFoQkSxI 2unkdwBWGGXxIol3Rjee5zCZgsTBR6DXjQTXBv1wQ27E2sJtRBKZlIKfnzrKau5E1gVv FBd7ND5LhQUW7alLkcXn3VOT1M1zXMKbZoL5GCKtUURF8h4m0ycl2H69oTodoI5kfXjE 5yJeyUsgztunHUZlJijPp39l+3AoeZtz631UvMOcELBZbfVtc+99M8OAjEh7l+ZSFreM CDHxmcDK4RRUTz0Mkg9Y0YJuWdPwLNwibrSoQNM/OiS8GNlco1Y+S0WDIRzEoDnnVmL+ NHGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TAqMJ9XEgcb7EhZe2sWVJH4nswduJ2xyoOUcpLbLbEM=; b=d1g/WcUDyN2v8OT3/fMBzFkrsQrtsLrDEVBlGUV3y3rhmgNRL/MNBJCdN6SVYYpK4o lNHwzgGmZ1imGNWT7IdmzpbXunr0hCOfxNraFCATt3aWocaH/M8NATzXbJEBsYzUrZWF wFefpRizzAqVXX5cugtQGdn+cGIWIYtgpI4Xt5wlnokZg/C/kJsFuVS3Gk5pZHbt4zqK /v/pufUb+QdITi91bcD2IdNGX5u+w0zoXg+W7gJgiAGM2d4hikFQXcG1HXQmh/eQ37WQ y+Peq7LmiazZkJwYl9eeDmQQXBl05JH1gmrXIim9chI+3Qw4wZyY5DzfRfk3/u6xDUdg 1wnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=hfNGu4eX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g6-20020a056402320600b00461701dab0csi204297eda.526.2022.11.10.10.18.34; Thu, 10 Nov 2022 10:18:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=hfNGu4eX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229792AbiKJSIG (ORCPT + 92 others); Thu, 10 Nov 2022 13:08:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231157AbiKJSIE (ORCPT ); Thu, 10 Nov 2022 13:08:04 -0500 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AA0949B7C for ; Thu, 10 Nov 2022 10:08:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TAqMJ9XEgcb7EhZe2sWVJH4nswduJ2xyoOUcpLbLbEM=; b=hfNGu4eXvHj3RG9HNpNohVHc16 ipyrTZ3rsXdUovuTXkVMvNvcA9s8TrtXk46ii1oNq2be7fSpxn6H9eegzIIAWqSVBXTJcK+Ez8+ME pOohQG7JKCGxgTNvUSu6SVJSB8qaAcJEbh+/iu2qYAPFTQHYlwRHmMAHQnvuhFChodjPEahlNbJDM aKBfh5GytMaVXtYrg2V4hwEYK9qeBj8H7Jhh6YIPmYGzxi3ntCfEJmDD/eWv0aNF4pkmwcDlko2Kx 27mtN6UPSwW5ZHDyfQFaxCUgc+ItsGMDVOkBT/pytFNCUiIliVRqVjHseXp0Yyg2bgDiXn6TI70/I VDHKTGcA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1otBxJ-00ALFj-P7; Thu, 10 Nov 2022 18:07:14 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5777E30041D; Thu, 10 Nov 2022 19:07:12 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3CDAE2BB18BCD; Thu, 10 Nov 2022 19:07:12 +0100 (CET) Date: Thu, 10 Nov 2022 19:07:12 +0100 From: Peter Zijlstra To: Ross Philipson Cc: linux-kernel@vger.kernel.org, x86@kernel.org, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com, xen-devel@lists.xenproject.org, jgross@suse.com, boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com Subject: Re: [PATCH v2 2/2] x86: Check return values from early_ioremap calls Message-ID: References: <20221110154521.613472-1-ross.philipson@oracle.com> <20221110154521.613472-3-ross.philipson@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221110154521.613472-3-ross.philipson@oracle.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2022 at 03:45:21PM +0000, Ross Philipson wrote: > On allocation failures, panic() was used since this seemed > to be the action taken on other failures in the modules > touched by this patch. How is the panic() more useful than the obvious NULL deref that also splats?