Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1055342rwb; Thu, 10 Nov 2022 10:34:06 -0800 (PST) X-Google-Smtp-Source: AMsMyM5qTM9Dju5Mqy1wwh49isHLMSNGKxHe8Sm5dAxpEIa4ffBtqP6Pu4+r0f9KPqXMW58hnU3W X-Received: by 2002:a17:90a:1283:b0:20d:48bc:6666 with SMTP id g3-20020a17090a128300b0020d48bc6666mr1672389pja.98.1668105246291; Thu, 10 Nov 2022 10:34:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668105246; cv=none; d=google.com; s=arc-20160816; b=oUVrM7tCop74UPhhrZi7BuvhLviVBTDMvKpEMVmtzw+9CWmJce+O4Nb9wm03mszy6J 0FpZA+LgzL/0Ev7W+Pkine2npE5zsr6c/bIkgKEGUmvdMZZ1BJG93bEwr2r1qKbp45V9 FHeQxq+mEcIKsDBpMizjErbMwLmsmWvxsf1RaXuZDL4DzQkK1XIO1+iF1ivPpAIdd+cB B22ZB00HUm0FVBfFuaVNtrWb3Z9uPVZi31nGkjrHHXEr8jV7fm8wcK/QrANk7F7lI4R9 s3MzZQkWDua8ON4GnMrhICSeIs3w3lEB8FO77sWpQKDRJyN3rmxNc21A8Gq6LUHpF8iP G/9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:to:from:dkim-signature; bh=WqXDyseogDTLpFF0eQHv9pOMaqFVWgVUbVjrKvFMsy0=; b=ts4tXRI4vkXGPZWanR+a2dE+PknOBf0LpRi6oOrf3iLh+MsqYXqbwurWb7aV/R7bzp ChIMhRxBgB2/aRUv7V6JKhs5UiSSCiZE4q7CfvHVyDImubVudDjw/6u/deIBLjcmPjgF d92yhssgoVyA/CKwdptcbuNUuLGQ1s+scX6RzzRHcqgMe3Ef6WYcVJlK1Fvh+uKQrh2R +/d3a8xN8TcQGZQWSRNXlycRLbikfGIMRt7bQsAgjoG91JdvYoIXjBcjguAUNL3ODwI9 d9scFQWbwJjfAQh7ncaf+FvFcGVRqXUSSxSLOrK4hr/G4JquI3sBCnD/w0I14wL8v2QL NoMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=5ycQ1sac; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k63-20020a638442000000b00463f080c19esi20398877pgd.559.2022.11.10.10.33.53; Thu, 10 Nov 2022 10:34:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=5ycQ1sac; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231707AbiKJSQN (ORCPT + 92 others); Thu, 10 Nov 2022 13:16:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbiKJSQM (ORCPT ); Thu, 10 Nov 2022 13:16:12 -0500 Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3D841A806 for ; Thu, 10 Nov 2022 10:16:10 -0800 (PST) Received: by mail-il1-x12b.google.com with SMTP id 7so1393036ilg.11 for ; Thu, 10 Nov 2022 10:16:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:to:from:from:to:cc:subject:date:message-id :reply-to; bh=WqXDyseogDTLpFF0eQHv9pOMaqFVWgVUbVjrKvFMsy0=; b=5ycQ1sacv7ViSywRAaNstwvoGkdomC5JIRvZIkKbU9rck8mmh3GieD2uo/M4nG261Z vLI8kNdoBruGSniE5hS6Q2HKx3gNULA/IsVx6DseuhOXHBdqxyIItoOhVs5Fr348bUEg uPvZAAqzh98Y092uZs+LfzrG2YoRfvEKEmUpoDiBy98sgY8S0SMBL9GTDx0R3jyBmFYf iHbhizld9PESZraYOU9OPtQ1YZrwwoUMNT1Y10lzqX3Tb2yiZ7I+R7t8wsXwjTiHjyTJ dKvwF5X/gV53zx4r+2UBR9mS2SkTxFvo7EXjoTESAJuKLva+E7r+DAdGcCCZ7WrOSmdX L76g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WqXDyseogDTLpFF0eQHv9pOMaqFVWgVUbVjrKvFMsy0=; b=Wayo/tXbRagqXfoGZjkgsqb7hrF452XYNU447RyRHeNJlk4L5hqE/27QlBwMcUiW3z NK3HFJh39iucmrVhEWxbR1XtD7kAfwo0ytb/BMHgoMcjMjwl7IdL13yHWxyr74e3MKG8 ND3WzgMLsYuW1HsDOzO1oWfzORFlLezw3LlAFvxY3PRNBn4F9t4Qrwf+owQK0RWQbGMO JqCQZ08lbggtB8q7YFmaLvgVN4PgjMkZBVPd78VFnjPJS0HAkEp38Qn5pshdo+bG3A+6 ETFr78i0blS1PgHJYTAWdEZvsj/pWQfp/YeshFRPsaLm2NtODIsiBDdPVbz9piqAtNHb b7eA== X-Gm-Message-State: ACrzQf258p7HTNKiAOhztnA0cM5iRDy4OwyrwuK8JL8P3DEBVztVrX2k OEt3idV42YwrTv9DxfAvBSBcG4WOgkTrsA== X-Received: by 2002:a92:d84a:0:b0:300:bee0:1468 with SMTP id h10-20020a92d84a000000b00300bee01468mr3307519ilq.129.1668104170287; Thu, 10 Nov 2022 10:16:10 -0800 (PST) Received: from [127.0.0.1] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id s2-20020a02b142000000b00363cce75bffsm31120jah.151.2022.11.10.10.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 10:16:09 -0800 (PST) From: Jens Axboe To: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, Lin Ma , asml.silence@gmail.com In-Reply-To: <20221110060313.16303-1-linma@zju.edu.cn> References: <20221110060313.16303-1-linma@zju.edu.cn> Subject: Re: [PATCH v1] io_uring: remove outdated comments of caching Message-Id: <166810416930.167294.6129265009506240894.b4-ty@kernel.dk> Date: Thu, 10 Nov 2022 11:16:09 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.11.0-dev-d9ed3 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Nov 2022 14:03:13 +0800, Lin Ma wrote: > Previous commit 13a99017ff19 ("io_uring: remove events caching > atavisms") entirely removes the events caching optimization introduced > by commit 81459350d581 ("io_uring: cache req->apoll->events in > req->cflags"). Hence the related comment should also be removed to avoid > misunderstanding. > > > [...] Applied, thanks! [1/1] io_uring: remove outdated comments of caching commit: ff611c848d0fd408ce90ef93a09ea0a70400cd86 Best regards, -- Jens Axboe