Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Thu, 10 Nov 2022 08:28:03 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Chengming Zhou <zhouchengming@bytedance.com>,
        linux-kernel@vger.kernel.org,
        syzbot+2fdf66e68f5f882c1074@syzkaller.appspotmail.com
Subject: Re: [PATCH] fs/kernfs: Fix lockdep warning in kernfs_active()
Message-ID: <Y21Csx4q5ZpGZP64@slm.duckdns.org>
References: <0000000000002473fd05eca7540a@google.com>
 <20221109120415.55759-1-zhouchengming@bytedance.com>
 <Y208VBO9cZ5VL88m@kroah.com>
 <Y20+1otw2iwldKTl@slm.duckdns.org>
 <Y21BB4Mh4aQjf71c@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y21BB4Mh4aQjf71c@kroah.com>
Precedence: bulk

On Thu, Nov 10, 2022 at 07:20:55PM +0100, Greg KH wrote:
> On Thu, Nov 10, 2022 at 08:11:34AM -1000, Tejun Heo wrote:
> > On Thu, Nov 10, 2022 at 07:00:52PM +0100, Greg KH wrote:
> > > Shouldn't:
> > > 	https://lore.kernel.org/r/Y0SwqBsZ9BMmZv6x@slm.duckdns.org fix this
> > > instead?
> > 
> > The difference is around whether the id based lookup can see hidden files or
> > not. But yeah, it makes more sense to hide it.
> 
> So your patch should not have been applied to my tree?  And I should
> take this one instead?

Oh, sorry. The patch you took is the better one and I was confused when I
was looking at this patch. No action necessary. It was just me being
confused.

Thanks.

-- 
tejun