Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1060962rwb; Thu, 10 Nov 2022 10:38:40 -0800 (PST) X-Google-Smtp-Source: AMsMyM5Ojg3c2YUpDigIIFxUEhkYpLzgs+ZsszO4quGCRc67TFmFh8yuz5AUAlM95C6bWlaMKWWS X-Received: by 2002:a17:903:41cf:b0:186:ac4b:21b7 with SMTP id u15-20020a17090341cf00b00186ac4b21b7mr65812803ple.123.1668105520314; Thu, 10 Nov 2022 10:38:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668105520; cv=none; d=google.com; s=arc-20160816; b=pc3Ghl9UY5o4kD+inLEH2bVXI6tCz2WQ+X3fuJM1wjSCFVHb3kOyvaQ6Hrz8HblkOk JtZMZoFytuEn6IFdd557J/wIMOAPo1kaY3fMaRGN/DncjGacIskidozhkUtznor+FaRU pdbVQ6qbD7BcMuqEBlhvItJgC3y0aP+IpoaVBxO+ROBeYo3OXic++/3inz2VH963OqI5 VOCdtvvAjrDVi56BpX7WvhiP9NKo7Ylbrb+rTLoqyfsvztDA3yRyf5JakUOnPhueVe1L xTkVGt5X8I7HRMTk0Hl9C+zeo51WCF7KZLf7LeMjmYwo1sQJwt0/9UzL0GSjOptzCOo8 7sog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=M0RiB8d+fpY1ouOpxQyRSIcqjZm02SVYen8rLgZHWvU=; b=Q9tJzvS3mvw/xOPXVyEraTmYtIp1qOs7nSQ6+xuiCch8I9oTe5J5SlLpPhQZo69zgX W2WoMjUkoYZTXlp6Li28S+9LXovx4MPv076wdElnCuWSSObpbZq3upAFULYihSc1CxLZ livgOwr2dIuP/45UpjG7CphKPALtuuKeYpxEae5ev03lT/msklLf8WL5DBuKk1isC/k6 YaLm3nOYhSKQ6UpM0zOPMPeHqkdurtoEMtdBwNtFIeAFxFZ48zZ1kg7tjsq4RyvFgmKX Q7ZXPU3WBBaXh9OYts0raMv8AOOLAp+hEdLwpSnZrIvkqnfjnauAwlqfBfy2uHeKbFoK 7syg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ST1siAQh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o2-20020a637e42000000b00473f7fbd7cfsi421831pgn.375.2022.11.10.10.38.26; Thu, 10 Nov 2022 10:38:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ST1siAQh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231661AbiKJSWD (ORCPT + 93 others); Thu, 10 Nov 2022 13:22:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232048AbiKJSVo (ORCPT ); Thu, 10 Nov 2022 13:21:44 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38C344D5CB for ; Thu, 10 Nov 2022 10:20:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C7D6B61DDD for ; Thu, 10 Nov 2022 18:20:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8164C433D7; Thu, 10 Nov 2022 18:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1668104458; bh=wi/r7g7EKYmj4XnMc8eJm6KXDr90O2MOBuJsu80cQn8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ST1siAQh+LwA7aBwQGJZCYbqQig+upyNgLyEFIIKUnU3bm+FEuo36UtsF5+MnB1As rB6SXkKJ6TOY9QeRI5gHyCFxl3OlOGW8FqU+BclHVImCAh7QlN6JtPaox54gYjrv0B KfT4oci4lrDsEBtz9wLkS611YVaJ4kcbeu8I4GWc= Date: Thu, 10 Nov 2022 19:20:55 +0100 From: Greg KH To: Tejun Heo Cc: Chengming Zhou , linux-kernel@vger.kernel.org, syzbot+2fdf66e68f5f882c1074@syzkaller.appspotmail.com Subject: Re: [PATCH] fs/kernfs: Fix lockdep warning in kernfs_active() Message-ID: References: <0000000000002473fd05eca7540a@google.com> <20221109120415.55759-1-zhouchengming@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2022 at 08:11:34AM -1000, Tejun Heo wrote: > On Thu, Nov 10, 2022 at 07:00:52PM +0100, Greg KH wrote: > > Shouldn't: > > https://lore.kernel.org/r/Y0SwqBsZ9BMmZv6x@slm.duckdns.org fix this > > instead? > > The difference is around whether the id based lookup can see hidden files or > not. But yeah, it makes more sense to hide it. So your patch should not have been applied to my tree? And I should take this one instead? confused, greg k-h