Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <Y2xyHM1fcCkh9AKU@xpf.sh.intel.com>
In-Reply-To: <Y2xyHM1fcCkh9AKU@xpf.sh.intel.com>
From:   Joanne Koong <joannelkoong@gmail.com>
Date:   Thu, 10 Nov 2022 10:37:36 -0800
Message-ID: <CAJnrk1ZvWfSAsYx-cErCqjQbciKCiAKss6Kvcm_4vXP5bzFh2g@mail.gmail.com>
Subject: Re: [Syzkaller] There is inet_csk_get_port WARNING in v6.1-rc4 kernel
To:     Pengfei Xu <pengfei.xu@intel.com>
Cc:     linux-kernel@vger.kernel.org, heng.su@intel.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Nov 9, 2022 at 7:38 PM Pengfei Xu <pengfei.xu@intel.com> wrote:
>
> Hi Joanne Koong and net developer,
>
> Greeting!
>
> Soft remind: "WARNING inet_csk_get_port" is found in v6.1-rc4 kernel.
>
> And first bad commit is: 28044fc1d4953b07acec0da4d2fc4784c57ea6fb
> "net: Add a bhash2 table hashed by port and address"
>
> Reproduce code from syzkaller, kconfig and bisect info are in attached.
> Full information is in the link:
> https://github.com/xupengfe/syzkaller_logs/tree/main/221108_215733_inet_csk_get_port
>
> Thanks!
> BR.

Thanks for your email. This has the same root cause (handling the
error case when connect() fails) as the issue discussed in this thread
https://lore.kernel.org/netdev/20221029001249.86337-1-kuniyu@amazon.com/.
After consensus is reached in this thread, I'll submit a follow-up
fix; I'm hoping to submit it by the end of next week at the latest.