Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221110190612.1341469-1-detlev.casanova@collabora.com>
In-Reply-To: <20221110190612.1341469-1-detlev.casanova@collabora.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 10 Nov 2022 16:08:44 -0300
Message-ID: <CAOMZO5BiFdVJ5tipBKfo6ZGSeGw4m4raoV_x1y1ffOJgBGg2Xw@mail.gmail.com>
Subject: Re: [PATCH] ASoC: sgtl5000: Reset the CHIP_CLK_CTRL reg on remove
To:     Detlev Casanova <detlev.casanova@collabora.com>
Cc:     linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        "moderated list:NXP SGTL5000 DRIVER" <alsa-devel@alsa-project.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 10, 2022 at 4:06 PM Detlev Casanova
<detlev.casanova@collabora.com> wrote:
>
> Since commit bf2aebccddef ("ASoC: sgtl5000: Fix noise on shutdown/remove"),
> the device power control registers are reset when the driver is
> removed/shutdown.
>
> This is an issue when the device is configured to use the PLL clock. The
> device will stop responding if it is still configured to use the PLL
> clock but the PLL clock is powered down.
>
> When rebooting linux, the probe function will show:
> sgtl5000 0-000a: Error reading chip id -11
>
> Make sure that the CHIP_CLK_CTRL is reset to its default value before
> powering down the device.
>
> Fixes: bf2aebccddef ("ASoC: sgtl5000: Fix noise on shutdown/remove")
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>