Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 11:08:32 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        willy@infradead.org, almasrymina@google.com, linmiaohe@huawei.com,
        minhquangbui99@gmail.com, aneesh.kumar@linux.ibm.com
Subject: Re: [PATCH v2 3/9] mm/hugetlb_cgroup: convert set_hugetlb_cgroup*()
 to folios
Message-ID: <Y21MMJML0CrWmivY@monkey>
References: <20221101223059.460937-1-sidhartha.kumar@oracle.com>
 <20221101223059.460937-4-sidhartha.kumar@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221101223059.460937-4-sidhartha.kumar@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3qQ+VVhXK4ssnO15iLyKbf6l+b7pHYtFRxQqmYIxiEFCHaD2p2R5ks+TDgFw?=
 =?us-ascii?Q?2vLh+wW+oxSKmR/PmskJQWMDSKEbVccHyGsd44R6Sx0ze5ocrETPo2oIQ4FU?=
 =?us-ascii?Q?7g1qPouNBeDbw16I/vqhmqofq9oHPJwx3PWs8rQDs8Edco2WOQ8eg5zK8IJu?=
 =?us-ascii?Q?RSYQu7JsbGjknZvKxqo4qi0FQ5cPOgEqgKSvmy4IR8dixxsBis8lLSyHAcXQ?=
 =?us-ascii?Q?YSporq+FqcZYq9+kGVWDKALJzFYmQo2BJhwQxTa6vJoiat4fPTAY/Dx19N+r?=
 =?us-ascii?Q?k2GYmxhuD7IpqF6FS1hviV66f+rC3IYYVxbYZ/1BViDh/8SjjIEVdXHyOPQS?=
 =?us-ascii?Q?W43/hKJHrWC9zYEd0tZcQGRghzadFNmY+gNrWUYgJinrsmOaWq8S05VapRHX?=
 =?us-ascii?Q?w0gbvgRHW5uBF8J7+ICFTO+gAcI06civP718ULA1RQNM4J/4sDcJpmGNTF1k?=
 =?us-ascii?Q?Wy40mW7Ogflk1LdaJ404khKdA/wGxy8XWLDW4pCtUleE0tjCnma2RHWRpLOv?=
 =?us-ascii?Q?OVkEOPZgsHEDJvfU3ZT5aXdl7HhsbmUTJDmeHCggMKUOyUUXh9248SHjv7zL?=
 =?us-ascii?Q?gvHWEYCwA7PnLB0l79H9bNwbo8a0otGMrGwHkQ82C4ksb+l7fxeFe5oninPb?=
 =?us-ascii?Q?ps8qQv+DMKFPr1Lkk6cEmhNl3uzU0Knn4ZyPuTsb14n9mywKm5I0ktUwP6PH?=
 =?us-ascii?Q?+MuLgzaa9H89a1uHIssgiSye3LwmCfJ1p5qF4gerC6Awp9t9ZF51M4XAHs0n?=
 =?us-ascii?Q?TRgftB38HKS/JocLpcVMa43vT3b0Fh4KTXimezyWZGvSQn47O287jeEuPlDb?=
 =?us-ascii?Q?Q/APsUyH+oKqL24B88Ar43XPmTiHRfOpJXMmmjq1b1b7nKS+3kN8vDgO7/2E?=
 =?us-ascii?Q?lQwZ1lYu+U9TEJuSg4PM42eprD0h2CBNndTTVbMWg8xA8G4r5ylAPngKJhNX?=
 =?us-ascii?Q?PY1qkham8sPD1jKk0OBVpO6Bd+v+9z9+eK8+YrHaz8QVvL18px29vbF0F+XD?=
 =?us-ascii?Q?Wmgaf1X/dfCXXWf3oyn6DMMEUj1x8Wx6Eu553iX11J6bRMoEbdM20SlGoN+X?=
 =?us-ascii?Q?kmIxvyU2iCMhkPoZzVHwZLM6OiP0juTwyBxXOlPLfme0teKPSoZPXDOWcBRt?=
 =?us-ascii?Q?lBrbZ8GN0IUMc6v9JYwxEBk/MxuCt2vv0oDcUs/zMNMxXADwdUZ8Tlfy1A7Y?=
 =?us-ascii?Q?g2kPa2JdkdkKopDOQp+jjYwaZnJcXhWNA11bG3cmQBIIMOsIMKGj2eEXT2FG?=
 =?us-ascii?Q?hfbecMZ2MXE4uGiLc1qQTgOpVA5RDbwUJJXv1rcECRmPDUOy3g/+U/BEngX1?=
 =?us-ascii?Q?7vFr81vLCmY1DbS+mAz92nHR05t7qhz4MybcOP3QR13Ltb85MIBc0uOdXArH?=
 =?us-ascii?Q?bW0l7qs/8WcJIvnVaPqYYCQfpc7eg5MP6wRPxsEnGOapY/wZnVdaXRtL3soO?=
 =?us-ascii?Q?M8lH7jgtO25Q5u4forCIubL9NasDOLkBSM6rEDe+icA+jDlwPpXJWcGmB732?=
 =?us-ascii?Q?g5Ns3isSS7CldqYkNLteD00Vq5ZBvLbqg3Q3lOZC31gO4vGCurJ5DUDuvFPp?=
 =?us-ascii?Q?oRB7UZZbrwPqAtFOVA210YGZXpLkKBJOeSpp3afnSuhwWpmUZBPRBuJ0MlBx?=
 =?us-ascii?Q?Bg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38c31222-2a26-44f5-7532-08dac34ef758
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 19:08:36.7241
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b1OiKRYxld/i1N1rC7fzy+HDAR9SAC1ccPgzkM2tCk+ZbLn7qFqjrfWqxmPkhTTRp3HWzhhTpUJBrf8UDoPmtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5122
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-10_12,2022-11-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 malwarescore=0 mlxlogscore=974 mlxscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211100134
X-Proofpoint-ORIG-GUID: c2HUCCxB5AM0aYHZvNgieTc35MhL17M3
X-Proofpoint-GUID: c2HUCCxB5AM0aYHZvNgieTc35MhL17M3
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/01/22 15:30, Sidhartha Kumar wrote:
> Allows __prep_new_huge_page() to operate on a folio by converting
> set_hugetlb_cgroup*() to take in a folio.
> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
>  include/linux/hugetlb_cgroup.h | 12 ++++++------
>  mm/hugetlb.c                   | 33 +++++++++++++++++++--------------
>  mm/hugetlb_cgroup.c            | 11 ++++++-----
>  3 files changed, 31 insertions(+), 25 deletions(-)

Muchun had the same comment I had in v1 about the need for a routine to
set the destructor of a folio.  Since this will be added in a subsequent
series,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz