Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cd5aabe0-94a6-3832-9e3e-b308b134d7e8@oracle.com>
Date:   Thu, 10 Nov 2022 14:31:45 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH v2 2/2] x86: Check return values from early_ioremap calls
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, hpa@zytor.com, luto@amacapital.net,
        dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com,
        trenchboot-devel@googlegroups.com, jailhouse-dev@googlegroups.com,
        jan.kiszka@siemens.com, xen-devel@lists.xenproject.org,
        jgross@suse.com, boris.ostrovsky@oracle.com,
        andrew.cooper3@citrix.com
References: <20221110154521.613472-1-ross.philipson@oracle.com>
 <20221110154521.613472-3-ross.philipson@oracle.com>
 <Y2090DOT3q5CX9kV@hirez.programming.kicks-ass.net>
From:   Ross Philipson <ross.philipson@oracle.com>
In-Reply-To: <Y2090DOT3q5CX9kV@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjlCeE5SaGZNMjRTVjIwTi9WNTR3REdnZjN3UXdTWVdMWWh5SmkrSWN6Sndv?=
 =?utf-8?B?Q1k5ajc5MWdkd0lMR1BpdDBQZUdCZ1NPOWlPVkNUSEhiaFpZbG96NnQ4MEFa?=
 =?utf-8?B?TnlxTzUvMGptbFZUaEY1YWR0amxKK2dpQ2ZHSXR1QVNBV3ZXakh3ZGsrVnZs?=
 =?utf-8?B?SzBTcTh1YmxKU0RiZFZIUE5IRkczYWIyT010SW1SV2tMb1BzWDVkcG14MW9n?=
 =?utf-8?B?cXFqNnJqd1JNbGVCM0d6Q1VOM1U5UHZkNW9La1FsNGJkd2dFeDcvTHl0WERx?=
 =?utf-8?B?V202Yk96aXh2RlIrSmNRWGdIckNvZzA2bTcrRFRmRHE1YUZ0WWxiWERiOWcx?=
 =?utf-8?B?MHQ2WHViNm5CQm9TclRyekxvRDhXcEpZa2RYY2dTUllvSlJhR0szNzNtblBV?=
 =?utf-8?B?N0dUenkxZE5vMVdoR1R4OUFJWC9iN1FNQ1dKeFphTzFic1J5bDViM1dLWTg0?=
 =?utf-8?B?TUlvRTFpMEl4ZERXeXZNSENFNWxNZHk0UGZPektUWFpqdHcyWU5INUR6WmNR?=
 =?utf-8?B?d2Z2cm5xUlpkVks0QVlwd0xibnM3TnBRMmtKUU1NZmdxZ3plUVYzV0QvcFFH?=
 =?utf-8?B?azlnTHZKZEFHT0lKZEd2M3JEU3N2emVtWWxLSkJTL3NyaVh2OGlyNFgrWWpr?=
 =?utf-8?B?ZzJKVDVxWnJCZFBxeWZ0ZWNnUHNQOE1VRXNRQVNEbitiUkVEVCtLeERUSlll?=
 =?utf-8?B?c3kxaW1YZlRYaytCZ1hFTVp6M0NQeEZCYmhXU1ZUYmpzMXZRck1OSWloWThy?=
 =?utf-8?B?UmtVeHBySldBMVBGaU5vcFhYSUpRcEhoWlJtNGNnWnA4Q0pKdWx0TGxlODVl?=
 =?utf-8?B?OThVQk1HbUtmZkxkUko5blVINUpUTWdJOUo2TngwRks0MFJZVkhBVzIraHdX?=
 =?utf-8?B?Ung5MllselJWSloyWDZoNXRIVEtMcExIN0RqeDNJT2NTREVNc0Zhbit1aDlw?=
 =?utf-8?B?Nlh2SU1RekNpcThuaUdISEQ0ZnNJS21jeHpZY3ZBbVBneGhuZDFaNjRtdzJq?=
 =?utf-8?B?T05WTTZod2FzaXpJaXQ4RUNDeCtCUXpJQTk4WklOWjNaWWlpUnM1MUVPeGFh?=
 =?utf-8?B?WHVhMmZPU2lKcVNMNE9kU0hoMWpDZUFMcHV3cUpOazF2aDZ2VWVkSkNjYmVJ?=
 =?utf-8?B?aU52VjBTV01wMDZiVFl4K1RCWmMwaXhKRkgwSDJoTFNNcFpwRGtQYm5odmVr?=
 =?utf-8?B?cEE0UFR2UnV1cExUZXB2UXEvanQwQjd4b1VYZW02czVJTmg4V3VuaUtPOVBu?=
 =?utf-8?B?NkZHN0t2ajZqeUFvRmVrcHE1SnNuSnNBUjZhMWl5UCt5eGoybVpXbzZSaURV?=
 =?utf-8?B?RjV4eWJnR1ljcGxjQkRTZlR0OUZER0ljTlY4cVdJYU5KdFJ6TStNd1duS1Av?=
 =?utf-8?B?b2lZNndCWGxXTG84YXIvQXZXUVh1dTNuaUlvTmQvVTdyRHZIMUJwUXJFMk1C?=
 =?utf-8?B?djI3c3I3Q0dOekw0QlUzMHFRdzhsZmZBUzBuSFErN1lvT1RtbTJGcExIdUVJ?=
 =?utf-8?B?WUhNSkJtZ3lFMWFLZndYWTloWHYzM2JhOVFsUzZiUGlmNWc5ZThNU2NFWGU0?=
 =?utf-8?B?OEo0aFZaN3ZMS1A3L0NZaGpyMVNiVVROYm9xNkUwRmRJRnF4WHhiT20wdHZp?=
 =?utf-8?B?RzhkbTJMU29QYVoreDBJeVR6SG4rVzVzT283RkQ0T1lEaDdJeUsxTnpzRzkx?=
 =?utf-8?B?dDZCZ1AzbUNFU1Q2UEU1Z085YW1ZdlBjeFpmakxkYkl3d1pGdXFVQUxHbGl5?=
 =?utf-8?B?T1MvanJMamxTK3BaNTJFNjBCR0Q0U2hSN1hvaHoyU1NzTnp2MnYwQlFHNS9n?=
 =?utf-8?B?eTRWMFlwZzhUUTc0VzdyTG84TnVPRnF2STdQSnZZOU0wMHNoSnVBMUJyYk40?=
 =?utf-8?B?RXI3OHgvRk5mWFVlQnJLdFRJaGhuNDJyV0hRK0pEUUwxbi8yejBRWVIrR3lR?=
 =?utf-8?B?TUcxaUJOS00rTzFCZ1R4dklkRUljSW95TWNndkc2bHQ0ZytidEVxS2dCWnlL?=
 =?utf-8?B?aDNNNHQzMmsvZnZjTFp2eW01OHRmbjNOVWE1ZlVNNkc5WWRxTncrYUFRZ3JZ?=
 =?utf-8?B?NHluMkJHRkd0b3hnYlBnWWppZkNRMlEvemYvdHVPTVg1UGw3ZzkzblF5ZkFx?=
 =?utf-8?B?Z1IrbTdEWWZuT3lrS01WZTN3M2d0alppT0QyN3FtbDBTdTQ4d25uOWNSbkJ0?=
 =?utf-8?Q?sGc8SnPV9ZLQKnsyvSCZ28c=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d6d970b-9383-4304-e85e-08dac35236fb
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 19:31:50.5590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5x7oUzUPXZDE31Mh13cpEQhRs1g8s/RRpns2BgkacxnbhFb2S6X3xvgBt756NwgIOn1WIG70lGkqVL76a00Z9tJV9iiFNryA4/ruHTje9cE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4472
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-10_12,2022-11-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 malwarescore=0
 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211100136
X-Proofpoint-ORIG-GUID: eRrxUR0XbnRdPgqB_luf7_7bo16mrCLW
X-Proofpoint-GUID: eRrxUR0XbnRdPgqB_luf7_7bo16mrCLW
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/10/22 13:07, Peter Zijlstra wrote:
> On Thu, Nov 10, 2022 at 03:45:21PM +0000, Ross Philipson wrote:
>> On allocation failures, panic() was used since this seemed
>> to be the action taken on other failures in the modules
>> touched by this patch.
> 
> How is the panic() more useful than the obvious NULL deref that also
> splats?
> 

My answer here is basically the same as the answer in the reply to Dave 
Hansen I sent a moment ago. I think one of the primary motivation was to 
make things consistent.

Thanks
Ross