Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 21:12:35 +0100 (CET)
From:   Richard Weinberger <richard@nod.at>
To:     Daniel Golle <daniel@makrotopia.org>
Cc:     Jens Axboe <axboe@kernel.dk>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Matthew Wilcox <willy@infradead.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Ming Lei <ming.lei@redhat.com>,
        linux-block <linux-block@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        linux-efi <linux-efi@vger.kernel.org>
Message-ID: <871124728.219224.1668111155161.JavaMail.zimbra@nod.at>
In-Reply-To: <Y21ZXRKJF3hZg8wk@makrotopia.org>
References: <Y2rgbfpYfpbLKHaf@makrotopia.org> <1691046252.219046.1668109493753.JavaMail.zimbra@nod.at> <Y21ZXRKJF3hZg8wk@makrotopia.org>
Subject: Re: [PATCH v4 4/5] mtd_blkdevs: add option to enable scanning for
 partitions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: mtd_blkdevs: add option to enable scanning for partitions
Thread-Index: JXERWtnlcCWgydDBA6DChmOXmJ0hxw==
Precedence: bulk

----- Ursprüngliche Mail -----
> On Thu, Nov 10, 2022 at 08:44:53PM +0100, Richard Weinberger wrote:
>> ----- Ursprüngliche Mail -----
>> > Von: "Daniel Golle" <daniel@makrotopia.org>
>> > +
>> > +		if (!IS_ENABLED(CONFIG_MTD_BLOCK_PARTITIONS) || mtd_type_is_nand(new->mtd))
>> > +			gd->flags |= GENHD_FL_NO_PART;
>> 
>> I know that NAND should not get used with mtdblock because lack of wearleveling
>> and
>> in general too many writes. But what exactly is the rationale to deny part
>> scanning for NAND?
> 
> As UBI should be used on NAND, partition scanning should be enabled for
> ubiblock devices to have uImage.FIT filesystem subimages mapped by the
> partition parser.
> 
> If not skipping partition scanning on NAND-backed mtdblock devices the
> scanning itself will already trigger multiple warnings which now happen
> every time when a NAND-backed mtdblock device is being opened since
> commit 96a3295c ("mtdblock: warn if opened on NAND").

I see, you want to promote UBI. Makes sense.
In case you do a v5 series, please add a comment to the code.

Thanks,
//richard