Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Tian, Kevin" <kevin.tian@intel.com>
Subject: RE: [RESEND PATCH 2/6] x86/traps: add a system interrupt table for
 system interrupt dispatch
Thread-Topic: [RESEND PATCH 2/6] x86/traps: add a system interrupt table for
 system interrupt dispatch
Thread-Index: AQHY9M85Yu9uY6afW02HaiePlaJ2sq432uWAgAC2DaA=
Date:   Thu, 10 Nov 2022 19:55:22 +0000
Message-ID: <BN6PR1101MB21619E2092AFF048422C6311A8019@BN6PR1101MB2161.namprd11.prod.outlook.com>
References: <20221110061545.1531-1-xin3.li@intel.com>
 <20221110061545.1531-3-xin3.li@intel.com>
 <Y2y8obdYDXo9vlH/@hirez.programming.kicks-ass.net>
In-Reply-To: <Y2y8obdYDXo9vlH/@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.500.17
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C+6WVSatpfChnMP0kJYVM8lQFjrXzYIHppdISL8dkyTxfTsPt/dveBzbWBzl?=
 =?us-ascii?Q?nIOg3uHNJgRNw358FeesfqlazkSEyGjnTRJIVz542IGQEcmDsj7P+0NVUqDr?=
 =?us-ascii?Q?nK021BGLqW1SMqvycokYVibbKvZMWCsBTccpYekvb/KXNCNlWa6OpbN5Yva3?=
 =?us-ascii?Q?VpJb6VVbY5tG6ERxA1UnbOMPPRu7I35ppdUe9Y0W2wqiC2AQr+t8OzX2J4CL?=
 =?us-ascii?Q?purWK2bCXLgBttjeRY8oMJ22/klcfEYPjyjcNuguUKeslVOweKegT/WJF9NC?=
 =?us-ascii?Q?3TUR+mFZPNhT00GKAxRPS7TwoORH/QYPUGDouCelhtuqbs9NlHNoetU0vjvU?=
 =?us-ascii?Q?E7/LsWz82UFzafOolNLz0STDhqVKm6xp1JfJFnqy60a6ih0XRbW9iyyLUQGK?=
 =?us-ascii?Q?WnOui7dtBzZLsZOeE5oHdtlicsX0KWNj8kHWGR6MvFQccAnJWBq6s+4EvQ31?=
 =?us-ascii?Q?nKZP31/nTRKaOp9p2+PDa8Zk/QQ8v+CLPPGeSJJxU2pZZ2YnOZW9Ye8c0p+C?=
 =?us-ascii?Q?mhxq1RYv/VWHf1VndyUA3DtuZ3AupAKeLdVFa7b6y6Zo2S2PHbmcH6mTT9bk?=
 =?us-ascii?Q?n1V/g1fdlC462JlbKEedRiLPh5lSG2ZUTqp+3BlrcEzke50MC4DT6HW1urHI?=
 =?us-ascii?Q?2Gb7EGjJC+CqKcCgo7Kb7LqGmeRSoYAg2IqDq9GvWNz6jch1VjbZ56I34k5l?=
 =?us-ascii?Q?DZu9ig2xpAg0+zQhelfklatG0f8ifqsPFSP+Dtq3tjid4ucixIlxL3ywdJvQ?=
 =?us-ascii?Q?I73CMFzgXQbVCWXWO52UG1ddSrIgGxQJ384/+9qB+z8aFzQUdrDdrJ6dolv6?=
 =?us-ascii?Q?pNXtM5vWLqvl2tl0PRWREnDOFPzv9yGgQTSVF2DiGHklAhqm5zH58GRSI+o0?=
 =?us-ascii?Q?F1x2ilerLeIpJpOf1UPc8lZL511RiVlG2d1WSBCoMqzqifcRsZ6N2UvG6tzr?=
 =?us-ascii?Q?4laehYST50fXPDGhhFPt/YGEnUyVE1D7g9V08ywNPAlvFkOdU2cTN4l5ebWS?=
 =?us-ascii?Q?rNa8aVDz5euQQzkZ6VJ0/rmMW+ztj1kihgzJd0OWxFwGN2vc1ALsnD6setPG?=
 =?us-ascii?Q?8jJEKvqkQwLGrrqRNIysa+NAQ0IbHY8RiwZhe6fhQRcyvBc7m60CRBuA6Jqu?=
 =?us-ascii?Q?3pEwBG1/amu0JiQzolTX7bs2wsuPojBfNPDGt0IbGK5Vsdm+TydyO8SqoHrd?=
 =?us-ascii?Q?qnlIszgsPp9kgM7xpJbd/EcgILq4J02oMLOzskuIMKUKBSGTiO4VMvibkczl?=
 =?us-ascii?Q?Q2AI/JDA6RRUd2RwC6FktkGrELRvGOY49AfDvQl5SiKxzZ6dsaLZhxwO3+5O?=
 =?us-ascii?Q?kPw1UBAMX9LavWOOI/YBB3y7GNQ1HDwCKq3npjcvSmmjtxQ+PDilIbMigNAc?=
 =?us-ascii?Q?Ag2myoADLChWpJPLoY/zfJckbuDsnaCXGFsdSUBuwSn1yWDk6L9VpGbk6r/1?=
 =?us-ascii?Q?s9K3Qtw4bOBOfcXvc6DAF0VnKcKdkqHIa96dmRqLwimS2r8+LVBzLl3fVw/s?=
 =?us-ascii?Q?FgRwBSzVjdXkszFqJ1TIgRihG4bIsCrxZKd5HdKWMHeSZYShg2kRLKSJcR73?=
 =?us-ascii?Q?V2t5d+fQlWQup/O1xtU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2161.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35660864-6927-4a76-b1a9-08dac35580a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 19:55:22.4234
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hVjM4OzgFg1C/JiK1pwSfyPI4SRa2p7LxfeN02Dxms85hJkgBelw5oCLQCUacSFV0Nw9HPgsRpB0IpwZp4G9kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4599
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> > Signed-off-by: Xin Li <xin3.li@intel.com>
>=20
> This is not a valid SOB, it would suggest hpa is the author, but he's not=
 in in
> From.

HPA wrote the initial dispatch code for FRED, and I worked with him to
refactor it for KVM/VMX NMI/IRQ dispatch.  So use SOB from both.  No?

> > diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index
> > 178015a820f0..95dd917ef9ad 100644
> > --- a/arch/x86/kernel/traps.c
> > +++ b/arch/x86/kernel/traps.c
> > @@ -1444,6 +1444,61 @@ DEFINE_IDTENTRY_SW(iret_error)  }  #endif
> >
> > +#define SYSV(x,y) [(x) - FIRST_SYSTEM_VECTOR] =3D
> > +(system_interrupt_handler)y
> > +
> > +#pragma GCC diagnostic push
> > +#pragma GCC diagnostic ignored "-Wcast-function-type"
>=20
> How does this not break CFI ?

I wasn't aware of it, will check.