Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Andreas Bergmeier <abergmeier@gmx.net>
To:     lains@riseup.net, jikos@kernel.org, benjamin.tissoires@redhat.com
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] HID: Print specific timeout error in probe
Date:   Thu, 10 Nov 2022 21:41:31 +0100
Message-Id: <20221110204131.1354704-1-abergmeier@gmx.net>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:i2UKcw+gaCs=;t78I8V9fmboyWMGDlx9vsU+K31a
 S3M9Be8Yb+2TdSOcSBWfn8v5+6diXT9gU2NmKOqmv9aV9op7n7TGur/6PR/ocfaAQtL0WOsbJ
 NYy+0O0okyAOVpluXRr04584Lm4Y1KT8u71x5bdEZqPiguAk/MEOcMvNHT4AsvdRwMbtX4qH7
 lWZ6wvOAJPmwaTKtNpauM/zkIpHXz08bbR/ZsA95UjjMCUWH4/Izrs3ocX47s3/q9s3Uj8uKR
 zlkCamP6rwTJUKAhnM5NX1nYj4NhpWIE0HyDx14dq97sH1RNUlnqxrMHK6cBg4fZsI/KaURhF
 TGmhtJTFx6FJFQX6vEyhpL1ZYXqLmOV0YajtAcOyYbI4mm1F9Yox9PNsIeADHIOWw5+iSlNFc
 LEkGuBKoYxy8LYhGjg6uTrdejXp8w6kerfSuwndVWYQ43ZFHjn0mTJfyHoM4X4J+xgPPpkxUG
 Ewey20U81ci4CXeU1l5yolTMN4FBDf+JjbNU4/IIGw90ElhrIoMeVVMh+Ygqz8VYIGcbt5nm+
 6TOMvH3WXQQfxRtojXGfRJosTTqfYYH1bcXTHs2xAcyhqiYOGAOWg+AOxWmhVZVutzN1JwIVb
 zrGcfWVGuABwkjD9oJfPR8gBWQ4ocmuJ6xjvHv8ZSC4coLPQLuEG5Cqeb7kJ4xpDGel+iUFuA
 UihUAMxrFoV55PG+cNwA0Babfl38TaXXSexwDC6p7kVMQ/Yag3rr+yLBePM9SP9393f/cdgJt
 kAgLNP+ErqymNvDuIWNjMCnLvZMGfQwm874vGpw55HuuEMkftqQru/c8qGv04pHQbEfeEn1wI
 cCbPe6MX4uOEBpArA82HNRIBmAg0JKuwpRJ47hJcJjZq8fPJ7nJOPmlTBCs0ZUu55Jx7PeQNf
 ugsTfK8LQXgEuXva4t9CKfeQLq93yeQcvQvRcNDAc+04yFAGFYdwrHT0KVqHHOoIO4yICm9Gf
 rYlhQg==
Precedence: bulk

When -ETIMEOUT gets reported ensure that the error message mentiones
timeout.

Signed-off-by: Andreas Bergmeier <abergmeier@gmx.net>
=2D--
 drivers/hid/hid-logitech-hidpp.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-h=
idpp.c
index 20ae7f73ef08..a0c148a8df6c 100644
=2D-- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -4438,12 +4438,16 @@ static int hidpp_probe(struct hid_device *hdev, co=
nst struct hid_device_id *id)
 	if (hidpp->quirks & HIDPP_QUIRK_UNIFYING)
 		hidpp_unifying_init(hidpp);

-	connected =3D hidpp_root_get_protocol_version(hidpp) =3D=3D 0;
+	ret =3D hidpp_root_get_protocol_version(hidpp);
+	connected =3D ret =3D=3D 0;
 	atomic_set(&hidpp->connected, connected);
 	if (!(hidpp->quirks & HIDPP_QUIRK_UNIFYING)) {
 		if (!connected) {
+			if (ret =3D=3D -ETIMEDOUT)
+				hid_err(hdev, "Device connection timed out");
+			else
+				hid_err(hdev, "Device not connected");
 			ret =3D -ENODEV;
-			hid_err(hdev, "Device not connected");
 			goto hid_hw_init_fail;
 		}

=2D-
2.34.1