Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76bae3bb-3cb5-dd9c-a1b0-bbe61721abbe@amd.com>
Date:   Thu, 10 Nov 2022 15:42:21 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: nbio_v7_4: Add pointer check
Content-Language: en-US
To:     Denis Arefev <arefev@swemel.ru>,
        Alex Deucher <alexander.deucher@amd.com>
Cc:     avid Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        Daniel Vetter <daniel@ffwll.ch>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
References: <20221110122848.20207-1-arefev@swemel.ru>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20221110122848.20207-1-arefev@swemel.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlNFSTN6azlxb2EwcnRvTnB3K0hTSS8xN0EwZmpURnVyeXNhVmhlaEQwdHFR?=
 =?utf-8?B?emlPeEs4aEc0M1N6UTR6QUovaXduQjRnK3BuTjZlSUZrV3JmQzVEbGZTWFhS?=
 =?utf-8?B?T3lIL3RCZEpObWhDMDdOcXd0VUgwMUdhUU8xZy8yRWJ6NVlXRDNPZlE2UHJl?=
 =?utf-8?B?L2hQVlNwKzdLTG1sNEUwTHdMbFJKT3cvWkhGbUMvSysvVDBoWU9CR2pGNlBm?=
 =?utf-8?B?VTRIdnhtQXE2L1hZMWhaMU0xb1EwUnoxdFNBRGVFbTdENjJENG01em8zUTB1?=
 =?utf-8?B?dTBnaE9wNjJWUVNrQXZBeElIQ0lFR1NzallvMzdlMXA1TVB0TE9MclpDVC82?=
 =?utf-8?B?UmtHaUszQjFhRlZ4MVdQeEZ4RElPUnFFR3RmY1dmcEdCNjFBZHpLbnFyQ1FS?=
 =?utf-8?B?VWZ3VXhpYmtjOW1TU3A5TTJDQUNBWHRNbU1RU3hNZWJqMHROaUZxck94U2Vm?=
 =?utf-8?B?Slp3c1hzT2JBVlVFY1RVWmlxN0RjcWVFSi9HdnZZK1JzdENDZ2pPemZlWVU0?=
 =?utf-8?B?NHhYc3dKSllSU2RCY0pvRnBlTEdqc1EvejRVbmxLTjl2dDRwOHV5TkhrUUJW?=
 =?utf-8?B?MlhZWlpSc1lHazlwT1pQM0ZQSzFDUHM2cFRWUjU4UXFMckZrY09LdzVjNkd3?=
 =?utf-8?B?bU9YYWZBRHZSc1g1ZHViQVhXdDFYS3pNbVZpYVkzSnNEVGhsREN4SWFRSm1E?=
 =?utf-8?B?QmQ0dDRrT3pITzV2Z1B6TnBVeTNhb1JvL09EY3gzRXpleHpKK01yd01saWwv?=
 =?utf-8?B?cDBXUDJ5U1pEQ0sreHJJTWpsY0Izc2pNc3V5SWFsUC82dEYzalpWdFlZMnVa?=
 =?utf-8?B?enRlWTg3VDJTVCs3VGlEKzZXcTh0ZUNqSlFFT2d0b0xNQXNlRnd0MExJOFFO?=
 =?utf-8?B?T0JBcm13cGNRMWFydWFEdU5zNGsrWCszUlBCOGFRY2E2QWg0eURUWmJkeVkr?=
 =?utf-8?B?RWs3RGwzTWVrZ0hPbjJOaEQ4U2xNQmdVcGsrU09Ec3FvekV3MGRmaEM3VDVu?=
 =?utf-8?B?WVRFbEpNNHBkZXVSbVNEK3J1MExmcVNvQTBmcFMxamhDVEVla1VKTW9wZlNS?=
 =?utf-8?B?cmlsY01JdHlFYlpNY0Q1clNpODg2cVlpdWhFWVFQdUVucFBXS1c5d0tra3I1?=
 =?utf-8?B?ZFRvcHhUZ2Q0bnY2ODg0OERMSkllK1lwTWYyTlF5MVRFRS9kb3M5eERKTW9C?=
 =?utf-8?B?YlpoNjVHTzc4cXpqNnZDUHhlQkI3T3A5TVVLUWVtMTY5aGM3VlVTNkFJaGl0?=
 =?utf-8?B?ZS8ycnFUL0d1a0pmWTl5YjA1c3lNVy9XMjJvcVl2U3d4S2RTd01oemV1a1hu?=
 =?utf-8?B?RGdTVzhMTWpGRGNEVkNNRWhqUnlFdXBVUWZmNWJ1NzhKYzR5a0JZM3o5ZTFz?=
 =?utf-8?B?MHBlNnowaWVHbHUzRjB1Q3pmZlVSWjFwa2pPekZpZ1JIdVBLZG9HMTJFWGxX?=
 =?utf-8?B?R1V3T0h6dUZZY2ViTWM1RG8wSmRmQUFtSm11RTM5aXlDNGVxcnc4aWVTLzJK?=
 =?utf-8?B?aVZlU21ldjVOL012YkMzbGU0clhTTnBpR3RzNTNoWFdoN3FTUUw5SlZBT0Zl?=
 =?utf-8?B?Q3NCUkRrMll2QTJaR0lkeEVxcHZuM2ZSTzJyd1c1MHRoeStzQUxuMnhka0Yy?=
 =?utf-8?B?Y00zVUlGaGE1TytKN2pNSzFoOXQzaHVTbUxQSXlzWFFldWo1QTFCMTVqWDRP?=
 =?utf-8?B?QmFoTkdiSjljaHc1dzVEb0JhcDVBcE51NHdidnc2U09mZG1NckFSLzYxdWlV?=
 =?utf-8?B?amhLdGZlaE55Mm1tMndhVDZYZmxQbFNQLzIyVU9EUkxqcmVHcGQvYVJlQXY2?=
 =?utf-8?B?dDczVlU4cUtoSTJPQjIyaFQ1RHEyOGJqcU44czN3Y2svYWFKaFliMzVUM1A2?=
 =?utf-8?B?TDU3VVJjWTdiL1BPdTVEN2V3Sy9jZjlCUWZ6UDYyMlZnK1pxSzczNWNOWjFu?=
 =?utf-8?B?ZmllbGIwSVVoQ0h0UUdZWkNKVFFraEsyaHBSV090WFNWUGVwVUJqeGpuc2hJ?=
 =?utf-8?B?eW8xdlhCb0QvalBUZ01SMGN4a2JVc043dlVvQzlhNnl5anNlbng3ZWRsMG1n?=
 =?utf-8?B?NEVQd1Z0a1Zka29VWTNkWTJURk9kR1NWRkVqcC9qZndmYXpYU1p5V3Fhalc0?=
 =?utf-8?Q?dtZMO+2qMREXfdIe49PlOaIjI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d3e61ab-fb29-47c5-df0d-08dac364742f
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 21:42:24.2911
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gA9OAr8ccaahLa2W5l5bVDJ819TykspIDaEFH3cltYLHoO15raGkeRsCTJhWdPt0kf+tHneK2w4VTVM6rw/a9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6864
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/10/2022 06:28, Denis Arefev wrote:
> Return value of a function 'amdgpu_ras_find_obj' is dereferenced at nbio_v7_4.c:325 without checking for null

This line is too long, you should be wrapping lines at 75 characters.
Could you run your patch through checkpatch?

> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Denis Arefev <arefev@swemel.ru>

Probably should include this tag:

Fixes: 28f87950d935e ("drm/amdgpu: clear ras controller status registers 
when interrupt occurs")

> ---
>   drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> index eadc9526d33f..0f2ac99de864 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> @@ -304,6 +304,9 @@ static void nbio_v7_4_handle_ras_controller_intr_no_bifring(struct amdgpu_device
>   	struct ras_err_data err_data = {0, 0, 0, NULL};
>   	struct amdgpu_ras *ras = amdgpu_ras_get_context(adev);
>   
> +	if (!obj)
> +	  return;
>   

Whitespace seems inconsistent here.

>   	bif_doorbell_intr_cntl = RREG32_SOC15(NBIO, 0, mmBIF_DOORBELL_INT_CNTL);
>   	if (REG_GET_FIELD(bif_doorbell_intr_cntl,
>   		BIF_DOORBELL_INT_CNTL, RAS_CNTLR_INTERRUPT_STATUS)) {