Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7d4b5f20-68c2-5464-aeb9-a3afaf52b827@intel.com>
Date:   Thu, 10 Nov 2022 13:58:39 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 00/14] IFS multi test image support and misc changes
Content-Language: en-US
To:     Hans de Goede <hdegoede@redhat.com>, Borislav Petkov <bp@alien8.de>
CC:     <markgross@kernel.org>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>, <sohil.mehta@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com> <Y2zLYDmO1fkOmFgw@zn.tnic>
 <c4b0cd93-767c-a778-6a38-0e4d981506d3@redhat.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <c4b0cd93-767c-a778-6a38-0e4d981506d3@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHNzNlF2aUJxWjZoU2ptTGVkMGtXTVplNi9ndHZJNytkdlF2Unh1Vm0ybGVM?=
 =?utf-8?B?L3pOalQ2ZWpQVFU1WVQvZFNUMEpENXRHdUxOcHB4VkwvWkZNam9WQ3ZpcWMw?=
 =?utf-8?B?cWtPanNZS2ZUbWpOYytyNmFlRXhrRXQxSGpIRUgxcDdHdUxiM3A5VUVrREtX?=
 =?utf-8?B?YS9ycGF0bXgvYkNBblYxUFF0czZyWExKY3M2OEYxd013YUNFelFLMEhTcmVn?=
 =?utf-8?B?M3J0Qk9uK2d5NW1kUzdhbnFTYmtFSmdDV1hmdnBmSG5HUmRVUjloMHdJd004?=
 =?utf-8?B?ZlhqMjF0dnNVR1ZQcHhLeUlIblY0aUtwU1pNakNhZEVDc0FjbVMzQmJqSG5O?=
 =?utf-8?B?THR1TEcxUzhNaWlLeFV4dDZsbXcrbGY5RGFhejJFdGJxdnZJakNXZ05TVUVL?=
 =?utf-8?B?TG9ZRzIzcGFFNzFQaGpFTEMxaWdpZGJoS1lDbzJETnlsNjQ5RzBvRjRzQ25X?=
 =?utf-8?B?OUVXL3RNd3IrQ3hFNXBYOSsxNjEzQzFmaExuYnVpV0NzZ0dzK2VaTG9ZMTFX?=
 =?utf-8?B?WlpQZUQ1aUg5RG9RcXRiTzRRTWc0SWtvVkc2M0pqMGtFQ0g0RnZIaXRtMGQx?=
 =?utf-8?B?Sld0M29NUllsNFRad1dPOXliWUdIWWVvdG1jL2ZaTWtRbmloZUJRLzNZNG9P?=
 =?utf-8?B?dXZxaFNDZlE2NWU3a21lMTFhY0RTMEpQcFhQNVpMelZ0RktYMnNIUVNNWTRy?=
 =?utf-8?B?UTZuV1JRYXQvOWFrUk1SOXkwcC9neEppRDJlMDF4a1kxRnp5Wmhjdnk4YXRn?=
 =?utf-8?B?cGI3R3NvenR3bWo0d0pkaFFkWFhKWit6WVc3NFVhUUVPaXI5S1ZxK2NzenRt?=
 =?utf-8?B?Qmh6dGluYTRPOS9CK1NxYUxMUElteGpQRFQ1TkowZlA4Y3JOaWNyTlo2VCtm?=
 =?utf-8?B?Mk1wdUoxTXJ4N0t6cFZzQlMwSlA1b2dzeGRuVDZYd0xtV25mZ09lK1V2L3Vx?=
 =?utf-8?B?VW05R0Y1bXJwRURuQnUyc1ErTXUzbFZTMXUzdGoxQVg2Z05LenhxRWp4ajJj?=
 =?utf-8?B?RktRVG9YSjhQM0hxd0xQUkFDcUY0bHg4b29BUlc3OURHdHdJc1h5ZTlUckdw?=
 =?utf-8?B?RFVpTkp0cDlEcW40dmpxQ0Vmc3ByUlpsSTYrdTFwcjdaNWdobUtVRVkxdmNl?=
 =?utf-8?B?OTEzaDdVRUhRUTZHbUNDU0VyOEM5Y0J3bXk4SmFuMUd4VjhFRjVMRGUvKzdZ?=
 =?utf-8?B?VUFiQ0tQTHFvdFk5NnVxWmdKUGlrM2ExYk0zNzVQb29vUVpSc0F0bUp1UERh?=
 =?utf-8?B?UVVuTWtmbTBlRFdZYmVuZlRidCtBb2dMS3cyQ2lNY0hEUDJRYk04QS81Y1Q1?=
 =?utf-8?B?Yy9nZ0JPS2lqTURsTXFKdWl1RlFJNDhNSUh1TkxQSkNuVWhkMEFkc1FLZWNV?=
 =?utf-8?B?REFqdWc4bUJ6azRUK2FpVzR0aGxFMDdXTmZPQlBIQ1F4eG1Ub1V0SVZVUW9Z?=
 =?utf-8?B?T044ZjI3TkV6NDFvK1NzUWJ1cm1KTzBHTmtacW5wTzhCcHFIekJ5MFhvM0dM?=
 =?utf-8?B?cFEvY1FFQ3pNRytySG90Y0NoVkpPL2d4N2lzaFBBdnpCUlpEc0xBVXo0ZXU2?=
 =?utf-8?B?Uzh5NWVRTCsxd0t5MDRrMkxweDBnNkpnYkNSb2pYZzFreVlEYkV3L3JlaGZt?=
 =?utf-8?B?Slp6V25qKysxTWFXRW9JTXJSWkFJdGJmZk1nWTdOQU5mUHUwQzdEeFNhME1u?=
 =?utf-8?B?Wmpqd0VUWkZQdk41Q1dJNXVPUjhiYmhEaXlKNnpPN0tlRExsUVJJOTBaYklK?=
 =?utf-8?B?Snp0Z09wMUtHQUxUZFZFQlVDUEcrSjEyK3RJWHlsQUFpYTBTQ2llVmswVXY5?=
 =?utf-8?B?ajJQNTNvZ1VaT3kwNnFyS2xOR1JaUzZ3bFMxbHMxL21sc2paRnVPQzgxenF4?=
 =?utf-8?B?ZDNHTEZFWnZjN3ppVGYyYmUzMzgxelhIYmpoa2tSS290dnlWeFVFTml1WXFI?=
 =?utf-8?B?RTg2bVlhZ3R0SW1UanpGZUIwWVllOW0yY2plQmIrWitjbVVJWHV3ZUdlVVh4?=
 =?utf-8?B?V2V5MW00cFc0akRqbkxoRnJBWUFoV0dYT0NSSU9rTjFKbzdJNUZ4eXQ0Zms4?=
 =?utf-8?B?V0dZSFRvNUdSRU5GUHFzL1kvZml6bW54dkVwZWdtYTh4NnRMZnhKd29MRDhF?=
 =?utf-8?B?SlMrTG5lYWJ3R1UyNDVoM0lkaktPTW5jc2NmeU52ZEgrTE02aGlCSmQrUGVh?=
 =?utf-8?B?WGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 632fdf98-4ef6-42bc-4f5c-08dac366bb50
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 21:58:42.4748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BI01whFZX9qLWqaaO1gfDP53QX1iov5aZb2lZCbcbgkyoib2wHfKikoxOzd+fGW9ZogHXvFqpV0h9luTkWOUyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5616
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/10/2022 1:37 PM, Hans de Goede wrote:
> Hi Boris,
> 
> On 11/10/22 10:59, Borislav Petkov wrote:
>> On Mon, Nov 07, 2022 at 02:53:09PM -0800, Jithu Joseph wrote:
>>> Changes in v2
>>>  - Rebased ontop of v6.1-rc4
>>>  Boris
>>>    - Moved exported functions (microcode_sanity_check(),
>>>       find_matching_signature ) from microcode/intel.c to cpu/intel.c 
>>>       (patch4,6)
>>>    - Removed microcode metadata specific code changes to
>>>       microcode_sanity_check() (patch6)
>>>    - Moved find_meta_data() from common to IFS driver (Patch 8)
>>
>> What's the upstreaming plan here - I'm assuming I should take the
>> microcode patches through the tip tree?
>>
>> Or should I take the whole thing through tip so that there's no
>> confusion and having to sync and share branches between trees?
> 
> I have just reviewed all the platform/x86/intel/ifs changes
> and they all look good to me.
> 

Hans, Thanks for reviewing.

Boris,  I have fixes from Sohil's comments (mainly  for patch 06/14). Let me know
if you have any other issues that need touching up in x86 parts (04 - 07).

I will post a cleaned-up series next week.

Jithu