Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1303120rwb; Thu, 10 Nov 2022 14:15:43 -0800 (PST) X-Google-Smtp-Source: AMsMyM411NVX3ctg78sPJnQjUAB1FR0fuknY//mmUmOAwAWgXgAWE75hnq66mhBJnIokp9kmUiKq X-Received: by 2002:a17:906:dfd6:b0:7ad:8bd5:b7df with SMTP id jt22-20020a170906dfd600b007ad8bd5b7dfmr3920484ejc.57.1668118542981; Thu, 10 Nov 2022 14:15:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668118542; cv=none; d=google.com; s=arc-20160816; b=aOZSDV7PvkQtvvEN4P4FEl0XspPWIk8407s5/mn1lDGt81vPbdFVXYJ/Ye+o/CVT72 c6lLpG8QTMmsYvEXoU9NnRYnG85SdgrVhaxFLW7vafcwcK7vmiEOgj8EMZ4M20zrLSFI nnS9Rt7pnccSYrhBxaxw1Fc+NFEGltCPoCCYsSeHvOHkiUUbolZ8PFbucKFsBFQLiLxC RLY4PyFmynTvat8x0oDCTXz/f1kH60o1AMI4tXWvI+EixaXFH0QvjIYCuP5MZXUCofl4 VqRkOzMTMtAy9DXF9jYKqTi0yjB4KMuklWS3Oi4+8SIby89UqnMrFddOao0OhNaQS/Er kv5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=pWnWQpgCfyLL75UcCxaWOvo2eGDLJFTWzPdbidxkk6s=; b=mXEalRyGl4/R+Lyz+Zr5pMtWHpHsCvDBkj0Jgtg561Zn5foKKL2IqbjnReAPwCT5B7 Z17eCcvPEvbBPHdzt2ejnLKuFDaVv/q1AXxWCDybge/MswOrSCzpMa9U6wFhhhmnUwSv FbrXurrHtMUas2FZAiQwwcx0xMk/XbTbJjwZv9GDQrgiBkRRY42IdcZGitmD66RvdKl1 TjAwy13UWKsvPpxZWbWvYHESUGUBH3FM6cVEr8ruXc6YKJr5sFjgabxfoWprOMJtA6i0 xm4O6e53So6Jmse7ioeWWDSD1DT3cC/p2bmQeE8QBcd1hpEV2IhFyKnBWzVawto+FzRZ noSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Ltn4DQYp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm4-20020a170907948400b007835897050esi487676ejc.404.2022.11.10.14.15.18; Thu, 10 Nov 2022 14:15:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Ltn4DQYp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231420AbiKJWCU (ORCPT + 92 others); Thu, 10 Nov 2022 17:02:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230043AbiKJWCT (ORCPT ); Thu, 10 Nov 2022 17:02:19 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7805450B2 for ; Thu, 10 Nov 2022 14:02:18 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id 4so2734989pli.0 for ; Thu, 10 Nov 2022 14:02:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=pWnWQpgCfyLL75UcCxaWOvo2eGDLJFTWzPdbidxkk6s=; b=Ltn4DQYpxD8XRKnD+VE6SLO/x9sbFrvqKDGRNohcbAqRd3n+H06MRZOjVftUKeR/Th YERJkafcKVparUQev2meHFZEw2s+2eS2yZshuVO4r1WBXX4GVE1ykgmueOlBZVWuX6OF 7QIYmCJMDoVsJTSph19rT+K2RP1uTIKG/TGwQFIuMAbN66yCEgNrwawbsCBn6JI3uRRn 3SJI9EqjqG/5XjL/o6BYZUjvOEi5YJH9IGP0ZC7SfuO1alCvDaoIVHl0tQv8NgA+8X7W 03xkVR4yZ8fWj68bun6lqkiq9D7DEqclcYK6WKXQIJCUW+e1S9ihr1Zx1Wl1S6Rwx7lF TxJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pWnWQpgCfyLL75UcCxaWOvo2eGDLJFTWzPdbidxkk6s=; b=4jexPlXgPIpq6fdkAUkP7znKACx/phtt9iRfl0uwpmLQm5dL4AKKg+ZFXstwQlOOvy Za/7qn9QhFrY5OmGiubF3k8uEUCseJkjJafFoYjB40pbrVchZgYP7yZkk62K8uB1ATiY 76CKp6V+BVvZ9zBCkxyl29MqAqQPEbkdzlSUZjeh3qk9n5gytyXbVsVIl3UoF61I2Z27 UcBZQNnYfd5rnncDElnC6ujXcLuxeD6IAOjgpqVPs15D1fNcAcyC1XkNIVSPMOapRqnM 1OGVbmljLrrYk35gT1pHcWP7y2gZ03EbTR2VzotxIf96t6e4Fww/8NdMz7mcsVxAYZGH cDcA== X-Gm-Message-State: ACrzQf3PePtKC9/2GUWCFaQf8XWLtGpsIkmkrVIIcPrbinnOYN/6tgCe 5SqKnntfSBh+EYkg27O5S/M= X-Received: by 2002:a17:90a:de0f:b0:216:92a9:fca4 with SMTP id m15-20020a17090ade0f00b0021692a9fca4mr1983176pjv.245.1668117738387; Thu, 10 Nov 2022 14:02:18 -0800 (PST) Received: from google.com ([2620:15c:211:201:8c0b:3260:c81c:119d]) by smtp.gmail.com with ESMTPSA id i188-20020a6254c5000000b0056e0ff577edsm143183pfb.43.2022.11.10.14.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 14:02:17 -0800 (PST) Sender: Minchan Kim Date: Thu, 10 Nov 2022 14:02:16 -0800 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , Nitin Gupta , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv4 3/9] zsmalloc: move away from page order defines Message-ID: References: <20221031054108.541190-1-senozhatsky@chromium.org> <20221031054108.541190-4-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221031054108.541190-4-senozhatsky@chromium.org> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 31, 2022 at 02:41:02PM +0900, Sergey Senozhatsky wrote: > There is no reason for us to require pages per-zspage to be a > power of two. Rename macros and use plain limit numbers there > instead of 2 ^ N values. This will let us to have more tunable > limits. > > Signed-off-by: Sergey Senozhatsky Looks good to me.