Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Alexander Lobakin <alexandr.lobakin@intel.com>
CC:     Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: RE: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool
 statistics
Thread-Topic: [EXT] Re: [PATCH v2 RESEND 1/1] net: fec: add xdp and page pool
 statistics
Thread-Index: AQHY8+NzKrQRZ3k0YEy+QDrsvHgkC644DoaAgAAaV3CAADZxgIAAUdXA
Date:   Thu, 10 Nov 2022 21:40:21 +0000
Message-ID: <PAXPR04MB9185CDDD50250DFE5E492C7189019@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20221109023147.242904-1-shenwei.wang@nxp.com>
 <4349bc93a5f2130a95305287141fde369245f921.camel@redhat.com>
 <PAXPR04MB91853A6A1DDDBB06F33C975E89019@PAXPR04MB9185.eurprd04.prod.outlook.com>
 <20221110164321.3534977-1-alexandr.lobakin@intel.com>
In-Reply-To: <20221110164321.3534977-1-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jiy813wX+WJUWibeu2g9e57iq6rvG2JGICwlQedo6FlTnu3JrRllrMIdSdxr?=
 =?us-ascii?Q?6ysHFCzUO80rNonIcV/tbIok3c7M9vKGoZ0eG3YJeTGSczFdsBO0fRu+rC3l?=
 =?us-ascii?Q?EhmJ3fyT/K5aZARkVle1uRfRr3Iga/45h7UjIXPR/wFn3I1OHmR5xzT4CT7D?=
 =?us-ascii?Q?zWcvlzOvbduSA0PF1K5nzvRMK8OqUfRWQozC1X7nWTfd+wPI0pNKOPWzqZ64?=
 =?us-ascii?Q?Bwa5fyXQF65HvSCmDwyouM4iXxMMJaeSz9pjD41KtGqQejyL4lAPdn9+8Owr?=
 =?us-ascii?Q?GgNiZgMcarwnGuOxDtGyvScy3d75LZ6uLV00MQuKDbKrrpreYc23A3UgDWX5?=
 =?us-ascii?Q?yDUPOQH8FRiZ7e3Y2mDuXXm1tB1GOIJa35rqgku+xv0yJaSVGL5CZct9+IDM?=
 =?us-ascii?Q?Sk4Buu/xURkY4HIOBUa0zsGv4/vBlzlYuTPqLwUER7ziaI85iU2m1cZslzeS?=
 =?us-ascii?Q?xadeI6OphcenEcMiPpYqCf6rByH+NzaCiz3Def/yp5b5f7FtIYF//WD8oVJF?=
 =?us-ascii?Q?14TbORXfPZqu6rpoKvWtGk6/3q2tIyBRcxNo1+awPCojnWPCf8Lj0De48Wmk?=
 =?us-ascii?Q?iaZb9tDSu6cX33qP6MEgLmmn9MQVEjrR2GcG5bEtQF9PpUMQSItr976tfauQ?=
 =?us-ascii?Q?1lk3yTnHsuDrkAbJeGYPn68RuCAWnbqvZJ2/L2LVKga2mLVm0OBtqrz/Jq8p?=
 =?us-ascii?Q?yJfHhqYM1SiPBYpgNGBWAGxS2Ep/QL3UEa9wATuZsSgrzo0VaZ1Yu3xl6TwJ?=
 =?us-ascii?Q?LKfHzXFsf+uQ+XQMx5u6JdxZiOVWST4/N8mrSxL3ORZdNOUNxopDGzSYk7jB?=
 =?us-ascii?Q?i0QD+VXy8KD2tVLBb+OxrqjRPdMbzxH6nSZYr90qNzCCSKBddpKgQpCAwwGA?=
 =?us-ascii?Q?tjSlJ3hKiMXCZbMr8I0J2PIoDY3enEBiX8T9lJvtTvjbrqpSvt2PfCDOcyro?=
 =?us-ascii?Q?S53zxJ2LMWjNhtxQs5V6KkhZmDBOT5bLsj1A6jDWTxVn7Azb3empAq19LoKp?=
 =?us-ascii?Q?4SGJPkVMMprE4POAExJcq4VDihnT7QWnRk60EhxDwRU5F1XLiGshr/v23ZyY?=
 =?us-ascii?Q?7eGfc7QuxfNSijf2NkvUWncGwZfJ3GSv9hhwkeTOMNz1xZNNQOvoFU0AVXJ5?=
 =?us-ascii?Q?hVo9StgfASQoXabMJk9/E2BSIxk52oX33df2Q6RZ90a0GU8NkbBc1WSpoANK?=
 =?us-ascii?Q?ujyBozUNw3KUbA38SHEGKSGp41XBb3ob/qTdidg8AztI/oU5FZssov3Xp151?=
 =?us-ascii?Q?c5KAzJPpTP7F6uuGceb1kGC37ptPufjQF8/LwkGMpa9IkLS8e/0VPCw/9q4F?=
 =?us-ascii?Q?B7jX92rdYjap81YjVpjmMbFX/xSDFoevYdFu2QNFytxHkn1PvVtpxzMy3JaK?=
 =?us-ascii?Q?7ugE5U6JfXVllm6qL3TuoiAV8gT022K1rvu/2XEOJqOkyRv20SQ5zvIti9mE?=
 =?us-ascii?Q?22XIR2tUD5ztsJ3MRPt9z3ltPt3lQhHdC5kt61+wzMK1qoN6074R9tIQThcG?=
 =?us-ascii?Q?6JtL90Ogpn4tECA6LC78SKjfqdzaLW668foxNlKTx6OZBxQMvSyTr3W+/7Lt?=
 =?us-ascii?Q?lV8o6cfUczjV8KdeM51Fd1si6nKdKT3zQoDKceZw?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be87e83d-927c-47a8-67b0-08dac3642b1d
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 21:40:21.3683
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wFIpv3IjZFf4PeTubfM0PkDqtxfnYdLdGV+vP4Hs8BZGsE1BIRxmOrZILWu03CPLv5dfIzlnUkwVdQPA284C4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7687
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Alexander Lobakin <alexandr.lobakin@intel.com>
> Sent: Thursday, November 10, 2022 10:43 AM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Alexander Lobakin <alexandr.lobakin@intel.com>; Paolo Abeni
> <pabeni@redhat.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Alexei
> > > at ../drivers/net/ethernet/freescale/fec_main.c:2788:4:
> > > ../include/linux/fortify-string.h:413:25: warning: call to
> '__read_overflow2_field'
> > > declared with attribute warning: detected read beyond size of field
> > > (2nd parameter); maybe use struct_group()? [-Wattribute-warning]
> > >   413 |                         __read_overflow2_field(q_size_field, =
size);
> > >       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~=
~~~~~
> > >
> > > I think you can address it changing fec_xdp_stat_strs definition to:
> > >
> > > static const char
> > > fec_xdp_stat_strs[XDP_STATS_TOTAL][ETH_GSTRING_LEN] =3D
> >
> > That does a problem. How about just change the memcpy to strncpy?
>=20
> Don't use a static char array, it would consume more memory than the curr=
ent
> code. Just replace memcpy()s with strscpy().
>=20
> Why u32 for the stats tho? It will overflow sooner or later. "To keep it =
simple
> and compatible" you can use u64_stats API :)

The reason to use u32 here is : 1. It is simple to implement. 2. To follow =
the same
behavior as the other MAC hardware statistic counters which are all 32bit. =
3. I did
investigate the u64_stats API, and think it is still a little expensive her=
e.

Thanks,
Shenwei

>=20
> >
> > Regards,
> > Shenwei
> >
> > > { // ...
> > >
> > > Cheers,
> > >
> > > Paolo
>=20
> Thanks,
> Olek