Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <167bf351-97e7-f26a-37c7-b8446f16e087@riseup.net>
Date:   Thu, 10 Nov 2022 19:42:44 -0300
MIME-Version: 1.0
Subject: Re: [PATCH] HID: uclogic: Standardize test name prefix
To:     =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>,
        jikos@kernel.org
Cc:     benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221110174955.398885-1-jose.exposito89@gmail.com>
Content-Language: en-US
From:   =?UTF-8?Q?Ma=c3=adra_Canal?= <mairacanal@riseup.net>
In-Reply-To: <20221110174955.398885-1-jose.exposito89@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi José,

On 11/10/22 14:49, José Expósito wrote:
> Commit 961bcdf956a4 ("drm/tests: Change "igt_" prefix to "drm_test_"")
> introduced a new naming convention for the KUnit tests present in the
> DRM subsystem: "drm_test_<module>_<test name>".
>> This naming convention is very convenient because it allows to easily
> run all subsystem tests or all driver tests using kunit.py's wildcards.
> 
> Follow the naming conventions used in the DRM subsystem adapted to the
> HID subsystem: "hid_test_<module>_<test name>".
> 
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>

It is great to see this coming to other subsystems!

Reviewed-by: Maíra Canal <mairacanal@riseup.net>

Best Regards,
- Maíra Canal

> ---
>  drivers/hid/hid-uclogic-params-test.c | 4 ++--
>  drivers/hid/hid-uclogic-rdesc-test.c  | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/hid/hid-uclogic-params-test.c b/drivers/hid/hid-uclogic-params-test.c
> index 57ef5d3e4b74..bfa7ccb7d1e8 100644
> --- a/drivers/hid/hid-uclogic-params-test.c
> +++ b/drivers/hid/hid-uclogic-params-test.c
> @@ -136,7 +136,7 @@ static void uclogic_parse_ugee_v2_desc_case_desc(struct uclogic_parse_ugee_v2_de
>  KUNIT_ARRAY_PARAM(uclogic_parse_ugee_v2_desc, uclogic_parse_ugee_v2_desc_cases,
>  		  uclogic_parse_ugee_v2_desc_case_desc);
>  
> -static void uclogic_parse_ugee_v2_desc_test(struct kunit *test)
> +static void hid_test_uclogic_parse_ugee_v2_desc(struct kunit *test)
>  {
>  	int res;
>  	s32 desc_params[UCLOGIC_RDESC_PH_ID_NUM];
> @@ -175,7 +175,7 @@ static void uclogic_parse_ugee_v2_desc_test(struct kunit *test)
>  }
>  
>  static struct kunit_case hid_uclogic_params_test_cases[] = {
> -	KUNIT_CASE_PARAM(uclogic_parse_ugee_v2_desc_test,
> +	KUNIT_CASE_PARAM(hid_test_uclogic_parse_ugee_v2_desc,
>  			 uclogic_parse_ugee_v2_desc_gen_params),
>  	{}
>  };
> diff --git a/drivers/hid/hid-uclogic-rdesc-test.c b/drivers/hid/hid-uclogic-rdesc-test.c
> index 3971a0854c3e..b429c541bf2f 100644
> --- a/drivers/hid/hid-uclogic-rdesc-test.c
> +++ b/drivers/hid/hid-uclogic-rdesc-test.c
> @@ -187,7 +187,7 @@ static void uclogic_template_case_desc(struct uclogic_template_case *t,
>  KUNIT_ARRAY_PARAM(uclogic_template, uclogic_template_cases,
>  		  uclogic_template_case_desc);
>  
> -static void uclogic_template_test(struct kunit *test)
> +static void hid_test_uclogic_template(struct kunit *test)
>  {
>  	__u8 *res;
>  	const struct uclogic_template_case *params = test->param_value;
> @@ -203,7 +203,7 @@ static void uclogic_template_test(struct kunit *test)
>  }
>  
>  static struct kunit_case hid_uclogic_rdesc_test_cases[] = {
> -	KUNIT_CASE_PARAM(uclogic_template_test, uclogic_template_gen_params),
> +	KUNIT_CASE_PARAM(hid_test_uclogic_template, uclogic_template_gen_params),
>  	{}
>  };
>