Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Nov 2022 23:30:34 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Jamie Bainbridge <jamie.bainbridge@gmail.com>
Cc:     Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp: Add listening address to SYN flood message
Message-ID: <Y217ikkZzXKKGix4@lunn.ch>
References: <f847459dc0a0e2d8ffa1d290d06e0e4a226a6f39.1668075479.git.jamie.bainbridge@gmail.com>
 <Y20Bxc1gQ8nrFsvA@lunn.ch>
 <CAAvyFNg1F8ixrgy0YeL-TT5xLmk8N7dD=ZMLQ6VxsjHb_PU9bg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAvyFNg1F8ixrgy0YeL-TT5xLmk8N7dD=ZMLQ6VxsjHb_PU9bg@mail.gmail.com>
Precedence: bulk

On Fri, Nov 11, 2022 at 08:20:18AM +1100, Jamie Bainbridge wrote:
> On Fri, 11 Nov 2022 at 00:51, Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Thu, Nov 10, 2022 at 09:21:06PM +1100, Jamie Bainbridge wrote:
> > > The SYN flood message prints the listening port number, but on a system
> > > with many processes bound to the same port on different IPs, it's
> > > impossible to tell which socket is the problem.
> > >
> > > Add the listen IP address to the SYN flood message. It might have been
> > > nicer to print the address first, but decades of monitoring tools are
> > > watching for the string "SYN flooding on port" so don't break that.
> > >
> > > Tested with each protcol's "any" address and a host address:
> > >
> > >  Possible SYN flooding on port 9001. IP 0.0.0.0.
> > >  Possible SYN flooding on port 9001. IP 127.0.0.1.
> > >  Possible SYN flooding on port 9001. IP ::.
> > >  Possible SYN flooding on port 9001. IP fc00::1.
> > >
> > > Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>
> > > ---
> > >  net/ipv4/tcp_input.c | 16 +++++++++++++---
> > >  1 file changed, 13 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> > > index 0640453fce54b6daae0861d948f3db075830daf6..fb86056732266fedc8ad574bbf799dbdd7a425a3 100644
> > > --- a/net/ipv4/tcp_input.c
> > > +++ b/net/ipv4/tcp_input.c
> > > @@ -6831,9 +6831,19 @@ static bool tcp_syn_flood_action(const struct sock *sk, const char *proto)
> > >               __NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPREQQFULLDROP);
> > >
> > >       if (!queue->synflood_warned && syncookies != 2 &&
> > > -         xchg(&queue->synflood_warned, 1) == 0)
> > > -             net_info_ratelimited("%s: Possible SYN flooding on port %d. %s.  Check SNMP counters.\n",
> > > -                                  proto, sk->sk_num, msg);
> > > +         xchg(&queue->synflood_warned, 1) == 0) {
> > > +#if IS_ENABLED(CONFIG_IPV6)
> > > +             if (sk->sk_family == AF_INET6) {
> >
> > Can the IS_ENABLED() go inside the if? You get better build testing
> > that way.
> >
> >      Andrew
> 
> Are you sure? Why would the IS_ENABLED() be inside of a condition
> which isn't compiled in? If IPv6 isn't compiled in then the condition
> would never evaluate as true, so seems pointless a pointless
> comparison to make? People not compiling in IPv6 have explicitly asked
> *not* to have their kernel filled with a bunch of "if (family ==
> AF_INET6)" haven't they?
> 
> There are many other examples of this pattern of "IS_ENABLED()" first
> and "if (family == AF_INET6)" inside it, but I can't see any of the
> inverse which I think you're suggesting, see:
> 
>  grep -C1 -ERHn "IS_ENABLED\(CONFIG_IPV6\)" net | grep -C1 "family == AF_INET6"
> 
> Please let me know if I've misunderstood?

So what i'm suggesting is

               if (IS_ENABLED(CONFIG_IPV6) && sk->sk_family == AF_INET6) {
                       net_info_ratelimited("%s: Possible SYN flooding on port %d. IP %pI6c. %s.  Check SNMP counters.\n",
                                       proto, sk->sk_num,
                                       &sk->sk_v6_rcv_saddr, msg);
		}

The IS_ENABLED(CONFIG_IPV6) will evaluate to 0 at compile time, and
the optimiser will throw away the whole lot since it can never be
true. However, before the code gets to the optimiser, it first needs
to compile. It will check you have the correct number of parameters
for the string format, do the types match, do the structure members
exist, etc. Anybody doing compile testing of a change, and they have
IPV6 turned off, has a chance off getting errors reported when they
have actually broken IPV6, but don't know it, because they are not
compiling it.

Now, IPV6 is one of those big options which i expect 0-day tests quite
regularly. Using IF_ENABLED() like this brings more benefit from less
used options which gets very little build testing, and so are often
broke until somebody like Arnd runs builds with lots of random
configs.

	Andrew