Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <285274e0-51bd-3334-1cb2-3af1b1aa1ba2@arm.com>
Date:   Thu, 10 Nov 2022 17:17:50 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 3/5] ACPI: PPTT: Remove acpi_find_cache_levels()
Content-Language: en-US
To:     Pierre Gondois <pierre.gondois@arm.com>,
        linux-kernel@vger.kernel.org
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Gavin Shan <gshan@redhat.com>,
        Peter Chen <peter.chen@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org
References: <20221108110424.166896-1-pierre.gondois@arm.com>
 <20221108110424.166896-4-pierre.gondois@arm.com>
From:   Jeremy Linton <jeremy.linton@arm.com>
In-Reply-To: <20221108110424.166896-4-pierre.gondois@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/8/22 05:04, Pierre Gondois wrote:
> acpi_find_cache_levels() is used at a single place and is short
> enough to be merged into the calling function. The removal allows
> an easier renaming of the calling function in the next patch.
> 
> Also reorder the parameters in the 'reversed Christmas tree' order.
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>

This bit looks fine too:

Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>


> ---
>   drivers/acpi/pptt.c | 21 ++++++---------------
>   1 file changed, 6 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c
> index c91342dcbcd6..97c1d33822d1 100644
> --- a/drivers/acpi/pptt.c
> +++ b/drivers/acpi/pptt.c
> @@ -281,19 +281,6 @@ static struct acpi_pptt_processor *acpi_find_processor_node(struct acpi_table_he
>   	return NULL;
>   }
>   
> -static int acpi_find_cache_levels(struct acpi_table_header *table_hdr,
> -				  u32 acpi_cpu_id)
> -{
> -	int number_of_levels = 0;
> -	struct acpi_pptt_processor *cpu;
> -
> -	cpu = acpi_find_processor_node(table_hdr, acpi_cpu_id);
> -	if (cpu)
> -		number_of_levels = acpi_count_levels(table_hdr, cpu);
> -
> -	return number_of_levels;
> -}
> -
>   static u8 acpi_cache_type(enum cache_type type)
>   {
>   	switch (type) {
> @@ -613,9 +600,10 @@ static int check_acpi_cpu_flag(unsigned int cpu, int rev, u32 flag)
>    */
>   int acpi_find_last_cache_level(unsigned int cpu)
>   {
> -	u32 acpi_cpu_id;
> +	struct acpi_pptt_processor *cpu_node;
>   	struct acpi_table_header *table;
>   	int number_of_levels = 0;
> +	u32 acpi_cpu_id;
>   
>   	table = acpi_get_pptt();
>   	if (!table)
> @@ -624,7 +612,10 @@ int acpi_find_last_cache_level(unsigned int cpu)
>   	pr_debug("Cache Setup find last level CPU=%d\n", cpu);
>   
>   	acpi_cpu_id = get_acpi_id_for_cpu(cpu);
> -	number_of_levels = acpi_find_cache_levels(table, acpi_cpu_id);
> +	cpu_node = acpi_find_processor_node(table, acpi_cpu_id);
> +	if (cpu_node)
> +		number_of_levels = acpi_count_levels(table, cpu_node);
> +
>   	pr_debug("Cache Setup find last level level=%d\n", number_of_levels);
>   
>   	return number_of_levels;