Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1535809rwb; Thu, 10 Nov 2022 18:24:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf53OIHu4cpqAuvqDyz0uRx9xY0QOCWvvzxzmReECC2OmmtwORBwVDO39I8G12V1nRYiybzI X-Received: by 2002:a17:906:68d8:b0:78d:e786:e322 with SMTP id y24-20020a17090668d800b0078de786e322mr287385ejr.308.1668133461889; Thu, 10 Nov 2022 18:24:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668133461; cv=none; d=google.com; s=arc-20160816; b=hE+W895dhHZibHnpOpF7HG6mzK9PVedw0PBLG75jhuyE/6DJPDTPr00oil9jkbK3uv DJvJChuuwxo/A1EvP0+8uHwu5AK+RfkdFQrGSJYc02jAgJH1fmjiMCk3B38MsPUZgx6T gzP0v7N9Tl21NIyOABl+ERbSeLgxPA8n8AiYsqxnyeAo8UEsdcj+so2mdV0KAJH3JaGZ x1zrofPtA5TQiC7bdX6RP/YUIw3SUu4OWa31TKoeRtX7CjoOU8b0lWHlI8+MivKA234v 3+1Yq7laLMb3tiXZe4iXP06XR7X36SGh3aqNenNoYDDUIkFsogmV9RV47jFdGduFQhbp skKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=pHJb6eAG+2CiHS4e1oYI92e5vroUitehSfx71dm2Ubk=; b=BQ2fg8uBv+NJVW94S1mT3fK5WEICK2HiU1ho8MY7O9nlHsE7NamvyzD0AmxpLSkf8A mUbTELR1Oe8aOFRxQr/vHK2pKL+k6eWWLEhOvmEC/Oeed9G732gIOM30TawTInr9np0/ 161fY5H6GC8KA7iQwYZe00ujVW2F6mGAVLaTNIitIE/qUD0m5PgLbEyJil8UzHHDEdOv O2q05y349DtogOHgmZ8zxHMtNd2j9A/hW+x4ZMWf3cWZ1HD/9RDtGbZk0FVgESRhl1L6 sZB58rNY7tOPMWR0jlsFZ34TM5bLpAHMFHeQj7W4v8BC+dWCSG5WTudcPUSw9itQ62VY q4BA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BOWE3xAS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id da1-20020a056402176100b0045ca3839229si952387edb.274.2022.11.10.18.23.59; Thu, 10 Nov 2022 18:24:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BOWE3xAS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231235AbiKKCJs (ORCPT + 93 others); Thu, 10 Nov 2022 21:09:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbiKKCJq (ORCPT ); Thu, 10 Nov 2022 21:09:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE29B31ECF; Thu, 10 Nov 2022 18:09:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9ABC2B822D7; Fri, 11 Nov 2022 02:09:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC8E5C433D7; Fri, 11 Nov 2022 02:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668132583; bh=qcXT7KsM5AB7BhN9n5UAOoecfPi2ohVfDNCAo8pmWak=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BOWE3xASGTo5opUTU8n+qd6emXvNL4zBwG74lih/1WEmy+PNHIwvmzgCgVTU2IHSS AAsn7ZLfk1l6dVi9t2VwT0/dOTi9/iZKnNoTnWC50RO3jhOvuSqfj6By3GNDoL0MHM CjeAKkXKacSUAch/n80gUJK11yEn/qWRCg0My80tEHQe5i1GazAJM2T6tQU+v2jZ9X RdB9Sv8BB9P6bM5MDhRKcV8mQYgTxOa3wcDxGtQkoJh+OTHFU1ONmGZc/KdjinFwj4 w3dvHijRNpqrO3ZDfSZvgWkm6QLdfApI3TSlyJqVGid9eIqUHsKOTlLkDIr3JEM1Oh oTbAGcfhs8y+g== Date: Thu, 10 Nov 2022 18:09:41 -0800 From: Jakub Kicinski To: Felix Fietkau Cc: netdev@vger.kernel.org, John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , Vladimir Oltean , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 11/12] net: ethernet: mtk_eth_soc: set NETIF_F_ALL_TSO Message-ID: <20221110180941.11eff62e@kernel.org> In-Reply-To: <20221109163426.76164-12-nbd@nbd.name> References: <20221109163426.76164-1-nbd@nbd.name> <20221109163426.76164-12-nbd@nbd.name> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Nov 2022 17:34:25 +0100 Felix Fietkau wrote: > Significantly improves performance by avoiding unnecessary segmentation NETIF_F_TSO_ECN is the bit that matters here, right? It'd be reassuring if the commit message mentioned it and confirmed it works correctly :S