Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221110175959.3240475-1-joel@joelfernandes.org> <20221111093445.e195afe799822d5a7ffbaca4@kernel.org>
In-Reply-To: <20221111093445.e195afe799822d5a7ffbaca4@kernel.org>
From:   Joel Fernandes <joel@joelfernandes.org>
Date:   Fri, 11 Nov 2022 02:22:36 +0000
Message-ID: <CAEXW_YRtiwrWsJ8hMGMa5bKKhT163+P3OzR0T0feQROjzSJ1hQ@mail.gmail.com>
Subject: Re: [PATCH v2] tracing: Dump instance traces into dmesg on ftrace_dump_on_oops
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        rostedt@goodmis.org, Ross Zwisler <zwisler@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 11, 2022 at 12:34 AM Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> On Thu, 10 Nov 2022 17:59:59 +0000
> "Joel Fernandes (Google)" <joel@joelfernandes.org> wrote:
>
> > Currently ftrace only dumps the global trace buffer on an OOPs. For
> > debugging a production usecase, I'd like to dump instance traces as
> > well, into the kernel logs. The reason is we cannot use the global trace
> > buffer as it may be used for other purposes.
> >
> > This patch adds support for dumping the trace buffer instances along
> > with the global trace buffer.
> >
> > The instance traces are dumped first, and then the global trace buffer.
> >
>
> This looks good to me.
>
> Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thanks!

 - Joel


  - Joel