Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ab2cd7e4-fe35-63a4-7fe3-4d98bf8ce4e1@meta.com>
Date:   Thu, 10 Nov 2022 19:49:58 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.2
Subject: Re: [PATCH] lib/radix-tree: Fix uninitialized variable compilation
Content-Language: en-US
To:     Rong Tao <rtoax@foxmail.com>
Cc:     acme@redhat.com, bpf@vger.kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, pabeni@redhat.com, rongtao@cestc.cn
References: <4ed2ebee-26a8-f0ab-2bc4-a0b6a29768af@meta.com>
 <tencent_754AAA6CBDDE8DB223CE1BF009D566E55E0A@qq.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <tencent_754AAA6CBDDE8DB223CE1BF009D566E55E0A@qq.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkgwdmVtRkgxdzluK2hQclVyeDRBbDRwRGd0OG1xSUNyNHFyMnJRQXh1OGx2?=
 =?utf-8?B?R0hVcUJPamhCckwyTi9pemc5NCtqaDR2UDlhdjFaSDFXdkRhUjZ5clk2TVhr?=
 =?utf-8?B?UlQ2WlI2TVoyVnVWL29CcWhQOTBDeWs2UDBIVjNYVUNPa2NLWWhST3h3aVkz?=
 =?utf-8?B?S01NcHBPRHVWTk9RSWk3R3BseHVHamFkY2xOWm4zNm5GNEw0NlJVQzAyUVNF?=
 =?utf-8?B?TlJ0VHFtRGdCdGM2SWhnVUhLOEN2cVVmK1Q3L2F1dmNrM1FlS2p6bnFydGRD?=
 =?utf-8?B?cFJ1TGtLd21KcGdtNnhKZ1BkOHZlYkUrVGVtUmlaZm5nRnFDd002MW0zSDFs?=
 =?utf-8?B?S3JxUHhZK056UTd0clNBZVQxcFhha3YwS3ZPK0IrYzhKYlNic0lrUVdvaVky?=
 =?utf-8?B?NnhWV1l6ZFZSeFUxRG9BVGRNZlk1VjZOZkxFdFgzYWJJRFJzdmJHdE4vc2V0?=
 =?utf-8?B?WkZHNVhKNUdmd3Avcm9qR0hoL0dIc1FHYkd2L2xEaDBmVmUza0UwcWQ5T21a?=
 =?utf-8?B?VUkxbzd4N3h5U2J3K002WlZUUXRxYzFZWWJTM2Q4a0EwZmQ2bE1jT0FmRm5F?=
 =?utf-8?B?OVFzNTBwUVcvMzBnY2haS2d1NDZicWRkd2dCTzFENDB4QW14S1JFcVJxYnpR?=
 =?utf-8?B?cWhJcWE5TS9KNjVlN3psV3dtRU1IWk0zZ2o1WEJXUGs5ZTd1ajdTaW1ZTGk1?=
 =?utf-8?B?YXJMNkF2dWRLUTFFY2VKWFY1SkxOd3Z1cHJCTVJrdDBVUlNDZk5OMmdGMkZJ?=
 =?utf-8?B?YWxkT3FueWFtSlZjU1FYWkNCQnJHSTRZNGVqOFRsSHdVZzl0RDBkbXFObFBs?=
 =?utf-8?B?dmo1QU40QWlnZ09FRDFDL1VDc0ZhSDBmLzlyQWNyUjdFMkkzYVJCbnR4OTBp?=
 =?utf-8?B?UUpWemV0cmNORHM3U2czaEJ3MlNiTysrbFZEeTU1c1BHM1NFUHhUOUlpL3JY?=
 =?utf-8?B?TEh5Y1ZWRno5U3FXS1FxaGRocThGQ1hJTGpjejNHdkdacWc3bTVIZ0ZXYmpF?=
 =?utf-8?B?V3NkcUVnaTRCSVdCVk9zVjBiMDlTaDYyNFJNRWpyNE9DRDd6d2ZQY2JpZkF6?=
 =?utf-8?B?dnRhb3hyazJ2YXFNa0xsT0x5NXpuQzhRYTN0MTVqazRZT1RybWRIY1JSYURw?=
 =?utf-8?B?ZGFXQmR2Y00yODM3NHE2MUdRWnlScTkxOEQyRGNHdlk5bjExYm40OUFXb1FQ?=
 =?utf-8?B?ZDU5clY2T3JCaFpSMmhmckY2Mmw0SGFSaldqdWVFeTN6Ym9YVHROKzhSb0pT?=
 =?utf-8?B?VElqVDRQY0dUa0lBbjBCK2xOYUhpWlcvZ0Y0NGl6TGZWaEpZcTd6SzJBckUy?=
 =?utf-8?B?aUkxWlNtMlRMc3R3YW5nSkh6U2YvUU1FNUYrUnZ4QnQ4RnFVS080WW13VU43?=
 =?utf-8?B?NlREbzVMWFJITU1yVUFOajBVbUwvZWdOVWwrTndEdWkrbGpVckhnL2g2dHly?=
 =?utf-8?B?bXQ5VndHb1NCZU5hYlpTdVJIM25lRFpSclpiL1JjVHo5UHBmQTMvR3pzVnY2?=
 =?utf-8?B?Zk1sOFd5dDBYNjZDcnpWQVR1enBOL292QnBIbVlUT2VBTk9HV2FaNWl3RVlu?=
 =?utf-8?B?RXYxNFI2WDRaRWFUOGJwNUg2Sk56ODhUS25Mdk9EZFhiTlh2bUpFQzJYSEJm?=
 =?utf-8?B?OFB2WTRKZ21NV1lIL0VsMEFwOUpwSHc4K0RYZStESXJWL1NKR0VnY2syVHNh?=
 =?utf-8?B?OVZUbnd2UVlnTFRUUjR4dy8wemdJSitoQzRKRDQrRmhwSzZBdWpNYTNqKzZh?=
 =?utf-8?B?N01hSUNGejlCUEhHUm9aTVNNK1pvSGV1elJQSlRldTFaMG4yUTlYOHdUSEFX?=
 =?utf-8?B?cnhCN2RSQ1VFbDI3ZVVhMXFmdFA2TWVCM0huK3I2UWw5WFVieUZPMXJYZG9V?=
 =?utf-8?B?R0RkelA4emVMYTAyZitmaVBBdGhFTDFROWFQb1F1bU1LalZHZ1lac2h1MWV6?=
 =?utf-8?B?Z1JRV1VWUjBaclRqdEpqdkd6ZC9uNlpOa1dsbGRuNlJzeXJlY1Vnd0lpZXNl?=
 =?utf-8?B?N24vUGx6RHM2TkxVQnhqMEZVbllVcGxycGtuNmNCQzBlWmZqaUYvYTUzOWhj?=
 =?utf-8?B?aUtyNytQKzU4S1FwN09ESHdEK0NSN3M0bEVTQ3NTMU1HVXBJQTJxSDdhM0JP?=
 =?utf-8?B?UXlrSzNaWnNUV092aFFxR2NQTGNmMVJPdnRHd3hWL1pTV0JDc3VQellzcVNI?=
 =?utf-8?B?ZGc9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1862810-d6f6-4ed9-0388-08dac397cee2
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1501MB2055.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 03:50:00.7086
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SJEWlMclmpDeoT9PW94m+bU2ZKzZQ98RJtmI7lmcLyqgGzobRQob1QWJZFM50Cir
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1608
X-Proofpoint-GUID: UM6HnEd2iyslTDdXr7Vw58dSnkas9ax_
X-Proofpoint-ORIG-GUID: UM6HnEd2iyslTDdXr7Vw58dSnkas9ax_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-11_01,2022-11-09_01,2022-06-22_01
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/10/22 6:18 PM, Rong Tao wrote:
> Hi, Song, thanks for your reply. I'm wondering if i want to fix code in
> tools/include/uapi/linux/in.h next time, should i just modify
> include/uapi/linux/in.h, and it will auto 'Sync' to tools/include/uapi/
> linux/in.h? Or i need to modify tools/include/uapi/linux/in.h at the
> same time?

Either way is okay. If you do 'git log' on tools/include/uapi/linux
directory, you can find examples for both approaches.