Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Nov 2022 11:53:04 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     "Wang, Xiaolei" <xiaolei.wang@windriver.com>,
        l.stach@pengutronix.de
Cc:     s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: imx8m: Increase the clock enable before reading the
 register
Message-ID: <20221111035304.GL125525@dragon>
References: <20221028041418.4033261-1-xiaolei.wang@windriver.com>
 <20221111024607.GH125525@dragon>
 <f0e35731-07df-bd80-329f-a5ad9818e1e8@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f0e35731-07df-bd80-329f-a5ad9818e1e8@windriver.com>
Precedence: bulk

On Fri, Nov 11, 2022 at 11:01:15AM +0800, Wang, Xiaolei wrote:
> 
> On 11/11/2022 10:46 AM, Shawn Guo wrote:
> > CAUTION: This email comes from a non Wind River email account!
> > Do not click links or open attachments unless you recognize the sender and know the content is safe.
> > 
> > On Fri, Oct 28, 2022 at 12:14:18PM +0800, Xiaolei Wang wrote:
> > > When executing kdump to start the second kernel,
> > > since IMX-OCOTP has turned off the clock, the clock
> > > needs to be re-enabled, otherwise the system will hang.
> > > 
> > > Fixes: ac34de14ac30 ("Revert "soc: imx8m: change to use platform driver"")
> > Are you saying this fixes a regression caused by ac34de14ac30?
> 
> 
> Yes,
> 
> Although there is a problem with commit 7d981405d0fd, it also solves the
> kexec kernel hang, commit 7d981405d0fd is reverted, and the kexec kernel
> hang will also be introduced, so the clock needs to be enabled when the
> kexec kernel starts.

Ok.

Lucas,

Any comments here?

Shawn