Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1633444rwb; Thu, 10 Nov 2022 20:31:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf5vVc6KfYbLmDZywrkm2M7P0Oub1QDsLpYEOgmjHgyEBk0wUIXOXjuv8EY20+Yy5r6EAPEY X-Received: by 2002:a17:90a:8c82:b0:210:c745:2a22 with SMTP id b2-20020a17090a8c8200b00210c7452a22mr35437pjo.36.1668141111903; Thu, 10 Nov 2022 20:31:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668141111; cv=none; d=google.com; s=arc-20160816; b=grUtp/LYbmzkBK2XwXy+403wHR/egaveR2RTQS2gjjbHNVPcJHkhzxqwDZGGqkCG6u HSdlwGNaJWxpAEfJaKHvUVgAybxkq5urUMZC6ch6nVzBsbdb2EcM4EiKdaIW3Inr5V/j Roh01wtOg/1cnJ8Gxs9p4E7/WipGri/pMxmiysmosMhI7ddmsrNkEtUE/kr5biAyjxQY Cm/LhnFpD7IogPDaKfuZ2SEi+UenfJw3Q4ERqspaRPhzew6FbwkJBS1N7gwbqfHQo3qc KbqDGdv2TRMoWzDNYwV1O9ZxNAUpKki/9O2svoYDWcH+k4l2IE7Ky3bCmjcNHUyK7lK2 m29g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7cZqvSw/U6+6plPMYAZLpeiiQSRLDQLMTVFW/7cQ4tQ=; b=QbZlNtRYIZ3dvU7Sl47rYRZ3B/U0Nke2+IIVcpLX1ZfdF0YW8kFL9NaAdKnWeVK8rM 0+Yr6HHiqAHZbzVkKWGAxQOV2MvekGogc8/233gf0GI2jpKMLqxq998DfgTUgL6Soosy MISderTMYvX1QEbCqavS7H7vhaP6Tk/wa1U4XeeXZse1BYfNaDVOEWzwaPMJHR2GZsLy wDajq0S8bujRvWFQq6wUF4IF9WCqAIxpx5yrjZhugd+oSYI1WGosqPAssN6MMFGPQj28 Qa7LojEuaNG5p9oCG49rhylQDHKgwtply4oDRpYGl24SJlutkk3fy6ds2hDtKD7f6gTo Ij7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EQSYBhSG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z74-20020a63334d000000b0046edccffb8dsi1252891pgz.535.2022.11.10.20.31.39; Thu, 10 Nov 2022 20:31:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EQSYBhSG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231979AbiKKEZO (ORCPT + 92 others); Thu, 10 Nov 2022 23:25:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231559AbiKKEZI (ORCPT ); Thu, 10 Nov 2022 23:25:08 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 015FB6828E for ; Thu, 10 Nov 2022 20:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668140706; x=1699676706; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rRCWr54MBfM38aSNFQijVwdAC/iSuunIyJ/8rXD9+Rw=; b=EQSYBhSGESzefNchMxwiM4MNyUvQCUKDoEx7lksBkYolNHpwyJhhQDtE 0KS75tExJivFZI8fsbeSCJ4g8Zry1Cl1gg8S5EJ4oBx8Oz8hd+SC7LBDp KfXmJgYCk2Kdkom3DGYp6BNdvgbWmVVCCAOiCVfjgojAGL6inlRQXfawj TSBOEsBj00mt4PCKo/J7LPXExCvQMnoJ5BEJjybsJb61bgEXvzW/KnEze Apcfoye5n79zR7/B/ZolWkTrD4OVrvPb/M6SHKkLObiRXza/svtQe1+aw uxMaNQF16GyFP2hdISNy7/AeShlQ9+XPo6VfGtVupxaCtZoBbQZyN2Bc2 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="397816275" X-IronPort-AV: E=Sophos;i="5.96,155,1665471600"; d="scan'208";a="397816275" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 20:25:06 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="588440660" X-IronPort-AV: E=Sophos;i="5.96,155,1665471600"; d="scan'208";a="588440660" Received: from bard-ubuntu.sh.intel.com ([10.239.185.57]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 20:25:04 -0800 From: Bard Liao To: alsa-devel@alsa-project.org, vkoul@kernel.org Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, pierre-louis.bossart@linux.intel.com, bard.liao@intel.com Subject: [PATCH 1/8] soundwire: intel_init: remove useless interrupt enablement in interrupt thread Date: Fri, 11 Nov 2022 12:26:46 +0800 Message-Id: <20221111042653.45520-2-yung-chuan.liao@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221111042653.45520-1-yung-chuan.liao@linux.intel.com> References: <20221111042653.45520-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pierre-Louis Bossart When the code reaches the SoundWire interrupt thread handling, the interrupt was enabled already, and there is no code that disables it -> this is a no-op sequence. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Péter Ujfalusi Reviewed-by: Ranjani Sridharan Signed-off-by: Bard Liao --- drivers/soundwire/intel_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c index d091513919df..8bd95c9cbcaf 100644 --- a/drivers/soundwire/intel_init.c +++ b/drivers/soundwire/intel_init.c @@ -157,7 +157,6 @@ irqreturn_t sdw_intel_thread(int irq, void *dev_id) list_for_each_entry(link, &ctx->link_list, list) sdw_cdns_irq(irq, link->cdns); - sdw_intel_enable_irq(ctx->mmio_base, true); return IRQ_HANDLED; } EXPORT_SYMBOL_NS(sdw_intel_thread, SOUNDWIRE_INTEL_INIT); -- 2.25.1