Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Vivek Yadav" <vivek.2311@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <rcsekar@samsung.com>, <krzysztof.kozlowski+dt@linaro.org>,
        <wg@grandegger.com>, <mkl@pengutronix.de>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <pankaj.dubey@samsung.com>, <ravi.patel@samsung.com>,
        <alim.akhtar@samsung.com>, <linux-fsd@tesla.com>,
        <robh+dt@kernel.org>
Cc:     <linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <aswani.reddy@samsung.com>, <sriranjani.p@samsung.com>
In-Reply-To: <277004ed-3b6b-4ee5-39e4-beb75a272e60@linaro.org>
Subject: RE: [PATCH v2 1/6] dt-bindings: Document the SYSREG specific
 compatibles found on FSD SoC
Date:   Fri, 11 Nov 2022 09:36:46 +0530
Message-ID: <001601d8f583$06d01250$147036f0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQFejcOECimRbNc2gYBlewkpfd/ZqQHz7ogqAVwjo3kCSHwOhwGfuKaeAOJGcdCu7RURAA==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20221109100928.109478-1-vivek.2311@samsung.com>
        <CGME20221109100245epcas5p38a01aed025f491d39a09508ebcdcef84@epcas5p3.samsung.com>
        <20221109100928.109478-2-vivek.2311@samsung.com>
        <709daf8b-a58e-9247-c5d8-f3be3e60fe70@linaro.org>
        <000001d8f4f6$1c7e96e0$557bc4a0$@samsung.com>
        <277004ed-3b6b-4ee5-39e4-beb75a272e60@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
> Sent: 10 November 2022 17:42
> To: Vivek Yadav <vivek.2311=40samsung.com>; rcsekar=40samsung.com;
> krzysztof.kozlowski+dt=40linaro.org; wg=40grandegger.com;
> mkl=40pengutronix.de; davem=40davemloft.net; edumazet=40google.com;
> kuba=40kernel.org; pabeni=40redhat.com; pankaj.dubey=40samsung.com;
> ravi.patel=40samsung.com; alim.akhtar=40samsung.com; linux-fsd=40tesla.co=
m;
> robh+dt=40kernel.org
> Cc: linux-can=40vger.kernel.org; netdev=40vger.kernel.org; linux-
> kernel=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; linux-
> samsung-soc=40vger.kernel.org; devicetree=40vger.kernel.org;
> aswani.reddy=40samsung.com; sriranjani.p=40samsung.com
> Subject: Re: =5BPATCH v2 1/6=5D dt-bindings: Document the SYSREG specific
> compatibles found on FSD SoC
>=20
> On 10/11/2022 12:18, Vivek Yadav wrote:
> >>> +maintainers:
> >>> +  - Alim Akhtar <alim.akhtar=40samsung.com>
> >>> +
> >>> +description: =7C
> >>> +  This is a system control registers block, providing multiple low
> >>> +level
> >>> +  platform functions like board detection and identification,
> >>> +software
> >>> +  interrupt generation.
> >>> +
> >>> +properties:
> >>> +  compatible:
> >>> +    oneOf:
> >>
> >> No need for oneOf.
> >>
> > Removing this results into dt_binding_check error, so this is required.
>=20
> No, this is not required. You do not have more than one condition for one=
Of.
>=20
Oh, ok I got it. I was not removing =22-=22 before items, which is resultin=
g an error. I will update this in next patch series. Sorry for confusion.
> >>> +      - items:
> >>> +          - enum:
> >>> +              - tesla,sysreg_fsys0
> >>> +              - tesla,sysreg_peric
> >>
> >> From where did you get underscores in compatibles?
> >>
> > I have seen in MCAN Driver <drivers/net/can/m_can/m_can_platform.c>
> and also too many other yaml files.
> > Do you have any ref standard guideline of compatible which says
> underscore is not allowed.
>=20
> git grep compatible arch/arm64/boot/dts/exynos/ =7C grep _ git grep
> compatible arch/arm/boot/dts/exynos* =7C grep _
>=20
> Both give 0 results. For few other SoCs there such cases but that's reall=
y,
> really exception. Drop underscores.
>=20
git grep compatible arch/arm64/boot/dts/ =7C grep _ =7C wc -l=20
This gives me 456 location, am I missing anything here ?
Anyway I will replace with =22-=22 in next patch series.
>=20
> Best regards,
> Krzysztof
Thanks for review the patches.