Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Nov 2022 13:49:13 +0800
From:   Pengfei Xu <pengfei.xu@intel.com>
To:     Joanne Koong <joannelkoong@gmail.com>
CC:     <linux-kernel@vger.kernel.org>, <heng.su@intel.com>
Subject: Re: [Syzkaller] There is inet_csk_get_port WARNING in v6.1-rc4 kernel
Message-ID: <Y23iWU/hpUGpdqVf@xpf.sh.intel.com>
References: <Y2xyHM1fcCkh9AKU@xpf.sh.intel.com>
 <CAJnrk1ZvWfSAsYx-cErCqjQbciKCiAKss6Kvcm_4vXP5bzFh2g@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAJnrk1ZvWfSAsYx-cErCqjQbciKCiAKss6Kvcm_4vXP5bzFh2g@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?G7Mo236yJV87dw+KfWHIy/BgxedSb+pCEcNUHY99CLk/8PU3qJKM/bEZmo7Y?=
 =?us-ascii?Q?D4QfkH4k2nYaTMbhFrWoiFOlxG/axrZla+zVSyNxdq+g8O54DNivTPf65bSP?=
 =?us-ascii?Q?TT/cy0jRP7ia3fn6QM9RsaTsoTG+mfHgJvxg8+bmKazZOCWFxfw4FhhaLCKW?=
 =?us-ascii?Q?oDuoz+COwUTHYwlE/f4f3eavLcDTRnGbxPforAR7Axf70eEHfhzh1QZ6o9Yt?=
 =?us-ascii?Q?6nH9q3Vb02FT/dWm/M57GhVNHlJ/ze5DNkGZCLp2gLBD91R6D2FlDtYARtHL?=
 =?us-ascii?Q?Y9pcZZPZDPMnisojglBOFPfMadP7Xm8Q1LJJwV1ndqAkElmxxQIobCaWkAo3?=
 =?us-ascii?Q?V1/1v1c2XkajLSLrqOq2RQdSU7e9725Gyp/mpgw7TJx/MJgEkxggloqCbWEN?=
 =?us-ascii?Q?3t6bsnQWXu7xGw10grHGqse/Wyg2fhaexm53iXhqUF+VJYN6BruefQSS0Jhl?=
 =?us-ascii?Q?wAc91avQI3EP4Yhl39FOVLkJc2ptrIONmpOcOKP8AL8WePcVx6U5f4e1fpqt?=
 =?us-ascii?Q?cUT8wObRtxeStgqysIGPEPGEyQYGlTD98/V2psIHD11uX3kOSeWOCQ02ZKbc?=
 =?us-ascii?Q?PNmwD73oAtNvs4EznYqH1j4GFbsoudNpCayB3vJotgR94mlrQoX83eMsMmIT?=
 =?us-ascii?Q?X2Uvz3BU8SOCy5dHq5aO/pOrmG+G77P1UqjJygDaZmpYaw4nIahSzaMPJcdp?=
 =?us-ascii?Q?OU+e7XJB1cqRSkDWbRaEOOndwiU6Myr7EyICFBEbPWGZrcE+PWZXRP4NCt6Q?=
 =?us-ascii?Q?A8nZ06kYLtVCvTWnl+oSlv2OgL475yPh0V0h41VjUMU6XsLtTFpskTT49OtK?=
 =?us-ascii?Q?DUXeJJOajRjMxKDiJl/UohPenNlVuKUpP7wYIW7F++wn2wgu1hcBbvrD32xc?=
 =?us-ascii?Q?37lype9IgsdblN2/hYv+Ot/HyWVcpcnwaaX3sC8aAZ/jHlxirbkS23nsg9Ro?=
 =?us-ascii?Q?KRMt6pRVe/BEQGnsYjB7z3dldS3iNBUvJ/8tq2ZMmivOmxnE1a0mtRUQ4XAj?=
 =?us-ascii?Q?+kjSWQdnwlSdvlYqLM9QfP5sxX+JznLIgTHY3rAh/J0VHVrGvtQhmR5Te0YW?=
 =?us-ascii?Q?Zuw0Rb3lv8FUgGGvoLCmQym/mJ6h/9hq4luNIvsZugkCObqBwEZvUu808WYF?=
 =?us-ascii?Q?V3fGbPLfDx9DManSmnOC6Gjz6EhjSsYIMFLOAUi++60+wnEc8cVhi09GZTQr?=
 =?us-ascii?Q?FC5m/TsQGaDRMqH02suRyNJ44p3stZ1gNyilniC4xNHBBuqfdrsqGMlMzZ+q?=
 =?us-ascii?Q?E2mdl27l/nR3XoITFpB9mZ8nmpGpqnO2mvNJaX+6xzvVMXKD8mg3LDF0NuwJ?=
 =?us-ascii?Q?IZtVwMAACllxmyEkbUmmGGiynk5OncaJdF2NgPJSneZfMx+Pb7HqdVqstShi?=
 =?us-ascii?Q?sgxd/nwETnVCQ/VCaOiWPD/KQscBHopsAyMncK9wsrSM43WT4h/1dbmV9sW5?=
 =?us-ascii?Q?crb3DKbPQt+OkYSWHP+s7WYu6anPLfZHtfESd7Lpy8mgeOi7uG6Ea9eVYQi2?=
 =?us-ascii?Q?gox+HpThRWdy4C0CkwCaV+m7tZRDRhD1kOfVzUnylOMeCPHgxcm0uc/IuCFk?=
 =?us-ascii?Q?uKtWBIMT58KSkJTf8d8ikxWFf08W1+MzRNx3kBbW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bcf0da6f-aa02-4b7e-11e7-08dac3a86999
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4839.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 05:48:52.1313
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mRcW2LNtOXc53XKpW1LWWBMwl1w/to+mpYj1IxeRllV7Kigu4VFK+ROAFLnSt+eSgjV3qq7XLTo9MWCsZVfoEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5293
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Joanne Koong,

On 2022-11-10 at 10:37:36 -0800, Joanne Koong wrote:
> On Wed, Nov 9, 2022 at 7:38 PM Pengfei Xu <pengfei.xu@intel.com> wrote:
> >
> > Hi Joanne Koong and net developer,
> >
> > Greeting!
> >
> > Soft remind: "WARNING inet_csk_get_port" is found in v6.1-rc4 kernel.
> >
> > And first bad commit is: 28044fc1d4953b07acec0da4d2fc4784c57ea6fb
> > "net: Add a bhash2 table hashed by port and address"
> >
> > Reproduce code from syzkaller, kconfig and bisect info are in attached.
> > Full information is in the link:
> > https://github.com/xupengfe/syzkaller_logs/tree/main/221108_215733_inet_csk_get_port
> >
> > Thanks!
> > BR.
> 
> Thanks for your email. This has the same root cause (handling the
> error case when connect() fails) as the issue discussed in this thread
> https://lore.kernel.org/netdev/20221029001249.86337-1-kuniyu@amazon.com/.
> After consensus is reached in this thread, I'll submit a follow-up
> fix; I'm hoping to submit it by the end of next week at the latest.

Great! Thanks for your link!
And hope the repro.c and above info is helpful.

Thanks!
BR.