Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Nov 2022 07:26:19 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Liu Shixin <liushixin2@huawei.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kobject: hide illegible sysfs warning of kobject_del()
Message-ID: <Y23rC0N1cL2LQpyF@kroah.com>
References: <20221111065807.3278713-1-liushixin2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221111065807.3278713-1-liushixin2@huawei.com>
Precedence: bulk

On Fri, Nov 11, 2022 at 02:58:07PM +0800, Liu Shixin wrote:
> Some consumers do not care whether kobject_add() succeed or failed such as
> irqdesc. They call kobject_del() all the time even if kobject_add() failed.
> Then kernel will report some illegible sysfs warning like this:
> 
>  kernfs: can not remove 'actions', no directory
>  WARNING: CPU: 0 PID: 277 at fs/kernfs/dir.c:1615 kernfs_remove_by_name_ns+0xd5/0xe0

Why not fix the caller here?  Is that somehow not possible?

thanks,

greg k-h