Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Daniel.Machon@microchip.com>
To:     <petrm@nvidia.com>
CC:     <netdev@vger.kernel.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <joe@perches.com>, <vladimir.oltean@nxp.com>,
        <linux-kernel@vger.kernel.org>, <UNGLinuxDriver@microchip.com>,
        <lkp@intel.com>
Subject: Re: [PATCH net-next] net: dcb: move getapptrust to separate function
Thread-Topic: [PATCH net-next] net: dcb: move getapptrust to separate function
Thread-Index: AQHY9OgDJPilDH1/CUmOWEpqQ4wOy644Wb6AgADxvQA=
Date:   Fri, 11 Nov 2022 06:45:18 +0000
Message-ID: <Y23x/PSlybLqaQIS@DEN-LT-70577>
References: <20221110094623.3395670-1-daniel.machon@microchip.com>
 <87eduaoj8g.fsf@nvidia.com>
In-Reply-To: <87eduaoj8g.fsf@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OgU3jnCVefW6PgVmAGZA+7wb93LazdYGQ58ifqUK0fE3/wVWCO6DeDnnq/qr?=
 =?us-ascii?Q?AGVozMQZZN6LX9TnBvlImnwGDWWpJ3mxbxqL+3xyr3k2dSP6LG3kJsgSvdLy?=
 =?us-ascii?Q?CWFwKnrIOHciR0ruI5/eIROMphO60MlGhRoKHbK/UhLn2wGaBeETQyDgCnS7?=
 =?us-ascii?Q?vyEI9xYcTnKfdZb97jrZtPAvvtqaRYwx+ngiThXtlk8F0vTTJm2QElJJj6e2?=
 =?us-ascii?Q?vi2UYS8ZBKBj28txPPnSN/BQ11jLvbIX4Ekoo/hETt33cXqqsgYqtM34vVu4?=
 =?us-ascii?Q?QhZfcTlFy4F6GY+AX14RiffuVjqWExRag+kX9oZISedG/Q6z9JhQs4Reykys?=
 =?us-ascii?Q?iCQzSPpwlNZGEMAemX91C72D7Pcaadoqhemi6RiaZjsowHzqBhTR793M/ZDX?=
 =?us-ascii?Q?fqvBgh1I1E/uTGlJ4WGV7Ut/gwgIP32aTLxRIrjrGo4IS9VursrLyeEz8DC+?=
 =?us-ascii?Q?Xo8hT5eGQ74jdXUiZqcPvbP8Ll9fq2EcZb2JvvMAM5I/SuFxWSpsCoPfdcWf?=
 =?us-ascii?Q?DMJtZjUvqjxD8xWB8CcK8ENzifjdK39pEu6pNrrr52CGwS3VeTPxIxscrYN9?=
 =?us-ascii?Q?O4SdbBY3O+yfmLZFoGzhtEyAZXoLOyN6wtW+YktOlYe/cKeY+ZOXEg8aY0d7?=
 =?us-ascii?Q?wN6gh4oK5Zaovq8AgtNu12gaYRcJndlVn3acv1PskCDoqulO/TyD7jZ8PVVV?=
 =?us-ascii?Q?XV8Ur24xVVmUnkcHO/1IlP0QIXFh3x9nTJac2jkhZoahEjJEo7mYjy7AO4Qj?=
 =?us-ascii?Q?VlkDMhSQByRkcphhMtxu+k5bEVtB+sJlgysaqc++A2C+yhtvFL83IaANofjb?=
 =?us-ascii?Q?tPzDJMwLi080ESUIt2sMPtqmuYjz9/fI7BYExdsVUrGiz0JenMX3E+xsmUMZ?=
 =?us-ascii?Q?rX4slQWVBiXUrkhr8DW7ciX+IMy1AOHRuu3fmXROkuAflFjx71a9ntX1M2Ow?=
 =?us-ascii?Q?dPwQNC5bmfo48mRWy/fWa4JUiXXlCWhH3Bawh1bO+lBDx2O1yEgerkgZUsPY?=
 =?us-ascii?Q?r05alg48jAsycs0YX17xQcQzNU4Q8K/GCVJCDoxQ2lgTei24VTkwCO0ywULr?=
 =?us-ascii?Q?2DQv0tEfqnYMt9KD/LlNupm7+DFdrKZ6mI+gkPS6RrmWNpvWn6HJZCSjwBQF?=
 =?us-ascii?Q?MzVEKvqr+2XEBxZNeGQARWrQ2kJ7aLVMYru+UZCwOzVP24FduP1BVwCXVcWP?=
 =?us-ascii?Q?FrJMA7G+7j8s10O1/PlkFvsf3MinV+Pb5JoioeL0Ox73GhowCIk3DXN0Iniq?=
 =?us-ascii?Q?aeYcqrLS4dMDC1fT446JbYYCZxoOcNwP2AJu3bYjyPfkiJjZYaYIkDJZnDAn?=
 =?us-ascii?Q?H8c9LY4Q9dfZ/TzPDdPUoutMOeF7uXGQ4d6dG+9U8RhBSzi0hEtY4P6wsu7F?=
 =?us-ascii?Q?NOqUD8lp1yysOGB+HSRHxEHaFULherB/bhjZFGh1KD1IehCPaWzLyOTjiVb+?=
 =?us-ascii?Q?fBps4Ng3ZYxuVnzzVbMoZ7NpLOUU4YrusLMXvu6G4KHGgWnKjl6Z5ifAY8Z5?=
 =?us-ascii?Q?VcQsF8hf7yZIGUYc8pgEHL/OTbyoaW1Rz6F+lbSXHWQJ7S8QjejaFTXEB9Rv?=
 =?us-ascii?Q?mBuUPtcWJ7jS1m26q6Gtqwl7ByEZUNgHa8CRw3td9KM2yTXNqk4QqsyNxmBt?=
 =?us-ascii?Q?W58fJNbkrM1eJLlbLpgiep4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5E31ECD4200BBC448C096858C85759D9@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5569.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8e8b28a-229e-4400-d9d0-08dac3b04c2a
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2022 06:45:18.5258
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Nq7ZTyHlUKU3Z8iJbMJJ+i1DkCTjSRi34DRYev2w+/tz2PbeNtVhreJ7oa3rBdTZbSAoXuQc19IWhdX9mua492H/8iuLD+5s6BOxE0NZbx0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4743
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Den Thu, Nov 10, 2022 at 05:30:43PM +0100 skrev Petr Machata:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e content is safe
>=20
> Daniel Machon <daniel.machon@microchip.com> writes:
>=20
> > diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
> > index cec0632f96db..3f4d88c1ec78 100644
> > --- a/net/dcb/dcbnl.c
> > +++ b/net/dcb/dcbnl.c
> > @@ -1060,11 +1060,52 @@ static int dcbnl_build_peer_app(struct net_devi=
ce *netdev, struct sk_buff* skb,
> >       return err;
> >  }
> >
> > +static int dcbnl_getapptrust(struct net_device *netdev, struct sk_buff=
 *skb)
> > +{
> > +     const struct dcbnl_rtnl_ops *ops =3D netdev->dcbnl_ops;
> > +     int nselectors, err;
> > +     u8 *selectors;
> > +
> > +     selectors =3D kzalloc(IEEE_8021QAZ_APP_SEL_MAX + 1, GFP_KERNEL);
> > +     if (!selectors)
> > +             return -ENOMEM;
> > +
> > +     err =3D ops->dcbnl_getapptrust(netdev, selectors, &nselectors);
> > +
> > +     if (!err) {
> > +             struct nlattr *apptrust;
> > +             int i;
>=20
> (Maybe consider moving these up to the function scope. This scope
> business made sense in the generic function, IMHO is not as useful with
> a focused function like this one.)

I dont mind doing that, however, this 'scope business' is just staying true
to the rest of the dcbnl code :-) - that said, I think I agree with your
point.

>=20
> > +
> > +             err =3D -EMSGSIZE;
> > +
> > +             apptrust =3D nla_nest_start(skb, DCB_ATTR_DCB_APP_TRUST_T=
ABLE);
> > +             if (!apptrust)
> > +                     goto nla_put_failure;
> > +
> > +             for (i =3D 0; i < nselectors; i++) {
> > +                     enum ieee_attrs_app type =3D
> > +                             dcbnl_app_attr_type_get(selectors[i]);
>=20
> Doesn't checkpatch warn about this? There should be a blank line after
> the variable declaration block. (Even if there wasn't one there in the
> original code either.)

Nope, no warning. And I think it has something to do with the way the line
is split.

>=20
> > +                     err =3D nla_put_u8(skb, type, selectors[i]);
> > +                     if (err) {
> > +                             nla_nest_cancel(skb, apptrust);
> > +                             goto nla_put_failure;
> > +                     }
> > +             }
> > +             nla_nest_end(skb, apptrust);
> > +     }
> > +
> > +     err =3D 0;
> > +
> > +nla_put_failure:
> > +     kfree(selectors);
> > +     return err;
> > +}
> > +=