Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1804865rwb; Fri, 11 Nov 2022 00:05:16 -0800 (PST) X-Google-Smtp-Source: AA0mqf7hYDSBWihFLyECprd1ae7R8uML1+jkeRF8KWeyZWydrbOTNQ2XPoMES6gQLLrNAx3jJ8nB X-Received: by 2002:a17:907:1388:b0:78d:3be1:8d3d with SMTP id vs8-20020a170907138800b0078d3be18d3dmr996689ejb.304.1668153916141; Fri, 11 Nov 2022 00:05:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668153916; cv=none; d=google.com; s=arc-20160816; b=VsXCObTgaPZl+TZ7bQMF0jhV9f8bF7YMJz1uVU7fz7BQRJQeSh2ruKQ87jeyZDRSaJ I5F+MGrgTsyKK1aAho5V37U7RhdczFT4xgNwEhjRF5Zt6OsxQMuX2HeLBIhKNUMh1P3h /WPqLpI6QB9mjEgfbfP4VWtXmu/QUSOrx/cw6LkdtjEPoBbDxDPu5q0xzNe9ePgk9HGL p2OCDXu0PAq2ACoYAPIW7BhX6V6N49h17wGeQk9/C70V3j+vk9DsIAxF/f1tIvjoNWn8 nLwatM0EuYoohVR62BRdoJI8ocY3uU4VG4vL/u4kRtE7ODjHQxJegCRwZE/qYqxxIq4k EeQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:dkim-signature:from; bh=S0tk9zvEh9i3RpeDgKq2csbzg/78Ce7ScjSDjvtVy4w=; b=G17pA2mCF25yAn4nH1LP2YUVBd9T7eMDJGu7xIKA6Eq3Hpvx5i+G31hc9/dEuFolUM I7UbtUDKoleGe5hO5mxmBoGnvS5i47zTlvcC5oGBpdktC3HBXB190WvewJdGTYKgNfmi +XeuQyM+l88BLosXDPTbbDSiS5BU5V8hge+qmZ5ep97bBl1MeTgnq0A9UqjPLbkbOLCm AEjUfNhyr6XLmJU6I2Gaeu5qwtQlU3wWOFwNseNIt1uS/Aas9ZhtDe+GQfQwW+EVZ44C mmaLjgIPLscfDHDrll0pqVxWL8Md9amGtqIYGeqWBPykq3N5YavtvuUEtNbNrxMs2jn3 Y7vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@swemel.ru header.s=mail header.b=Zhddcina; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=swemel.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d25-20020a1709067f1900b0078df2f22f80si1199298ejr.647.2022.11.11.00.04.52; Fri, 11 Nov 2022 00:05:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@swemel.ru header.s=mail header.b=Zhddcina; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=swemel.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232943AbiKKHl1 (ORCPT + 92 others); Fri, 11 Nov 2022 02:41:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230198AbiKKHlY (ORCPT ); Fri, 11 Nov 2022 02:41:24 -0500 Received: from mx.swemel.ru (mx.swemel.ru [95.143.211.150]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 203C1742FD for ; Thu, 10 Nov 2022 23:41:23 -0800 (PST) From: Denis Arefev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1668152481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=S0tk9zvEh9i3RpeDgKq2csbzg/78Ce7ScjSDjvtVy4w=; b=Zhddcinakf6++7xApnMZ00jdePEv1cov2V1C+QqpTqjIFOM9JLXb5NcfnGH4hTJe8zCow5 bGI4g7sWqjFxa4zHnQmqWsFAgLQbXIa0c7xe+NIL/SyybXERyvAqI8Ph2r6/OsYGtpd83D BID1NE0t4XvProPDAQgl5w1Y5Sn05Bw= To: Alex Deucher Cc: =?UTF-8?q?Christian=20K=C3=B6nig?= , avid Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] nbio_v7_4: Add pointer check Date: Fri, 11 Nov 2022 10:41:21 +0300 Message-Id: <20221111074121.23296-1-arefev@swemel.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return value of a function 'amdgpu_ras_find_obj' is dereferenced at nbio_v7_4.c:325 without checking for null Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev --- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c index eadc9526d33f..0f2ac99de864 100644 --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c @@ -304,6 +304,9 @@ static void nbio_v7_4_handle_ras_controller_intr_no_bifring(struct amdgpu_device struct ras_err_data err_data = {0, 0, 0, NULL}; struct amdgpu_ras *ras = amdgpu_ras_get_context(adev); + if (!obj) + return; bif_doorbell_intr_cntl = RREG32_SOC15(NBIO, 0, mmBIF_DOORBELL_INT_CNTL); if (REG_GET_FIELD(bif_doorbell_intr_cntl, BIF_DOORBELL_INT_CNTL, RAS_CNTLR_INTERRUPT_STATUS)) { -- 2.25.1