Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <900e6177-0a21-e2f5-6c03-81d1dd182c68@linaro.org>
Date:   Fri, 11 Nov 2022 09:26:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: qcom,ipa: remove an
 unnecessary restriction
Content-Language: en-US
To:     Alex Elder <elder@linaro.org>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc:     andersson@kernel.org, konrad.dybcio@linaro.org, agross@kernel.org,
        elder@kernel.org, linux-arm-msm@vger.kernel.org,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221110195619.1276302-1-elder@linaro.org>
 <20221110195619.1276302-2-elder@linaro.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20221110195619.1276302-2-elder@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/11/2022 20:56, Alex Elder wrote:
> Commit d8604b209e9b3 ("dt-bindings: net: qcom,ipa: add firmware-name
> property") added a requirement for a "firmware-name" property that
> is more restrictive than necessary.
> 
> If the AP loads GSI firmware, the name of the firmware file to use
> may optionally be provided via a "firmware-name" property.  If the
> *modem* loads GSI firmware, "firmware-name" doesn't need to be
> supplied--but it's harmless to do so (it will simply be ignored).
> 
> Remove the unnecessary restriction, and allow "firware-name" to be
> supplied even if it's not needed.
> 
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
>  Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ----------


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof