Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Aakarsh Jain" <aakarsh.jain@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Cc:     <m.szyprowski@samsung.com>, <andrzej.hajda@intel.com>,
        <mchehab@kernel.org>, <hverkuil-cisco@xs4all.nl>,
        <ezequiel@vanguardiasur.com.ar>, <jernej.skrabec@gmail.com>,
        <benjamin.gaignard@collabora.com>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <stanimir.varbanov@linaro.org>, <dillon.minfei@gmail.com>,
        <david.plowman@raspberrypi.com>, <mark.rutland@arm.com>,
        <robh+dt@kernel.org>, <krzk+dt@kernel.org>, <andi@etezian.org>,
        <alim.akhtar@samsung.com>, <aswani.reddy@samsung.com>,
        <pankaj.dubey@samsung.com>, <smitha.t@samsung.com>
In-Reply-To: <b766bd0b-aecc-3b9d-27df-2615d648d9bd@linaro.org>
Subject: RE: [Patch v3 3/3] ARM: dts: exynos: Rename compatible string
 property from version to SoC specific
Date:   Fri, 11 Nov 2022 14:52:59 +0530
Message-ID: <010e01d8f5af$340c1a80$9c244f80$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQI8m1Zcdyoy30tr4qXY7cEROuoJ0QEEBFDkAqmi7y0CiBy/9K1Ac1lg
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20221111032337.79219-1-aakarsh.jain@samsung.com>
        <CGME20221111031718epcas5p3df130145b4bb99424fd5aa4addf77ba5@epcas5p3.samsung.com>
        <20221111032337.79219-4-aakarsh.jain@samsung.com>
        <b766bd0b-aecc-3b9d-27df-2615d648d9bd@linaro.org>
Precedence: bulk

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=5D
> Sent: 11 November 2022 13:41
> To: Aakarsh Jain <aakarsh.jain=40samsung.com>; linux-arm-
> kernel=40lists.infradead.org; linux-media=40vger.kernel.org; linux-
> kernel=40vger.kernel.org; devicetree=40vger.kernel.org
> Cc: m.szyprowski=40samsung.com; andrzej.hajda=40intel.com;
> mchehab=40kernel.org; hverkuil-cisco=40xs4all.nl;
> ezequiel=40vanguardiasur.com.ar; jernej.skrabec=40gmail.com;
> benjamin.gaignard=40collabora.com; krzysztof.kozlowski+dt=40linaro.org;
> stanimir.varbanov=40linaro.org; dillon.minfei=40gmail.com;
> david.plowman=40raspberrypi.com; mark.rutland=40arm.com;
> robh+dt=40kernel.org; krzk+dt=40kernel.org; andi=40etezian.org;
> alim.akhtar=40samsung.com; aswani.reddy=40samsung.com;
> pankaj.dubey=40samsung.com; smitha.t=40samsung.com
> Subject: Re: =5BPatch v3 3/3=5D ARM: dts: exynos: Rename compatible strin=
g
> property from version to SoC specific
>=20
> On 11/11/2022 04:23, Aakarsh Jain wrote:
> > commit =22752d3a23d1f68de87e3c=22 which adds MFC codec device node for
> > exynos3250 SoC. Since exynos3250.dtsi and exynos5420.dtsi are using
> > same compatible string as =22samsung,mfc-v7=22 but their node propertie=
s
> > are different.As both SoCs have MFC v7 hardware module but with
> > different clock hierarchy and complexity.
> > So renaming compatible string from version specific to SoC based.
> >
> > Reviewed-by: Tommaso Merciai
> <tommaso.merciai=40amarulasolutions.com>
> > Suggested-by: Alim Akhtar <alim.akhtar=40samsung.com>
> > Signed-off-by: Aakarsh Jain <aakarsh.jain=40samsung.com>
> > ---
> >  arch/arm/boot/dts/exynos3250.dtsi =7C 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos3250.dtsi
> > b/arch/arm/boot/dts/exynos3250.dtsi
> > index 326b9e0ed8d3..98105c64f7d9 100644
> > --- a/arch/arm/boot/dts/exynos3250.dtsi
> > +++ b/arch/arm/boot/dts/exynos3250.dtsi
> > =40=40 -485,7 +485,7 =40=40
> >  		=7D;
> >
> >  		mfc: codec=4013400000 =7B
> > -			compatible =3D =22samsung,mfc-v7=22;
> > +			compatible =3D =22samsung,exynos3250-mfc=22;
>=20
> No improvements. Changeset is non-bisectable. I said it in v1, then in v2=
. So
> now third time... Don't send a new version if you are not going to fix it=
 or
> resolve discussion.
>=20
My bad, misunderstood, now I understood your concerns around bisectability.

I hope you mean the below:
------
diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Document=
ation/devicetree/bindings/media/s5p-mfc.txt
index cb166654fa81..734e53445eb5 100644
--- a/Documentation/devicetree/bindings/media/s5p-mfc.txt
+++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt
=40=40 -10,7 +10,8 =40=40 Required properties:
   - compatible : value should be either one among the following
        (a) =22samsung,mfc-v5=22 for MFC v5 present in Exynos4 SoCs
        (b) =22samsung,mfc-v6=22 for MFC v6 present in Exynos5 SoCs
-       (c) =22samsung,exynos3250-mfc=22 for MFC v7 present in Exynos3250 S=
oC
+       (c) =22samsung,exynos3250-mfc=22,=22samsung,mfc-v7=22 for MFC v7
+            variant present in Exynos3250 SoC.
        (d) =22samsung,mfc-v7=22 for MFC v7 present in Exynos5420 SoC
        (e) =22samsung,mfc-v8=22 for MFC v8 present in Exynos5800 SoC
        (f) =22samsung,exynos5433-mfc=22 for MFC v8 present in Exynos5433 S=
oC
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos32=
50.dtsi
index 98105c64f7d9..a2d6ee7fff08 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
=40=40 -485,7 +485,7 =40=40
                =7D;

                mfc: codec=4013400000 =7B
-                       compatible =3D =22samsung,exynos3250-mfc=22;
+                       compatible =3D =22samsung,exynos3250-mfc=22, =22sam=
sung,mfc-v7=22;
                        reg =3D <0x13400000 0x10000>;
                        interrupts =3D <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
                        clock-names =3D =22mfc=22, =22sclk_mfc=22;
-----

Where mfc-v7 will be used as fallback for the older kernel which might use =
new dtb.

Let me know if this is not what you meant or am I still missing something?


> In cover letter you said =22Addressed review comments from Krzysztof
> Kozlowski=22, so please explain me, how did you resolve my comments about
> fallback for this patch and for bindings patch?
>=20
My bad, I just explained the misunderstanding above.

> Best regards,
> Krzysztof