Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5a902810-2e72-9021-e189-a1cd2aa6f77f@suse.cz>
Date:   Fri, 11 Nov 2022 11:25:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: Deprecating and removing SLOB
Content-Language: en-US
To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Conor.Dooley@microchip.com
Cc:     cl@linux.com, rientjes@google.com, iamjoonsoo.kim@lge.com,
        penberg@kernel.org, 42.hyeyoo@gmail.com, willy@infradead.org,
        roman.gushchin@linux.dev, pasha.tatashin@soleen.com,
        torvalds@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
        rkovhaev@gmail.com, akpm@linux-foundation.org
References: <b35c3f82-f67b-2103-7d82-7a7ba7521439@suse.cz>
 <CA+CK2bD-uVGJ0=9uc7Lt5zwY+2PM2RTcfOhxEd65S7TvTrJULA@mail.gmail.com>
 <efa623fb-686f-072e-df0d-9f5727ae1b1f@microchip.com>
 <a0201035-8cd3-f8bc-7db3-4d011cd2c35c@opensource.wdc.com>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <a0201035-8cd3-f8bc-7db3-4d011cd2c35c@opensource.wdc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/10/22 00:00, Damien Le Moal wrote:
> On 11/10/22 02:57, Conor.Dooley@microchip.com wrote:
>> +CC Damien
>> 
>>> There are some devices with configs where SLOB is enabled by default.
>>> Perhaps, the owners/maintainers of those devices/configs should be
>>> included into this thread:
>>>
>>> tatashin@soleen:~/x/linux$ git grep SLOB=y
>> 
>>> arch/riscv/configs/nommu_k210_defconfig:CONFIG_SLOB=y
>>> arch/riscv/configs/nommu_k210_sdcard_defconfig:CONFIG_SLOB=y
>>> arch/riscv/configs/nommu_virt_defconfig:CONFIG_SLOB=y
>> 
>> Saw you were not added to the CC Damien & I know you don't want your
>> baby broken!
> 
> :)
> 
> I set SLOB=y for the K210 as the config help mentions it is a bit more
> efficient in low memory cases. I did run a few times with SLAB and it
> was OK, so removing slob should not be a problem. Can check again.

Thanks, but please check with SLUB, not SLAB, if possible.
Disable SLUB_CPU_PARTIAL (default y on SMP) if you want to minimize the
memory usage.