Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <69885e9d-d26a-4a93-8484-c19d7ed23121@wolfvision.net>
Date:   Fri, 11 Nov 2022 12:52:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [linux-next-v1 1/3] arm64: dts: rockchip: Fix gmac phy mode to
 rgmii on Rock 3A sbc
Content-Language: en-US
To:     Anand Moon <linux.amoon@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>
Cc:     Chukun Pan <amadeus@jmu.edu.cn>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221111094238.1640-1-linux.amoon@gmail.com>
From:   Michael Riesch <michael.riesch@wolfvision.net>
Organization: WolfVision GmbH
In-Reply-To: <20221111094238.1640-1-linux.amoon@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mms2c1ljdkljcmVuelB0V3cyUjgzd0VQb1JWUFcrZE14QmlJTFJ0Y3hkVmlZ?=
 =?utf-8?B?bUVoZzlvdEtqNE5qVDVTVzNkbWdXQThONlhpbnZDdjMvbjlOLzVVOEhzL1BM?=
 =?utf-8?B?ZTQ4dVBKT0V1cEEyaWJVZHJNT2Y2cjIvMW9tYTVmQW5Xa3FRbDFuQlhvbzBv?=
 =?utf-8?B?eXJhWkE5Q29BT3dRK3o3VE9reTVjRHJQaEFLNytKbWpMRytVdVFtVDZCTDdM?=
 =?utf-8?B?ZGZkdFpzTDRtU09PK21IS01FNy9rWEpYQUhsZUkzelY4U2trS3g2Y1lQUnlC?=
 =?utf-8?B?SHF3TjFpcWdEVDJnM1U2U3FxNXNXRm1BbWxnUDZFUTF6ekNzelFzenU2MC9J?=
 =?utf-8?B?WitLdVZpU1hUdlJ0eTgvRGZIdTRiTGdGb0pKVHRGQjIzVVdleHhuQTd4R3Bt?=
 =?utf-8?B?YVRFeUpBVUxVYXFyRXYrK3NKVWZnNTArRVJ6NGpjU3p4VlQzelhWbHU3SXFD?=
 =?utf-8?B?K3E2bFBnZGE2Y004NG56OWtNKzJrWVp3ckR2L2FaaVphdXllRVhScGJzZHFT?=
 =?utf-8?B?WCs4TTAxaVBvRUNHR0ZDUDQ3ZWI4R0QwZkljSDc4KzJDQmkvdFQwNDJGbzBD?=
 =?utf-8?B?TmRRT3Q3aUJCSnhSajJ6aTVyUlpPM0hxUUdUd3R3OHYyRjlTbysvVlhEM1Bi?=
 =?utf-8?B?dnhRcjhDVlhQc2kvR3Z2R0JjSElQOWd3U2hIYWMzY1ZRN3VOeXhTQlhkQ0xJ?=
 =?utf-8?B?Q0ozL2NqMWhHeEt0MkJwVU42MzdsQTFFdCszN1g1S0dnNllCNXNuNUM1OWMw?=
 =?utf-8?B?UjFTVTZQY1ZqWXpZZnM5cTk4NXAvMXZla2MyejF1SDIyV1dNczdMUTIvMlYr?=
 =?utf-8?B?THVzUjYzcnpRSWlHR0ZidmVjZVdhT2tuSThYcTkwcTRWZi8rNmhCMnhoVCtp?=
 =?utf-8?B?ZXFaOEpqbkpaVHJ5Z0NVTWZUMnRDQzRLTkM4RVNjUVN3ZmlxWTBjekZEa2lv?=
 =?utf-8?B?QW51M0Z6cGdUd3FyVk9iaUhMMVYxSVk0WW9NMHlGdEFxd3YxZHg0UHBuMGlx?=
 =?utf-8?B?cDdwdGJNZWUrU3VsbEs0TDAzQ1l5YWdNN0RDTitwVndtSkY3cmduRWpYRDFH?=
 =?utf-8?B?T0Zienk1NkM5TlgvWmVIZEk0aGw4cVcwcjZtTW1adTd4YnNJZHAzVFNhUk1D?=
 =?utf-8?B?YjBSZEpZUVZYS1lZSk00enlvWE91Nk9vRHg4d1FHZzJJVWxGOGVmSllQUHBV?=
 =?utf-8?B?T0FreEJJTVF6SmcvWHdWLy9takczaDlFaHVNcE0yWGhHTzFvOHdtZVJyMW5Z?=
 =?utf-8?B?VzJnTWJnU29NQkVOaHdUa0pWVTVZODNCWTk3YWNCb1VEM2tnWFdtRjZYbTNF?=
 =?utf-8?B?T1o3WXZNN2RMV1B5RmozMjVkdVdrbk8zTmtwSnRPME14VzlXU0xUcmpnODhU?=
 =?utf-8?B?UVUyM3ZoSTJBejQ3alZlTzN0VnFDRUlyWGJuUHNHVEZ2bVMzQ0RJSlhNZWg1?=
 =?utf-8?B?U1kzMWl6d0dRNkpwVy94R1cySm9FV2NmRHd1QStQSmpFQzNWenRDcTFtNjZm?=
 =?utf-8?B?TStYMVJlY0V0REUxMmxUd0JrQUt4K0tZN2h1SElPVUlBWGFmMjdtWk5Oamxi?=
 =?utf-8?B?T3V2WUxaNWR1cVpYalprNXpCVitNZEFvM2NPZU5MeU9FZ0tXT2I2YTcyeXhN?=
 =?utf-8?B?UFZHSHVDa3pMc2VrV1ExSGx5OFNJVndEVUlMemtUMG5xY1IrQ0o3S3Z2MW9M?=
 =?utf-8?B?SVRmWG42dWY4NTFIRlpUNHUvYzYxMkZ0SFRzaHo5R2d2aThqMVVPNFdrZmdk?=
 =?utf-8?B?SHovK0hmSVdKRU5VSy82bk1ZK3NrdUVubWhvN01CMkRVZXc2V1VQS0Q1Tm9H?=
 =?utf-8?B?c1dRNkZiK3d5Vk0zalU0NGxQQ3lpcWdXSEVrbDk3ck42eXJzN0Q0SmdWTVpX?=
 =?utf-8?B?S2FORjJ3SklBTjNpcU9aejlpeUVZZTByOWlLL2w2bWVGaVZlRGF5Znd5c1hr?=
 =?utf-8?B?TXVYcmRRQnp0cGR2ZW1MdzdKbzdzSnJHdjQwUHh1bUFldWlCZUt6eXNMRnFE?=
 =?utf-8?B?bmIyZVYwNEk4N2ZKRHJqUEhJWGFWWGxFYXdlNEt2c01FTmIvbFRQcmZmZGMv?=
 =?utf-8?B?LytVdkprd0JaaUM4dklBbkgzYUE5cVA5NkVuN1VLSUV2NVFNSjdzN0NOWTh3?=
 =?utf-8?B?ZGpEbTkyMG5nNk9EeHZXRTRRUEV1TDYwcmgrNUtUaTNFdnBPd3gzYXlTNlZp?=
 =?utf-8?B?VkE9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fe81a1c-083b-44ec-1f6f-08dac3db3480
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 11:52:28.8651
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0wWl2Fo5bnwRMHJ5t0sISBZKAMLMB0hnhUJICm2/FxLLUlcUyxgzItUj1xwatS+4uBXVQxZ/LK2qTCUHvAsLi1gvH6T/rpLUiZcol4Ue3vU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9657
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Anand,

On 11/11/22 10:42, Anand Moon wrote:
> On rk356x ethernet phy support reduced media independent interface (RMII)
> and reduced gigabit media independent interface (RGMII).
> So set the phy mode to rgmii.
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index ea74ba32fbbd..72e410e3aca8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -253,7 +253,7 @@ &gmac1 {
>  	assigned-clock-rates = <0>, <125000000>;
>  	clock_in_out = "output";
>  	phy-handle = <&rgmii_phy1>;
> -	phy-mode = "rgmii-id";
> +	phy-mode = "rgmii";

What are you trying to fix here? If it ain't broken, don't fix it. I
would assume if you switch from rgmii-id to rgmii you need to adjust the
rx/tx-delays, otherwise this change does not make sense to me. Feel free
to point out what I am missing, though.

Best regards,
Michael

>  	pinctrl-names = "default";
>  	pinctrl-0 = <&gmac1m1_miim
>  		     &gmac1m1_tx_bus2