Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22a00fd8-2489-d803-bea4-e624c355a984@amd.com>
Date:   Fri, 11 Nov 2022 12:57:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] drm/amdgpu: Fix memory leak in amdgpu_cs_pass1
Content-Language: en-US
To:     Dong Chenchen <dongchenchen2@huawei.com>, airlied@gmail.com,
        daniel@ffwll.ch
Cc:     alexander.deucher@amd.com, Xinhui.Pan@amd.com,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, yuehaibing@huawei.com
References: <20221110143314.708434-1-dongchenchen2@huawei.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20221110143314.708434-1-dongchenchen2@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm9uUHBXaTBmZ3h5dFYyNkxCZTBMb01wWTUwQVdjcVZIYXV3QnFKa0Y0UGZq?=
 =?utf-8?B?REZpOHh2WFR6bHRjVkE5QWFLdkJqYkQwOTVFMC9ydVBCVm1oOUlJMGhURmNN?=
 =?utf-8?B?UjJ6RzlHNWxoNWhCczd2aHhERVk2a0VCNGF3VGNnU3VzTStiTzVHa1dXbzlX?=
 =?utf-8?B?d25KNFhoYXUzWWlnaTFmWGdRb3VxLzAwTGNQelJtS1pyK0xEVUVTTkRYTXJU?=
 =?utf-8?B?aVhxZ3NPdHBueHk5K0pEaXF4RkJxQUNOK1FFMGRKOXVoaTNxMlpDcEl2RzVn?=
 =?utf-8?B?c3lyczhGcXlqdFh0NnZPbUFWT3lKUC9ZU2E0QUk4akxnRmRVaXNJMkUvTXJi?=
 =?utf-8?B?RUZFSG1zQUlPQUVRUEJQU0M4WjRRUnM2ckdFL0RyM2VNNFNHL3QxMXBQWjha?=
 =?utf-8?B?ZnBOUDN5eGtmTWRKQXBPOUo5dEdYem9ac01icUxiaEJSTk5sVEJCTUtzb0p6?=
 =?utf-8?B?aXZaOUNHZ2dZYlFzTjQwbXJkeVRJNXBSK1FqNmJzdlQxaENvcm0rMFNMMjdS?=
 =?utf-8?B?Y216NjhIcGFzNmRQVmY5RjdYS3ZMZnk4czNDcUNFNUZsekN3V0grKzFYY0Ni?=
 =?utf-8?B?SEVDQ0h2VlF1cnoxTFQxNkZOZ0JHTDlseEx6WFgwUWdEcnE3LzBteWJUS0RQ?=
 =?utf-8?B?enQ0SEhZKzFuN2xpOVA4MmRuK1hRM0VTWFJDQXIxd1R3OFEwZmRrR01vSVVV?=
 =?utf-8?B?R3Q3ZFhxZmZ6aS9yUEMzeGZZOCtCalpUczlJbUpSWXBWbDlQdTczSmo5YmNy?=
 =?utf-8?B?YXdiWmgzSUF6NytPM0RDZVBjeFV3R3V3WTFoMGs1N1RIenEyQUNLMzB1NEZa?=
 =?utf-8?B?dGNHS0I2b3RCM3IxOHBsZ0t3NWJVcmQ3QUhpNmh2aEd1WkNjazVzWFpMcExD?=
 =?utf-8?B?R29oRElHd2lBSThLMkh0azJ4T2FxRHI1OWhPMUFUU3IxdXp3a0xkaU13Q2ti?=
 =?utf-8?B?djJQaXVJeThMNVlhZEpHL01FL2pERzE5dXh5cHExbVdESWEvbmxyOHYxS0Zp?=
 =?utf-8?B?S2FXZVVRbFY0eGwwd3JLWFV4SUFPVXJjbUhTeEJjTXM4WmRsUEgvNERZOW80?=
 =?utf-8?B?Y2hGMTl6OFVKSGlwT3FsZzVJR0ZTYmhXMktFbEFYRml4R2F0bUc4WDErUDFX?=
 =?utf-8?B?dS9CdUtpYzF4VndBYS9HenhGZnEza0dmSmJUKytjdktuSlo3N0NVRUZFbWlj?=
 =?utf-8?B?cUxPaTlkcUxkcTUwazlBU201Q2VIWkRxbkRFWWRDMmhaazVjNzhFWHBuc1RE?=
 =?utf-8?B?Vi95SkloNHBNallhVTdRWExOb2JPTDhoUkI0L2RhTndtUzZWRG5Xd3FjRTRX?=
 =?utf-8?B?WDkrNVJLQTl0dFdRbHR0UTZNZDNDTVVweXZZM2RxZEM0OVNzYmlCbFF1Mys0?=
 =?utf-8?B?ZmlTazdTbE52NXVoSUVNd0Q3a1ZNaDM0TG9kaWZ3cDBDb051TnVWTzJUZ3VG?=
 =?utf-8?B?ZjFjNGxwY3JuZFZDUUxiM0srWlNhd0V1RUk5ejdHaHoxVDRidWhDM0JGTy9o?=
 =?utf-8?B?WE1yK1RuaFJnckFGSTRrZml4Q2ZweVVDYnFTbTJuRUpvcXIzTG9VZ2dicG1I?=
 =?utf-8?B?WHpwU1RZYWpvN293MXJST3ZPR3lTYjJFc2FObXVLR3lPQXQyR3NjbjBuaEU4?=
 =?utf-8?B?N0gzd0VQeG8wbTlEOE9QWENTRlBXM004TWQxd3JQSjBBUVlqTlJXbUt0bk4w?=
 =?utf-8?B?cHdkbmduU29qdk0yTmxJT2RjSllWRFg0K2NnOVZwMWlpRFNLbUJYMjN0aGJZ?=
 =?utf-8?B?UEUrMUFPMklrSGNmRVp1Q2Y4ODVFVWR1MzUvSkFYM3BxNVFBRDc5UnVhclN5?=
 =?utf-8?B?MWZsOExaQjFwSFJHQWVkNXZNcURUMXplZmtNRDVqVVB3VlFSNnV2bkdkRHlX?=
 =?utf-8?B?R1N6UnR1V3pnZDViSWcwUGlNemlkRGwzY1dEbTVMd0NibVgrUXJwWDAzckdx?=
 =?utf-8?B?d0FYczNkbXFkWUZYa3JkSGp5YjNBMk04dFpPMjVVNGZKVDFhVDhYUkJWclU1?=
 =?utf-8?B?MnVvMDVTM2h0ak1oTk42bDV4U3NBVVBaUTVheWVjbHoyajFTWGNPSkZRS1pZ?=
 =?utf-8?B?TC9XdnJnZDl5QjA2b2pFa3Vrb2N2Z1VkODI2aG5IL3NlS1lBUHVIM0N2cWZ3?=
 =?utf-8?B?VmZiSS9oRTF6YlBLdk9iUGw3WVZIeXg4MGs1cUJrck9wQ2lKWUJWa1dTOEdy?=
 =?utf-8?Q?HZqd4os17wkd9NoRA9jLRZ+/MlyWqFyHFezzUZ+5zPou?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4915db9c-72bf-4886-8000-08dac3dbe796
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 11:57:27.8563
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +p5pecM9XUALHVHu/zoJBCsVfRNaqSxcVizvXZbPZKhCTw8GIJV9Lvyz4OgyMAxw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5920
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 10.11.22 um 15:33 schrieb Dong Chenchen:
> When p->gang_size equals 0, amdgpu_cs_pass1() will return directly
> without freeing chunk_array, which will cause a memory leak issue,
> this patch fixes it.
>
> Fixes: 4624459c84d7 ("drm/amdgpu: add gang submit frontend v6")
> Signed-off-by: Dong Chenchen <dongchenchen2@huawei.com>

Good catch, thanks. Patch is Reviewed-by: Christian König 
<christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 1bbd39b3b0fc..0e24d6b80e0b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -287,8 +287,10 @@ static int amdgpu_cs_pass1(struct amdgpu_cs_parser *p,
>   		}
>   	}
>   
> -	if (!p->gang_size)
> -		return -EINVAL;
> +	if (!p->gang_size) {
> +		ret = -EINVAL;
> +		goto free_partial_kdata;
> +	}
>   
>   	for (i = 0; i < p->gang_size; ++i) {
>   		ret = amdgpu_job_alloc(p->adev, num_ibs[i], &p->jobs[i], vm);