Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Charl Liu <charl.liu@bayhubtech.com>
To:     adrian.hunter@intel.com, ulf.hansson@linaro.org,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     shaper.liu@bayhubtech.com, chevron.li@bayhubtech.com,
        thomas.hu@bayhubtech.com, xiaoguang.yu@bayhubtech.com,
        shirley.her@bayhubtech.com
Subject: [PATCH V3 1/1] mmc: sdhci: Fix the SD tuning issue that the SDHCI_TRANSFER_MODE is cleared incorrectly
Date:   Fri, 11 Nov 2022 04:23:14 -0800
Message-Id: <20221111122314.307-1-charl.liu@bayhubtech.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bMyUvEv/rB4oYtgsx+Lri6uJ+IdgigKfR5ydqgPjxsQym894QrMQOaZGhsHu?=
 =?us-ascii?Q?30kNwmLgaEU4snh22yjo0WMYnkP3FNx++HVj2U4bLIFUBXOo1U0nyrVd4Zhf?=
 =?us-ascii?Q?FjTOSuCBO1zk/42U2EzqTp1/RqWweOH+ug64qxZe9zYR0zsK9zccGnt4wiX6?=
 =?us-ascii?Q?b0+oQUw4EmltzaW5WktDrJUaHWXoMO7uuAgDMtulNMbgvwSDq/BOzDb3LKq5?=
 =?us-ascii?Q?4jWdiz/RvgnrLdOuf9wa0uhx8KDkqqMQN3BpHO5qSd3/kpmJeYYKNnKqVpa5?=
 =?us-ascii?Q?IoBolOONQfZIl8Qd0E+c0U0pOb4dDpkUFA1mG0b6uSWWZ/GHPM43Hf7lmiUJ?=
 =?us-ascii?Q?vo4KZGYcLskzzzBRpwP6m6H/AXuqSk/sFWKRCB0HbQIi9bMHSvGqduJedPpy?=
 =?us-ascii?Q?UqBRL1iqWa+iT+LeO1s0ercxEpB4g1To8j1hovepeDdCPI4hz50Nn379E+zy?=
 =?us-ascii?Q?izNJzK7+IeFAwddnINGhJj+tC8P6E3KA4ZEmuhC1fOrPYgY2Hopx0L0jNMw2?=
 =?us-ascii?Q?wLm1xSXvFga3ncr/NhRpyPoIZlL1Bi7gEOG/L8Le5FZ0lyY/+/Ig/ruSzSex?=
 =?us-ascii?Q?m/xJnpYHYD9w+BDujQuxkfYZAg/nFi5k0DvP+0kZ0UY3d4NHf7Y0YtUpMi2K?=
 =?us-ascii?Q?00KSQ0c6qe7dTBsouO4wyDE+f8/eVxBaWgdfuNSrKHmhw12tTe6/SVqok1lE?=
 =?us-ascii?Q?fBP4aoWg0q5iY1podFNmWH9GZWc6eimfaYdaZJz+62T+iua+rIQuqdC5P3p/?=
 =?us-ascii?Q?samh3l22vLGW5k8zZrI8bPhCQXKQk3T5ZGLR81GpFIboJ/oMmlW6am8actwI?=
 =?us-ascii?Q?URqwvBXg1TS6c95lcy3C+LWiwtatc3hRX9HXD2Z3X2vvd6KB7Trn6KATLrgu?=
 =?us-ascii?Q?rbzDDkHYPaQUhYv76qXZkbElohGVTHh/y2mT2L+2BBb9Vdgb1UnwcgPiOh3y?=
 =?us-ascii?Q?gXxrdWRXYjuc4SC9W4x67lGs3d2mPR6eQx5u1X2vkoPrjL8YeKKd6gzDbfV4?=
 =?us-ascii?Q?jFdxJtpi0O2S5F0srmZN6DylGrn4W0CVSaIE611xEOBSwp6fSUUE0T8HTy3n?=
 =?us-ascii?Q?f5fLrmJtwxcUp8nMkgAn4WHP2Lm1/XM1KcNyWgG8hm5vjznlNB6EOc2x7Cf5?=
 =?us-ascii?Q?FQcs6DyZTwxjQ5RIHLOw960EoB7rbt2jBUoGpwpchSDZPHHyN8pWXWjbGkWT?=
 =?us-ascii?Q?CJ7dy2pGFq57D8z2rVS4tUHfC42Y0d29JJ1EBuMyxoQtZBFAcVLq64j8occz?=
 =?us-ascii?Q?pqsyaiRmECImCRhSD/2cs8TANuVVQO8LbjUkNgnN7BglV4e+k7zrx1vXt8a6?=
 =?us-ascii?Q?YM8r/w/pA9rqYOTimIann4EEkT4ouFpuknVZnYRMHQSBXcq0MqQbN42WKg0A?=
 =?us-ascii?Q?Pjkz3F1ctbMfYHI0mVMv4KbF7l/ku4aWZnM1WVMpX9SdYNHjF5QgnZkUonCG?=
 =?us-ascii?Q?UmVM9WeILu7foayYaCpMXNDdRa31wiueCYxvwCAMJBG3b3iPd9mhtDYA267H?=
 =?us-ascii?Q?fYhbu/aOdWO/lbQ7XM+ZZGgqzN82rFX3qDJFSidwTFrb4RN3IvtSsG6Janwt?=
 =?us-ascii?Q?eXEZcN/w7eSXONh6ZesMebxRmLzBDWtEyfFKRlJxRCSRbh4K5OdbmIdW0K8Y?=
 =?us-ascii?Q?IkxfzFU16vi64TTdMbnxkOwF1mFqTvvhUffS3rXXYEt9x36yLfSMJpswLo0k?=
 =?us-ascii?Q?zrsFhQ=3D=3D?=
X-OriginatorOrg: bayhubtech.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cab2b696-d6d2-4680-faef-08dac3df8ab3
X-MS-Exchange-CrossTenant-AuthSource: MN2PR16MB2781.namprd16.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2022 12:23:30.1958
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0a7aae2b-8f2e-44df-ba2f-42de7f93c642
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rgdgHnQQl4GoSV50DPjVBKl6gP/rF8qGPnJCdyk1yIP8OqJbOyOxE4A1FdRCLzMIUDt3gmivNBk2w6uZsJF6dxJfrYNrErzEs7bMOFkAOlI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR16MB2261
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When cmd->opcode == MMC_SEND_TUNING_BLOCK, the SDHCI_TRANSFER_MODE
should also be kept

Signed-off-by: Charl Liu <charl.liu@bayhubtech.com>
---
change in V1:
Keeping the SDHCI_TRANSFER_MODE when cmd->opcode == MMC_END_TUNING_BLOCK

change in V2:
add the mmc_op_tuning interface to judge if the opcode is tuning CMD

change in V3:
cancel the redundant code
---
 drivers/mmc/host/sdhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index fef03de85b99..98ee688de50d 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1465,7 +1465,7 @@ static void sdhci_set_transfer_mode(struct sdhci_host *host,
 		if (host->quirks2 &
 			SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD) {
 			/* must not clear SDHCI_TRANSFER_MODE when tuning */
-			if (cmd->opcode != MMC_SEND_TUNING_BLOCK_HS200)
+			if (!mmc_op_tuning(cmd->opcode))
 				sdhci_writew(host, 0x0, SDHCI_TRANSFER_MODE);
 		} else {
 		/* clear Auto CMD settings for no data CMDs */
-- 
2.32.0