Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2124149rwb; Fri, 11 Nov 2022 05:29:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf5y7eIJexmVpdVF0b5jKV76MbHZ+AnxHM78Qzqy2L/mE6Y3+kvBkcHCB91Bu1bEtArv50WK X-Received: by 2002:a05:6a00:180f:b0:565:af12:c324 with SMTP id y15-20020a056a00180f00b00565af12c324mr2615467pfa.66.1668173378042; Fri, 11 Nov 2022 05:29:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668173378; cv=none; d=google.com; s=arc-20160816; b=JfRymXeBO6SoMNGPuw2nBVevRqvGZw+PfqfaS2NLZGs2dweTVvlErjq61uyTUxnvhd M5J5wAV9+Wfv38tuxOvBkrh4hKriF3+rnKX6uXe0ciJRyjs39bAK+gbAsi3AL6IP5PoU pchEH1eVzwWVmDCGLNKhdS6DeY4a0AG9Tx77+D9z7pX6gfpb0lHwxK/YDxRBzSB/Fr0O iaUQyBfkFaEANR5Atncr/o7NCGy5UpTUoZBIhufTuS94GufphNzdEVCD+RoJTaFauZCc nO36Rmap9gZxzUP1aEN7l5uk2BXW3d6qkFaKPZZ8xgeIVOhU2YQYI7fAOgysifzw/Mfz pCBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=kvgf6SmSr7NId4sf36+Z8/Dtt5XMs75jbShL/0DAieQ=; b=htjP7ltmn/2teAUqellCp/rMZWogaVSwoCeyukYN3/jmvk/+ZEGocD7pT672j4H+4h NrraWJbbizg/Toy0k4gEmyZ2GtlL9NEUfUsL68gTIy6hi5tJUxblkzYhN9E4jYP+xJFB /y62hAnj5iboz+1fsJaxtr7qa8efhBLDG/gjQiGNinszxOd535IhF9MvcHSf68Of766m 3qk+diIrmhC3VRSqXQ7RLFiE5lOHTX30YIZv7eF04o83Nu2sqqbkfHPFFXB4ZOkax0Ut /AmNgwwsiM8HU4bALE1AzjjynfrmDC9aNbnbxp7a3xzd5VKQFj590ZiQ6gtknIxZj8bU h9GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hr70QJR2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a21-20020aa795b5000000b005639db953adsi2298454pfk.68.2022.11.11.05.29.25; Fri, 11 Nov 2022 05:29:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hr70QJR2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233934AbiKKMGe (ORCPT + 92 others); Fri, 11 Nov 2022 07:06:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233754AbiKKMGB (ORCPT ); Fri, 11 Nov 2022 07:06:01 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B4145FAD; Fri, 11 Nov 2022 04:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668168357; x=1699704357; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pI88ZoSjx1hCjSkxKLobYq2bfOrmMtrqowkx00L8oYs=; b=hr70QJR2oJIAVyCWPXjGgeMRIM/ZRw1EZNIh3aMvR8/E4yvBOjl7Cpz7 1liqpYFRFiVM7wOEoLpA6/rosOlarewh6azRhImh/GF5SVhfHwf7KC0wz U+YshKiNwgIi+G2tkPfO/5/x3prYxQJpykLCDHcWfpv2c45bg5eqyzEbG OiFR8DtCFD3ShBaDOdgrPhRrp5AcJeVqmX1MwhZECDMryWEY0mU4fmWVa tiToD2vkzIsFuYRNNE4rOC2Zg6uOfGY9z7oWlCHdCS4iC5nwDGPoGUZuj 7SPL3McJHEiD0rKeyaqkEpF/dLg1o14r9Xlxn5RZkMuOpe92CO5XnVduf w==; X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="309211181" X-IronPort-AV: E=Sophos;i="5.96,156,1665471600"; d="scan'208";a="309211181" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2022 04:05:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="780159429" X-IronPort-AV: E=Sophos;i="5.96,156,1665471600"; d="scan'208";a="780159429" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 11 Nov 2022 04:05:38 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1otSmv-00AgYO-1T; Fri, 11 Nov 2022 14:05:37 +0200 Date: Fri, 11 Nov 2022 14:05:37 +0200 From: Andy Shevchenko To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tianshu Qiu , Shawn Tu , Bingbu Cao , Mauro Carvalho Chehab Subject: Re: [PATCH v1 1/8] media: ov2740: Remove duplicative pointer in struct nvm_data Message-ID: References: <20220726120556.2881-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2022 at 05:10:35PM +0300, Andy Shevchenko wrote: > On Tue, Jul 26, 2022 at 03:05:49PM +0300, Andy Shevchenko wrote: > > The struct i2c_client pointer is used only to get driver data, > > associated with a struct device or print messages on behalf. > > Moreover, the very same pointer to a struct device is already > > assigned by a regmap and can be retrieved from there. > > No need to keep a duplicative pointer. > > Thanks, Bungbu, for the review. Can it be now applied? Don't see this being applied or commented why not... Mauro? Or who is taking care of this driver nowadays? -- With Best Regards, Andy Shevchenko