Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8958bf63-d5e4-9f3c-ad61-b85068cb2fd3@kernel.org>
Date:   Fri, 11 Nov 2022 15:35:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] net: ethernet: ti: cpsw_ale: optimize cpsw_ale_restore()
Content-Language: en-US
To:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     Ido Schimmel <idosch@idosch.org>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "vigneshr@ti.com" <vigneshr@ti.com>, "srk@ti.com" <srk@ti.com>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20221108135643.15094-1-rogerq@kernel.org>
 <20221109191941.6af4f71d@kernel.org>
 <32eacc9d-3866-149a-579a-41f8e405123f@kernel.org>
 <20221110123249.5f0e19df@kernel.org> <20221111120350.waumn6x35vwfnrfc@skbuf>
From:   Roger Quadros <rogerq@kernel.org>
In-Reply-To: <20221111120350.waumn6x35vwfnrfc@skbuf>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/11/2022 14:03, Vladimir Oltean wrote:
> On Thu, Nov 10, 2022 at 12:32:49PM -0800, Jakub Kicinski wrote:
>>> I have a question here. How should ageable entries be treated in this case?
>>
>> Ah, no idea :) Let's me add experts to To:
> 
> Not a real expert, but if suspend/resume loses the Ethernet link,
> I expect that no dynamically learned entries are preserved across
> a link loss event.

Understood. We loose the link in this particular case.

> 
> In DSA for example, we only keep ageable entries in hardware as long as
> the port STP state, plus BR_LEARNING port flag, are compatible with
> having such FDB entries. Otherwise, any transition to such a state
> flushes the ageable FDB entries.
> 
> A link loss generates a bridge port transition to the DISABLED state,
> which DSA uses to generate a SWITCHDEV_FDB_FLUSH_TO_BRIDGE event.
> 
> I'm not sure if it would even be possible to accurately do the right
> thing and update the ageing timer of the FDB entries with the amount of
> time that the system was suspended.

In that case I'll leave the entries as they are and let the Switch logic
deal with the stale entries. They should eventually get flushed out.

cheers,
-roger