Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2244321rwb; Fri, 11 Nov 2022 07:00:25 -0800 (PST) X-Google-Smtp-Source: AA0mqf4xeAE50GzWfMSfl3lKwGbLTxcXmbmms8Gr95AvREBcB2q8MOcheC84JACC/Ey6XunTgzNF X-Received: by 2002:aa7:c3d1:0:b0:45a:2d7c:f3a0 with SMTP id l17-20020aa7c3d1000000b0045a2d7cf3a0mr1806757edr.98.1668178825670; Fri, 11 Nov 2022 07:00:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668178825; cv=none; d=google.com; s=arc-20160816; b=Tuf07pi3tqT0pryw9mfEd0FZ7fJzDdTNRKOVfDlCJrkGzmzbMr30NJMDb0NPy2dzIe SEHcsQfSmZSTNag0wZWTAAnA8952iKWQGmiAiMXEGS5FgSXOk0zPDqDP0LDf4bamI3dn 2ZtUXoyQOndDY8v3aNf5+hQ86SESOms3XBKz32/3IYouHfoQoLZy7N7sQeyMb3d/0yzM N5VO5Z/jf/uVuuJSdWKOm7JAgSpdd4MYetwvw+VrcXVw7TWzw0cygxIliqE7aAEla6Yk yHB9AZPiVrlAk5GvyJHt2dBDUfkU7NAVbiS4LcggLMMUqu2E0PX2jAtPdlkbCUkYAIIe EGPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rxGaN+2HFd8fmu++thB1+61M14XRErmSFsbDID3TV/U=; b=rI7TrF0zAf45afIVN9VySGz4vSWsrwS2cCLiLHxBHikGcb906chHlZAg1sH926EYbu qI6Opyd2ecaSlur/d2MJtCVq3bhXD8a0B536ZetV+VY0qySvPPt/EwY6rQsrs1niYWHk xRmHoNr2sAsh9bD+Bo8k79raLBt7h4ilPU0ZbBhvqG+XRGIeo0aiHwzuImct99QqDjw2 zu9FSb7rQ2VMcQ3n4VRn38TBnapnVki3LrYnb2VkjEmfHMY5fwUccnWlueHFJf622vHT XhIr8RLMxjMeatxeJabf4dA+25OROqJpQ747l6xJJ+ibcBlKwqxb6ud/qNYtee6+3B+E Ctzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Q6jWQWCz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d3-20020a170906344300b00732fcbcfedesi1722973ejb.623.2022.11.11.07.00.01; Fri, 11 Nov 2022 07:00:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Q6jWQWCz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233633AbiKKOoI (ORCPT + 91 others); Fri, 11 Nov 2022 09:44:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234740AbiKKOnN (ORCPT ); Fri, 11 Nov 2022 09:43:13 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAFD365862; Fri, 11 Nov 2022 06:41:37 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id k2so13072021ejr.2; Fri, 11 Nov 2022 06:41:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rxGaN+2HFd8fmu++thB1+61M14XRErmSFsbDID3TV/U=; b=Q6jWQWCzMXhq7eCh71FSNeIJ7svvyBei2i7RNsGPHd3BlgB70oOdzSR4IJJG+Yfsrc 8THTiItI3AvFG8GMWY4oOdHzIh2I4j26qQ5PaWgqlXrPkOgGaDXxBeHyJMhiSsJOrw53 SsOKL22gDCI72uBvkZBkybPysorH1WPFf7NDNClsMaZk3Ke/JNxQlHTRq+F+ArQTrBGf 6bIkkb8/ScwJ81gpbC72YuHZkeoX4IHLCKq9miDdBDzcycrbkjbnuJtBYS+eAZSYzuMc 5qgqmhGYJMxmkqfdvBywGcR6tvo5fLCvq5GtQxv9SmF9dFdCN4NwMfcCSZrJeQs5+x0O wPoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rxGaN+2HFd8fmu++thB1+61M14XRErmSFsbDID3TV/U=; b=wVYsFbbgHsbjSpkorIUNlJJuIg+oJ50i9F0rBfRcK7mqpI+2gRY/0FIldQszUg+nYR SfTfFPU6oDXwFz3GjAbYO+4/Kbu2bfLRgYJsbeoIvxzoJx+BbyDJszEb3J3Y/CmYKJ3m bPm6fJ46zjj910HmteKMz5QCq0MzXbocJgsd4lG3WKHQHqIuVCInzhsvu9xzjVLIhSOO kTE0mpFYsvLa3gN1WsHxcjU/xKbFYrjp9arFaXU607c784xQvof7C8SLSOJHSwmQeVyv ULmm/YXUmVGLcxi+SsYcEwyYcN2JFRjZiX0+PSjHZQrChl/1GfXwEhQBeU87mPUH3uYN 7lfg== X-Gm-Message-State: ANoB5pk2FsM5f+X+FCi2pqc8K1Ze3J7elnB89AADAgb6s/DzeY497/2W qhgCQcTVqNkxAJbbE2ss2VtDV4goYb4= X-Received: by 2002:a17:906:5054:b0:79b:413b:d64 with SMTP id e20-20020a170906505400b0079b413b0d64mr1971719ejk.538.1668177696110; Fri, 11 Nov 2022 06:41:36 -0800 (PST) Received: from localhost (p200300e41f201d00f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f20:1d00:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id eg25-20020a056402289900b00457b5ba968csm1158729edb.27.2022.11.11.06.41.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 06:41:35 -0800 (PST) From: Thierry Reding To: Sumit Gupta , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, jonathanh@nvidia.com Cc: bbasu@nvidia.com Subject: Re: [Patch 1/4] soc/tegra: cbb: use correct master_id mask for cbb noc in Tegra194 Date: Fri, 11 Nov 2022 15:41:30 +0100 Message-Id: <166817763540.519550.6000067127559043663.b4-ty@nvidia.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221109135717.3809-1-sumitg@nvidia.com> References: <20221109135717.3809-1-sumitg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thierry Reding On Wed, 9 Nov 2022 19:27:14 +0530, Sumit Gupta wrote: > In Tegra194 SoC, master_id bit range is different between > cluster NOC and CBB NOC. Currently same bit range is used > which results in wrong master_id value. Due to this, > illegal accesses from the CCPLEX master do not result in a > crash as expected. Fix this by using the correct range for > the CBB NOC. > Finally, it is only necessary to extract the master_id when > the erd_mask_inband_err flag is set because when this is not > set, a crash is always triggered. > > [...] Applied, thanks! [1/4] soc/tegra: cbb: use correct master_id mask for cbb noc in Tegra194 (no commit info) [2/4] soc/tegra: cbb: update slave maps for Tegra234 (no commit info) [3/4] soc/tegra: cbb: add checks for potential out of bound errors (no commit info) [4/4] soc/tegra: cbb: check firewall before enabling error reporting (no commit info) Best regards, -- Thierry Reding